Skip to contentSkip to conversation

ixgbe: Fix to get FDMI HBA attributes information with X550

PATCH New Usha Ketineni 2 participants 2 messages Dec 8, 2015 – Jan 6, 2016

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ixgbe: Fix to get FDMI HBA attributes information with X550

Check whether the FCOE support is enabled for the devices to get the
FDMI HBA attributes information instead of checking each device id.
Also, add Model string information for X550.

---
 drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c +5 -2
index 5f98870..52a0378 100644
@@ -996,8 +996,7 @@ int ixgbe_fcoe_get_hbainfo(struct net_device *netdev,
 		return -EINVAL;
 
 	/* Don't return information on unsupported devices */
-	if (hw->mac.type != ixgbe_mac_82599EB &&
-	    hw->mac.type != ixgbe_mac_X540)
+	if (!(adapter->flags & IXGBE_FLAG_FCOE_ENABLED))
 		return -EINVAL;
 
 	/* Manufacturer */
@@ -1043,6 +1042,10 @@ int ixgbe_fcoe_get_hbainfo(struct net_device *netdev,
 		snprintf(info->model,
 			 sizeof(info->model),
 			 "Intel 82599");
+	} else if (hw->mac.type == ixgbe_mac_X550) {
+		snprintf(info->model,
+			 sizeof(info->model),
+			 "Intel X550");
 	} else {
 		snprintf(info->model,
 			 sizeof(info->model),
#1 lore raw

PATCH 1/1 ixgbe: Fix to get FDMI HBA attributes information with X550

Quoted 10 lines

-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On Behalf Of Usha Ketineni
Sent: Tuesday, December 08, 2015 4:01 AM
To: intel-wired-lan at lists.osuosl.org
Subject: [Intel-wired-lan] [PATCH] ixgbe: Fix to get FDMI HBA attributes information with X550

Quoted 6 lines

Check whether the FCOE support is enabled for the devices to get the FDMI HBA attributes information instead of checking each device id.
Also, add Model string information for X550.

---

The scope of my testing was limited to trying to find any issues that this patch might cause with standard (non-DCB) networking traffic.