libass: allow compilation without a system font provider

PATCH New Vicente Olivert Riera 3 participants 6 messages Dec 7, 2015 – Dec 13, 2015

Share & tools

Vicente Olivert Riera

author

2015-12-07 16:19 UTC #0 lore raw

PATCH 1/1 libass: allow compilation without a system font provider

If no system font provider is provided, then libass will fail to build because it requires one by default. The error looks like this:

configure: error: Either DirectWrite (on Windows), CoreText (on OSX), or Fontconfig(Linux, other) is required. If you really want to compile withouta system font provider, add --disable-require-system-font-provider

But, as the error messages says, we can allow the compilation without a system font provider if we use the above configure option, so let's do it.

Fixes:

http://autobuild.buildroot.net/results/3a4/3a4c07a0a54d5497fa8a4be2191856e286729637/

Signed-off-by Vicente Olivert Riera <[email protected]>

---
 package/libass/libass.mk | 3 +++
 1 file changed, 3 insertions(+)

package/libass/libass.mk +3 -0

index 83939e2..f1ec503 100644
@@ -24,6 +24,9 @@ ifeq ($(BR2_i386)$(BR2_x86_64),y)
 LIBASS_DEPENDENCIES += host-yasm
 endif
 
+# Allow compilation without a system font provider
+LIBASS_CONF_OPTS = --disable-require-system-font-provider
+
 ifeq ($(BR2_PACKAGE_FONTCONFIG),y)
 LIBASS_DEPENDENCIES += fontconfig
 LIBASS_CONF_OPTS += --enable-fontconfig

Signature · 1 line

2.4.10

Yann E. MORIN

2015-12-08 17:16 UTC #1 lore raw

PATCH 1/1 libass: allow compilation without a system font provider

Vicente, All,

On 2015-12-07 16:19 +0000, Vicente Olivert Riera spake thusly:

Quoted 26 lines

If no system font provider is provided, then libass will fail to build because it requires one by default. The error looks like this:
configure: error: Either DirectWrite (on Windows), CoreText (on OSX), or Fontconfig(Linux, other) is required. If you really want to compile withouta system font provider, add --disable-require-system-font-provider
But, as the error messages says, we can allow the compilation without a system font provider if we use the above configure option, so let's do it.
Fixes:
http://autobuild.buildroot.net/results/3a4/3a4c07a0a54d5497fa8a4be2191856e286729637/
Signed-off-by Vicente Olivert Riera <[email protected]>
---
 package/libass/libass.mk | 3 +++
 1 file changed, 3 insertions(+)
package/libass/libass.mk +0 -0
index 83939e2..f1ec503 100644

package/libass/libass.mk ifeq ($(BR2_i386)$(BR2_x86_64),y) · line 28

Quoted 5 lines

package/libass/libass.mk +2 -0

@@ -24,6 +24,9 @@ ifeq ($(BR2_i386)$(BR2_x86_64),y)
 LIBASS_DEPENDENCIES += host-yasm
 endif
 
+# Allow compilation without a system font provider
+LIBASS_CONF_OPTS = --disable-require-system-font-provider

It is my understanding that fontconfig *is* a "system font provider", so maybe that should go n the else-case for fontconfig, below?

package/libass/libass.mk ifeq ($(BR2_i386)$(BR2_x86_64),y) · line 32

Quoted 3 lines

package/libass/libass.mk +0 -0

 ifeq ($(BR2_PACKAGE_FONTCONFIG),y)
 LIBASS_DEPENDENCIES += fontconfig
 LIBASS_CONF_OPTS += --enable-fontconfig

Here:

    else
    LIBASS_CONF_OPTS += \
        --disable-fontconfig \
        --disable-require-system-font-provider
    endif

Regards,
Yann E. MORIN.

Quoted 7 lines

Signature · 6 lines

2.4.10

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 6 lines

.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

Vicente Olivert Riera

author

2015-12-09 10:19 UTC #2 lore raw

PATCH 1/1 libass: allow compilation without a system font provider

Hello Yann,

Quoted 41 lines · Yann E. MORIN

Vicente, All,
On 2015-12-07 16:19 +0000, Vicente Olivert Riera spake thusly:
Quoted 26 lines
If no system font provider is provided, then libass will fail to build because it requires one by default. The error looks like this:
configure: error: Either DirectWrite (on Windows), CoreText (on OSX), or Fontconfig(Linux, other) is required. If you really want to compile withouta system font provider, add --disable-require-system-font-provider
But, as the error messages says, we can allow the compilation without a system font provider if we use the above configure option, so let's do it.
Fixes:
http://autobuild.buildroot.net/results/3a4/3a4c07a0a54d5497fa8a4be2191856e286729637/
Signed-off-by Vicente Olivert Riera <[email protected]>
---
 package/libass/libass.mk | 3 +++
 1 file changed, 3 insertions(+)
package/libass/libass.mk +0 -0
index 83939e2..f1ec503 100644
package/libass/libass.mk ifeq ($(BR2_i386)$(BR2_x86_64),y) · line 28
Quoted 5 lines
package/libass/libass.mk +2 -0
@@ -24,6 +24,9 @@ ifeq ($(BR2_i386)$(BR2_x86_64),y)
 LIBASS_DEPENDENCIES += host-yasm
 endif
 
+# Allow compilation without a system font provider
+LIBASS_CONF_OPTS = --disable-require-system-font-provider
It is my understanding that fontconfig *is* a "system font provider", so maybe that should go n the else-case for fontconfig, below?
package/libass/libass.mk ifeq ($(BR2_i386)$(BR2_x86_64),y) · line 32
Quoted 3 lines
package/libass/libass.mk +0 -0
 ifeq ($(BR2_PACKAGE_FONTCONFIG),y)
 LIBASS_DEPENDENCIES += fontconfig
 LIBASS_CONF_OPTS += --enable-fontconfig

Quoted 7 lines

Here:

    else
    LIBASS_CONF_OPTS += \
        --disable-fontconfig \
        --disable-require-system-font-provider
    endif

That was my first approach, but then I thought a bit more about it, and I realized that there could be more system font providers in the future (not only fontconfig). So, by using that option we enable the possibility to build libass without a system font provider. That doesn't mean necessarily that libass will be built without one. If the fontconfig package is selected, it will be built with support for it.

Regards,

Vincent.

Yann E. MORIN

2015-12-09 17:28 UTC #3 lore raw

PATCH 1/1 libass: allow compilation without a system font provider

Vicente, All,

On 2015-12-09 10:19 +0000, Vicente Olivert Riera spake thusly:

Quoted 48 lines · Yann E. MORIN

Quoted 39 lines
On 2015-12-07 16:19 +0000, Vicente Olivert Riera spake thusly:
Quoted 26 lines
If no system font provider is provided, then libass will fail to build because it requires one by default. The error looks like this:
configure: error: Either DirectWrite (on Windows), CoreText (on OSX), or Fontconfig(Linux, other) is required. If you really want to compile withouta system font provider, add --disable-require-system-font-provider
But, as the error messages says, we can allow the compilation without a system font provider if we use the above configure option, so let's do it.
Fixes:
http://autobuild.buildroot.net/results/3a4/3a4c07a0a54d5497fa8a4be2191856e286729637/
Signed-off-by Vicente Olivert Riera <[email protected]>
---
 package/libass/libass.mk | 3 +++
 1 file changed, 3 insertions(+)
package/libass/libass.mk +0 -0
index 83939e2..f1ec503 100644
package/libass/libass.mk ifeq ($(BR2_i386)$(BR2_x86_64),y) · line 28
Quoted 5 lines
package/libass/libass.mk +2 -0
@@ -24,6 +24,9 @@ ifeq ($(BR2_i386)$(BR2_x86_64),y)
 LIBASS_DEPENDENCIES += host-yasm
 endif
 
+# Allow compilation without a system font provider
+LIBASS_CONF_OPTS = --disable-require-system-font-provider
It is my understanding that fontconfig *is* a "system font provider", so maybe that should go n the else-case for fontconfig, below?
package/libass/libass.mk ifeq ($(BR2_i386)$(BR2_x86_64),y) · line 32
Quoted 3 lines
package/libass/libass.mk +0 -0
 ifeq ($(BR2_PACKAGE_FONTCONFIG),y)
 LIBASS_DEPENDENCIES += fontconfig
 LIBASS_CONF_OPTS += --enable-fontconfig
Quoted 7 lines
Here:
    else
    LIBASS_CONF_OPTS += \
        --disable-fontconfig \
        --disable-require-system-font-provider
    endif

Quoted 6 lines

That was my first approach, but then I thought a bit more about it, and I realized that there could be more system font providers in the future (not only fontconfig). So, by using that option we enable the possibility to build libass without a system font provider. That doesn't mean necessarily that libass will be built without one. If the fontconfig package is selected, it will be built with support for it.

But since that is currently not the case (i.e. we have a single font provider), I think we should do as I suggest. When/if we have another font provider, then we can revisit that at that time.

And I don't know what other font provider we'd have on Linux, beside fontconfig. Arguably, I'm not a font expert either! ;-)

Regards,
Yann E. MORIN.

Signature · 6 lines

.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

Vicente Olivert Riera

author

2015-12-09 17:30 UTC #4 lore raw

PATCH 1/1 libass: allow compilation without a system font provider

Hi Yann,

Quoted 58 lines · Yann E. MORIN

Vicente, All,
On 2015-12-09 10:19 +0000, Vicente Olivert Riera spake thusly:
Quoted 48 lines · Yann E. MORIN
Quoted 39 lines
On 2015-12-07 16:19 +0000, Vicente Olivert Riera spake thusly:
Quoted 26 lines
If no system font provider is provided, then libass will fail to build because it requires one by default. The error looks like this:
configure: error: Either DirectWrite (on Windows), CoreText (on OSX), or Fontconfig(Linux, other) is required. If you really want to compile withouta system font provider, add --disable-require-system-font-provider
But, as the error messages says, we can allow the compilation without a system font provider if we use the above configure option, so let's do it.
Fixes:
http://autobuild.buildroot.net/results/3a4/3a4c07a0a54d5497fa8a4be2191856e286729637/
Signed-off-by Vicente Olivert Riera <[email protected]>
---
 package/libass/libass.mk | 3 +++
 1 file changed, 3 insertions(+)
package/libass/libass.mk +0 -0
index 83939e2..f1ec503 100644
package/libass/libass.mk ifeq ($(BR2_i386)$(BR2_x86_64),y) · line 28
Quoted 5 lines
package/libass/libass.mk +2 -0
@@ -24,6 +24,9 @@ ifeq ($(BR2_i386)$(BR2_x86_64),y)
 LIBASS_DEPENDENCIES += host-yasm
 endif
 
+# Allow compilation without a system font provider
+LIBASS_CONF_OPTS = --disable-require-system-font-provider
It is my understanding that fontconfig *is* a "system font provider", so maybe that should go n the else-case for fontconfig, below?
package/libass/libass.mk ifeq ($(BR2_i386)$(BR2_x86_64),y) · line 32
Quoted 3 lines
package/libass/libass.mk +0 -0
 ifeq ($(BR2_PACKAGE_FONTCONFIG),y)
 LIBASS_DEPENDENCIES += fontconfig
 LIBASS_CONF_OPTS += --enable-fontconfig
Quoted 7 lines
Here:
    else
    LIBASS_CONF_OPTS += \
        --disable-fontconfig \
        --disable-require-system-font-provider
    endif
Quoted 6 lines
That was my first approach, but then I thought a bit more about it, and I realized that there could be more system font providers in the future (not only fontconfig). So, by using that option we enable the possibility to build libass without a system font provider. That doesn't mean necessarily that libass will be built without one. If the fontconfig package is selected, it will be built with support for it.

Quoted 3 lines

But since that is currently not the case (i.e. we have a single font provider), I think we should do as I suggest. When/if we have another font provider, then we can revisit that at that time.

With my approach we won't need to revisit it :P

Quoted 2 lines

And I don't know what other font provider we'd have on Linux, beside fontconfig. Arguably, I'm not a font expert either! ;-)

Me neither.

Anyway, let's the maintainer decide.

Regards,

Vincent.

Quoted 3 lines

Regards,
Yann E. MORIN.

Bernd Kuhls

2015-12-13 17:00 UTC #5 lore raw

PATCH 1/1 libass: allow compilation without a system font provider

Am Wed, 09 Dec 2015 17:30:24 +0000 schrieb Vicente Olivert Riera:

Quoted 22 lines

Hi Yann,
Quoted 19 lines · Yann E. MORIN
Vicente, All,
On 2015-12-09 10:19 +0000, Vicente Olivert Riera spake thusly:
Quoted 16 lines · Yann E. MORIN
Quoted 15 lines
On 2015-12-07 16:19 +0000, Vicente Olivert Riera spake thusly:
package/libass/libass.mk ifeq ($(BR2_i386)$(BR2_x86_64),y) · line 28
Quoted 3 lines
package/libass/libass.mk +2 -0
+# Allow compilation without a system font provider
+LIBASS_CONF_OPTS = --disable-require-system-font-provider
It is my understanding that fontconfig *is* a "system font provider", so maybe that should go n the else-case for fontconfig, below?
Quoted 2 lines
ifeq ($(BR2_PACKAGE_FONTCONFIG),y) LIBASS_DEPENDENCIES += fontconfig LIBASS_CONF_OPTS += --enable-fontconfig
Here:
    else LIBASS_CONF_OPTS += \
        --disable-fontconfig \ --disable-require-system-font-provider
    endif

Hi Vicente, hi Yann,

reading your comments about this problem I created a patch
http://patchwork.ozlabs.org/patch/556201/
combining both of your approaches, what do you think?

Regards, Bernd