fm10k: IS_ENABLED() is not appropriate for boolean kconfig option
Subsystems (2)
PATCH 1/1 fm10k: IS_ENABLED() is not appropriate for boolean kconfig option
Tri-states need 'if IS_ENABLED()', booleans should use 'ifdef'.
Signed-off-by Bruce Allan <[email protected]>
--- drivers/net/ethernet/intel/fm10k/fm10k_netdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/ethernet/intel/fm10k/fm10k_netdev.c +3 -3
@@ -20,7 +20,7 @@#include "fm10k.h" #include <linux/vmalloc.h> -#if IS_ENABLED (CONFIG_FM10K_VXLAN ) +#ifdef CONFIG_FM10K_VXLAN #include <net/vxlan.h> #endif /* CONFIG_FM10K_VXLAN */
@@ -556,11 +556,11 @@ int fm10k_open(struct net_device *netdev)if (err) goto err_set_queues; -#if IS_ENABLED (CONFIG_FM10K_VXLAN ) +#ifdef CONFIG_FM10K_VXLAN /* update VXLAN port configuration */ vxlan_get_rx_port (netdev); -#endif +fm10k_up (interface);return 0 ;
Singh
PATCH 1/1 fm10k: IS_ENABLED() is not appropriate for boolean kconfig option
-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On Behalf Of Bruce Allan
Sent: Tuesday, December 8, 2015 5:21 PM
To: [email protected]
Subject: [Intel-wired-lan] [PATCH] fm10k: IS_ENABLED() is not appropriate for boolean kconfig option
Tri-states need 'if IS_ENABLED()', booleans should use 'ifdef'.
Signed-off-by Bruce Allan <[email protected]>
---
Tested-by Krishneil Singh <[email protected]>