Skip to contentSkip to conversation

sh64: fix __NR_fgetxattr

PATCH In review Dmitry V. Levin 2 participants 2 messages Dec 9, 2015 SuperH

lore
Share & tools
lore

Dmitry V. Levin

author
#0 lore raw

PATCH 1/1 sh64: fix __NR_fgetxattr

According to arch/sh/kernel/syscalls_64.S and common sense, __NR_fgetxattr has to be defined to 259, but it doesn't. Instead, it's defined to 269, which is of course used by another syscall, __NR_sched_setaffinity in this case.

This bug was found by strace test suite.

Signed-off-by Dmitry V. Levin <[email protected]>
Cc [email protected]
---
 arch/sh/include/uapi/asm/unistd_64.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/sh/include/uapi/asm/unistd_64.h +1 -1
index e6820c8..47ebd5b 100644
@@ -278,7 +278,7 @@
 #define __NR_fsetxattr		256
 #define __NR_getxattr		257
 #define __NR_lgetxattr		258
-#define __NR_fgetxattr		269
+#define __NR_fgetxattr		259
 #define __NR_listxattr		260
 #define __NR_llistxattr		261
 #define __NR_flistxattr		262
Signature · 1 line
ldv
Acked-by on v1 1/1
#1 lore raw

CC akpm

Quoted 9 lines · Dmitry V. Levin

According to arch/sh/kernel/syscalls_64.S and common sense, __NR_fgetxattr has to be defined to 259, but it doesn't. Instead, it's defined to 269, which is of course used by another syscall, __NR_sched_setaffinity in this case.

This bug was found by strace test suite.

Signed-off-by Dmitry V. Levin <[email protected]>
Cc [email protected]
Acked-by Geert Uytterhoeven <[email protected]>
Quoted 9 lines
---
 arch/sh/include/uapi/asm/unistd_64.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/sh/include/uapi/asm/unistd_64.h +0 -0
index e6820c8..47ebd5b 100644

arch/sh/include/uapi/asm/unistd_64.h line 284

Quoted 8 lines
arch/sh/include/uapi/asm/unistd_64.h +1 -1
@@ -278,7 +278,7 @@
 #define __NR_fsetxattr         256
 #define __NR_getxattr          257
 #define __NR_lgetxattr         258
-#define __NR_fgetxattr         269
+#define __NR_fgetxattr         259
 #define __NR_listxattr         260
 #define __NR_llistxattr                261
 #define __NR_flistxattr                262

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds