Skip to contentSkip to conversation

x86 fpu: command-line parameters broken post-FPU-rewrite

DISCUSSION Dave Hansen 3 participants 3 messages Dec 8, 2015 – Dec 9, 2015

lore
Share & tools
lore
#0 lore raw

Hey Ingo,

We were starting to look at reenabling XSAVES support and tried to use the 'noxsave' and 'noxsaves' kernel command-line options. The rewrite moved the FPU initialization to before we even are parsing command-line options, even the early_param()s.

Do you have any preferences on how it gets fixed?

The most obvious thing would be to just defer as much of the FPU setup as we can until after parse_early_param() has happened. The only other think I can think of doing would be to try to do some *really* early, simple, command-line parsing to look for 'noxsave' and friends.

Thoughts?

#1 lore raw
Quoted 7 lines · Dave Hansen

Hey Ingo,

We were starting to look at reenabling XSAVES support and tried to use the 'noxsave' and 'noxsaves' kernel command-line options. The rewrite moved the FPU initialization to before we even are parsing command-line options, even the early_param()s.

Quoted 8 lines

Do you have any preferences on how it gets fixed?

The most obvious thing would be to just defer as much of the FPU setup as we can until after parse_early_param() has happened. The only other think I can think of doing would be to try to do some *really* early, simple, command-line parsing to look for 'noxsave' and friends.

Thoughts?

Hm, so given that having the FPU operational is key to a functioning kernel (and other kernel subsystems may make use of FPU functionality), I'd rather bring option parsing earlier than change the FPU setup sequence. FPU setup should be done when we identify the CPU - not 'very late' as we used to.

Thanks,

Ingo

#2 lore raw
Quoted 17 lines · Ingo Molnar
Quoted 14 lines · Dave Hansen

Hey Ingo,

We were starting to look at reenabling XSAVES support and tried to use the 'noxsave' and 'noxsaves' kernel command-line options. The rewrite moved the FPU initialization to before we even are parsing command-line options, even the early_param()s.

Do you have any preferences on how it gets fixed?

The most obvious thing would be to just defer as much of the FPU setup as we can until after parse_early_param() has happened. The only other think I can think of doing would be to try to do some *really* early, simple, command-line parsing to look for 'noxsave' and friends.

Quoted 6 lines
Quoted 1 line

Thoughts?

Hm, so given that having the FPU operational is key to a functioning kernel (and other kernel subsystems may make use of FPU functionality), I'd rather bring option parsing earlier than change the FPU setup sequence. FPU setup should be done when we identify the CPU - not 'very late' as we used to.

We already have early cmdline parsing: arch/x86/lib/cmdline.c

See users for examples.

Signature · 4 lines
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.