mlxsw: spectrum: fix some error handling

PATCH Applied Dan Carpenter 3 participants 3 messages Dec 9, 2015 – Dec 12, 2015

Subsystems (4)

Networking Network drivers Kernel janitors Mellanox Ethernet switch drivers

lore

Share & tools

lore

Dan Carpenter

author

2015-12-09 10:33 UTC #0 lore raw

PATCH 1/1 mlxsw: spectrum: fix some error handling

The "err = " assignment is missing here.

Fixes 0d65fc13042f ('mlxsw: spectrum: Implement LAG port join/leave')

Signed-off-by Dan Carpenter <[email protected]>

drivers/net/ethernet/mellanox/mlxsw/spectrum.c +1 -1

index 3ec07b9..322ed54 100644
@@ -2091,7 +2091,7 @@ static int mlxsw_sp_port_lag_leave(struct mlxsw_sp_port *mlxsw_sp_port,
 	err = mlxsw_sp_lag_col_port_disable(mlxsw_sp_port, lag_id);
 	if (err)
 		return err;
-	mlxsw_sp_lag_col_port_remove(mlxsw_sp_port, lag_id);
+	err = mlxsw_sp_lag_col_port_remove(mlxsw_sp_port, lag_id);
 	if (err)
 		return err;

Jiri Pirko

Acked-by on v1 1/1

2015-12-09 10:47 UTC #1 lore raw

Quoted 4 lines · Wed, Dec 09, 2015 at 11:33:51AM CET, [email protected] wrote:

The "err = " assignment is missing here.
Fixes 0d65fc13042f ('mlxsw: spectrum: Implement LAG port join/leave')
Signed-off-by Dan Carpenter <[email protected]>

Acked-by Jiri Pirko <[email protected]>

Thanks.

David Miller

maintainer Applied

2015-12-12 01:15 UTC #2 lore raw

In reply to Dan Carpenter

From: Dan Carpenter <[email protected]>
Date: Wed, 9 Dec 2015 13:33:51 +0300

Quoted 4 lines

The "err = " assignment is missing here.
Fixes 0d65fc13042f ('mlxsw: spectrum: Implement LAG port join/leave')
Signed-off-by Dan Carpenter <[email protected]>

Applied.