Skip to contentSkip to conversation

gpio: ath79: Fix the logic to clear offset bit of AR71XX_GPIO_REG_OE register

PATCH In review Axel Lin 3 participants 3 messages Dec 8, 2015 – Dec 11, 2015

Subsystems (2)
GPIO Atheros 71XX/9XXX GPIO driver
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 gpio: ath79: Fix the logic to clear offset bit of AR71XX_GPIO_REG_OE register

Signed-off-by Axel Lin <[email protected]>
---
 drivers/gpio/gpio-ath79.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpio/gpio-ath79.c +1 -1
index e5827a5..5eaea8b 100644
@@ -113,7 +113,7 @@ static int ar934x_gpio_direction_output(struct gpio_chip *chip, unsigned offset,
 		__raw_writel(BIT(offset), ctrl->base + AR71XX_GPIO_REG_CLEAR);
 
 	__raw_writel(
-		__raw_readl(ctrl->base + AR71XX_GPIO_REG_OE) & BIT(offset),
+		__raw_readl(ctrl->base + AR71XX_GPIO_REG_OE) & ~BIT(offset),
 		ctrl->base + AR71XX_GPIO_REG_OE);
 
 	spin_unlock_irqrestore(&ctrl->lock, flags);
Signature · 1 line
2.1.4
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 1 line · On Tue, 08 Dec 2015 23:01:07 +0800 Axel Lin <[email protected]> wrote:
Signed-off-by Axel Lin <[email protected]>
Acked-by Alban Bedel <[email protected]>
Quoted 17 lines
---
 drivers/gpio/gpio-ath79.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpio/gpio-ath79.c +1 -1
index e5827a5..5eaea8b 100644
@@ -113,7 +113,7 @@ static int ar934x_gpio_direction_output(struct gpio_chip *chip, unsigned offset,
 		__raw_writel(BIT(offset), ctrl->base + AR71XX_GPIO_REG_CLEAR);
 
 	__raw_writel(
-		__raw_readl(ctrl->base + AR71XX_GPIO_REG_OE) & BIT(offset),
+		__raw_readl(ctrl->base + AR71XX_GPIO_REG_OE) & ~BIT(offset),
 		ctrl->base + AR71XX_GPIO_REG_OE);
 
 	spin_unlock_irqrestore(&ctrl->lock, flags);