ARM SMC Calling Convention interface
v5 cover ARM SMC Calling Convention interface
Hi,
This patch set is based on the Generic TEE subsystem v6 patchset
(https://lwn.net/Articles/662495/) sent out a few weeks ago. By isolating the ARM SMC Calling Convention patches that are useful for other purposes than to support the Generic TEE subsystem some complexity is removed from that patch set.
This patch set adds a common interface to do an SMC or HVC following ARM SMC Calling Convention. The interface is implemented for both the arm and arm64 architectures and updates the PSCI driver to use this interface instead for firmware communication.
v5:
* Fixes compile errors for Thumb-2 kernels reported by Kevin Hilman
* drivers: psci: replace psci firmware calls
v4:
* Rebased on v4.4-rc3 to resolve a PSCI conflict
* drivers: psci: replace psci firmware calls
v3:
* Moved the export of arm_smccc_{smc,hvc} to armksyms.c for both arm and arm64
* arm: add implementation for arm-smccc
* arm64: add implementation for arm-smccc
drivers: psci: replace psci firmware calls
v2:
* Added unwinding support in the assembly functions
Thanks,
Jens
Jens Wiklander (4):
arm/arm64: add arm-smccc
arm: add implementation for arm-smccc
arm64: add implementation for arm-smccc
drivers: psci: replace psci firmware calls
arch/arm/Kconfig | 1 + arch/arm/kernel/Makefile | 3 +- arch/arm/kernel/armksyms.c | 6 +++ arch/arm/kernel/psci-call.S | 31 ------------- arch/arm/kernel/smccc-call.S | 62 ++++++++++++++++++++++++++ arch/arm64/Kconfig | 1 + arch/arm64/kernel/Makefile | 4 +- arch/arm64/kernel/arm64ksyms.c | 5 +++ arch/arm64/kernel/asm-offsets.c | 3 ++ arch/arm64/kernel/psci-call.S | 28 ------------ arch/arm64/kernel/smccc-call.S | 43 ++++++++++++++++++ drivers/firmware/psci.c | 23 +++++++++- include/linux/arm-smccc.h | 98 +++++++++++++++++++++++++++++++++++++++++ init/Kconfig | 3 ++ 14 files changed, 247 insertions(+), 64 deletions(-) delete mode 100644 arch/arm/kernel/psci-call.S create mode 100644 arch/arm/kernel/smccc-call.S delete mode 100644 arch/arm64/kernel/psci-call.S create mode 100644 arch/arm64/kernel/smccc-call.S create mode 100644 include/linux/arm-smccc.h
Signature · 1 line
1.9.1
PATCH v5 1/4 arm/arm64: add arm-smccc
Adds helpers to do SMC and HVC based on ARM SMC Calling Convention. CONFIG_HAVE_ARM_SMCCC is enabled for architectures that may support the SMC or HVC instruction. It's the responsibility of the caller to know if the SMC instruction is supported by the platform.
This patch doesn't provide an implementation of the declared functions. Later patches will bring in implementations and set CONFIG_HAVE_ARM_SMCCC for ARM and ARM64 respectively.
--- include/linux/arm-smccc.h | 98 +++++++++++++++++++++++++++++++++++++++++++++++ init/Kconfig | 3 ++ 2 files changed, 101 insertions(+) create mode 100644 include/linux/arm-smccc.h
include/linux/arm-smccc.h new file +98 -0
@@ -0,0 +1,98 @@ +/* +* Copyright (c) 2015, Linaro Limited +* +* This software is licensed under the terms of the GNU General Public +* License version 2, as published by the Free Software Foundation, and +* may be copied, distributed, and modified under those terms. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +* GNU General Public License for more details. +* +*/ +#ifndef __LINUX_ARM_SMCCC_H +#define __LINUX_ARM_SMCCC_H + +#include <linux/types.h> +#include <linux/linkage.h> + +/* +* This file provides common defines for ARM SMC Calling Convention as +* specified in +* http://infocenter.arm.com/help/topic/com.arm.doc.den0028a/index.html +*/ + +#define ARM_SMCCC_SMC_32 (0 << 30) +#define ARM_SMCCC_SMC_64 (1 << 30) +#define ARM_SMCCC_FAST_CALL (1 << 31) +#define ARM_SMCCC_STD_CALL (0 << 31) + +#define ARM_SMCCC_OWNER_MASK 0x3F +#define ARM_SMCCC_OWNER_SHIFT 24 + +#define ARM_SMCCC_FUNC_MASK 0xFFFF + +#define ARM_SMCCC_IS_FAST_CALL (smc_val) ((smc_val) & ARM_SMCCC_FAST_CALL) +#define ARM_SMCCC_IS_64 (smc_val) ((smc_val) & ARM_SMCCC_SMC_64) +#define ARM_SMCCC_FUNC_NUM (smc_val) ((smc_val) & ARM_SMCCC_FUNC_MASK) +#define ARM_SMCCC_OWNER_NUM (smc_val) \ + (((smc_val) >> ARM_SMCCC_OWNER_SHIFT) & ARM_SMCCC_OWNER_MASK) + +#define ARM_SMCCC_CALL_VAL (type, calling_convention, owner, func_num) \ + ((type) | (calling_convention) | \ + (((owner) & ARM_SMCCC_OWNER_MASK) << ARM_SMCCC_OWNER_SHIFT) | \ + ((func_num) & ARM_SMCCC_FUNC_MASK)) + +#define ARM_SMCCC_OWNER_ARCH 0 +#define ARM_SMCCC_OWNER_CPU 1 +#define ARM_SMCCC_OWNER_SIP 2 +#define ARM_SMCCC_OWNER_OEM 3 +#define ARM_SMCCC_OWNER_STANDARD 4 +#define ARM_SMCCC_OWNER_TRUSTED_APP 48 +#define ARM_SMCCC_OWNER_TRUSTED_APP_END 49 +#define ARM_SMCCC_OWNER_TRUSTED_OS 50 +#define ARM_SMCCC_OWNER_TRUSTED_OS_END 63 + +/** +* struct arm_smccc_res - Result from SMC/HVC call +* @a0-a3 result values from registers 0 to 3 +*/ +struct arm_smccc_res { +unsigned long a0; +unsigned long a1; +unsigned long a2; +unsigned long a3; +}; + +/** +* arm_smccc_smc() - make SMC calls +* @a0-a7: arguments passed in registers 0 to 7 +* @res: result values from registers 0 to 3 +* +* This function is used to make SMC calls following SMC Calling Convention. +* The content of the supplied param are copied to registers 0 to 7 prior +* to the SMC instruction. The return values are updated with the content +* from register 0 to 3 on return from the SMC instruction. +*/ +asmlinkage void arm_smccc_smc(unsigned long a0, unsigned long a1, +unsigned long a2,unsigned long a3,unsigned long a4, +unsigned long a5,unsigned long a6,unsigned long a7, +struct arm_smccc_res *res); + +/** +* arm_smccc_hvc() - make HVC calls +* @a0-a7: arguments passed in registers 0 to 7 +* @res: result values from registers 0 to 3 +* +* This function is used to make HVC calls following SMC Calling +* Convention. The content of the supplied param are copied to registers 0 +* to 7 prior to the HVC instruction. The return values are updated with +* the content from register 0 to 3 on return from the HVC instruction. +*/ +asmlinkage void arm_smccc_hvc(unsigned long a0, unsigned long a1, +unsigned long a2,unsigned long a3,unsigned long a4, +unsigned long a5,unsigned long a6,unsigned long a7, +struct arm_smccc_res *res); + +#endif /*__LINUX_ARM_SMCCC_H*/
init/Kconfig +3 -0
@@ -2061,3 +2061,6 @@ config ASN1 functions to call on what tags. source "kernel/Kconfig.locks" + +config HAVE_ARM_SMCCC + bool
Signature · 1 line
1.9.1
PATCH v5 1/4 arm/arm64: add arm-smccc
init/Kconfig config ASN1 · line 2066
Quoted 11 lines · Jens Wiklander
init/Kconfig +3
-0@@ -2061,3 +2061,6 @@ config ASN1 functions to call on what tags. source "kernel/Kconfig.locks" + +config HAVE_ARM_SMCCC + bool
I'm not sure why this has ended up in init/Kconfig - I suspect others will end up wondering the same. arch/Kconfig looks to be a better place for it which is likely to be less controversial. Please could you move it there?
Thanks.
Signature · 3 lines
RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.
PATCH v5 1/4 arm/arm64: add arm-smccc
Quoted 8 lines · Russell King - ARM Linux
Quoted 7 lines · Jens Wiklander
init/Kconfig +0
-0@@ -2061,3 +2061,6 @@ config ASN1 functions to call on what tags.
Quoted 9 lines
init/Kconfig config ASN1 · line 2066
Quoted 4 lines
init/Kconfig +3
-0source "kernel/Kconfig.locks" + +config HAVE_ARM_SMCCC + boolI'm not sure why this has ended up in init/Kconfig - I suspect others will end up wondering the same.
arch/Kconfiglooks to be a better place for it which is likely to be less controversial. Please could you move it there?
Thanks, I'll fix.
/Jens
PATCH v5 2/4 arm: add implementation for arm-smccc
In reply to Jens WiklanderAdds implementation for arm-smccc and enables CONFIG_HAVE_SMCCC for architectures that may support arm-smccc. It's the responsibility of the caller to know if the SMC instruction is supported by the platform.
--- arch/arm/Kconfig | 1 + arch/arm/kernel/Makefile | 2 ++ arch/arm/kernel/armksyms.c | 6 +++++ arch/arm/kernel/smccc-call.S | 62 ++++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 71 insertions(+) create mode 100644 arch/arm/kernel/smccc-call.S
arch/arm/Kconfig +1 -0
@@ -327,6 +327,7 @@ config ARCH_MULTIPLATFORM select CLKSRC_OF select COMMON_CLK select GENERIC_CLOCKEVENTS + select HAVE_ARM_SMCCC if CPU_V7 select MIGHT_HAVE_PCI select MULTI_IRQ_HANDLER select SPARSE_IRQ
arch/arm/kernel/Makefile +2 -0
@@ -92,4 +92,6 @@ obj-y += psci-call.o obj-$(CONFIG_SMP) += psci_smp.o endif +obj-$(CONFIG_HAVE_ARM_SMCCC) += smccc-call.o + extra-y := $(head-y) vmlinux.lds
arch/arm/kernel/armksyms.c +6 -0
@@ -16,6 +16,7 @@#include <linux/syscalls.h> #include <linux/uaccess.h> #include <linux/io.h> +#include <linux/arm-smccc.h> #include <asm/checksum.h> #include <asm/ftrace.h>
@@ -175,3 +176,8 @@ EXPORT_SYMBOL(__gnu_mcount_nc);EXPORT_SYMBOL (__pv_phys_pfn_offset);EXPORT_SYMBOL (__pv_offset);#endif + +#ifdef CONFIG_HAVE_ARM_SMCCC +EXPORT_SYMBOL (arm_smccc_smc); +EXPORT_SYMBOL (arm_smccc_hvc); +#endif
arch/arm/kernel/smccc-call.S new file +62 -0
62 lines not on this page · raw message
Signature · 1 line
1.9.1
PATCH v5 3/4 arm64: add implementation for arm-smccc
In reply to Jens WiklanderAdds implementation for arm-smccc and enables CONFIG_HAVE_SMCCC.
--- arch/arm64/Kconfig | 1 + arch/arm64/kernel/Makefile | 2 +- arch/arm64/kernel/arm64ksyms.c | 5 +++++ arch/arm64/kernel/asm-offsets.c | 3 +++ arch/arm64/kernel/smccc-call.S | 43 +++++++++++++++++++++++++++++++++++++++++ 5 files changed, 53 insertions(+), 1 deletion(-) create mode 100644 arch/arm64/kernel/smccc-call.S
arch/arm64/Kconfig +1 -0
@@ -92,6 +92,7 @@ config ARM64 select SPARSE_IRQ select SYSCTL_EXCEPTION_TRACE select HAVE_CONTEXT_TRACKING + select HAVE_ARM_SMCCC help ARM 64-bit (AArch64) Linux support.
arch/arm64/kernel/Makefile +1 -1
@@ -17,7 +17,7 @@ arm64-obj-y := debug-monitors.o entry.o irq.o fpsimd.o \ hyp-stub.o psci.o psci-call.o cpu_ops.o insn.o \ return_address.o cpuinfo.o cpu_errata.o \ cpufeature.o alternative.o cacheinfo.o \ - smp.o smp_spin_table.o topology.o + smp.o smp_spin_table.o topology.o smccc-call.o extra-$(CONFIG_EFI) := efi-entry.o
arch/arm64/kernel/arm64ksyms.c +5 -0
@@ -26,6 +26,7 @@#include <linux/syscalls.h> #include <linux/uaccess.h> #include <linux/io.h> +#include <linux/arm-smccc.h> #include <asm/checksum.h>
@@ -68,3 +69,7 @@ EXPORT_SYMBOL(test_and_change_bit);#ifdef CONFIG_FUNCTION_TRACER EXPORT_SYMBOL (_mcount);#endif + +/* arm-smccc */ +EXPORT_SYMBOL (arm_smccc_smc); +EXPORT_SYMBOL (arm_smccc_hvc);
arch/arm64/kernel/asm-offsets.c +3 -0
@@ -28,6 +28,7 @@#include <asm/suspend.h> #include <asm/vdso_datapage.h> #include <linux/kbuild.h> +#include <linux/arm-smccc.h> int main (void ) {
@@ -161,5 +162,7 @@ int main(void)DEFINE (SLEEP_SAVE_SP_PHYS , offsetof(struct sleep_save_sp , save_ptr_stash_phys));DEFINE (SLEEP_SAVE_SP_VIRT , offsetof(struct sleep_save_sp , save_ptr_stash));#endif +DEFINE (ARM_SMCCC_RES_X0_OFFS , offsetof(struct arm_smccc_res , a0)); +DEFINE (ARM_SMCCC_RES_X2_OFFS , offsetof(struct arm_smccc_res , a2));return 0 ; }
arch/arm64/kernel/smccc-call.S new file +43 -0
43 lines not on this page · raw message
Signature · 1 line
1.9.1
PATCH v5 4/4 drivers: psci: replace psci firmware calls
In reply to Jens WiklanderSwitch to use a generic interface for issuing SMC/HVC based on ARM SMC Calling Convention. Removes now the now unused psci-call.S.
--- arch/arm/kernel/Makefile | 1 - arch/arm/kernel/psci-call.S | 31 ------------------------------- arch/arm64/kernel/Makefile | 2 +- arch/arm64/kernel/psci-call.S | 28 ---------------------------- drivers/firmware/psci.c | 23 +++++++++++++++++++++-- 5 files changed, 22 insertions(+), 63 deletions(-) delete mode 100644 arch/arm/kernel/psci-call.S delete mode 100644 arch/arm64/kernel/psci-call.S
arch/arm/kernel/Makefile +0 -1
@@ -88,7 +88,6 @@ obj-$(CONFIG_EARLY_PRINTK) += early_printk.o obj-$(CONFIG_ARM_VIRT_EXT) += hyp-stub.o ifeq ($(CONFIG_ARM_PSCI),y) -obj-y += psci-call.o obj-$(CONFIG_SMP) += psci_smp.o endif
arch/arm/kernel/psci-call.S deleted +0 -31
@@ -1,31 +0,0 @@ -/* - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License version 2 as - * published by the Free Software Foundation. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * Copyright (C) 2015 ARM Limited - * - * Author: Mark Rutland <[email protected]> - */ - -#include <linux/linkage.h> - -#include <asm/opcodes-sec.h> -#include <asm/opcodes-virt.h> - -/* int __invoke_psci_fn_hvc(u32 function_id, u32 arg0, u32 arg1, u32 arg2) */ -ENTRY(__invoke_psci_fn_hvc) - __HVC(0) - bx lr -ENDPROC(__invoke_psci_fn_hvc) - -/* int __invoke_psci_fn_smc(u32 function_id, u32 arg0, u32 arg1, u32 arg2) */ -ENTRY(__invoke_psci_fn_smc) - __SMC(0) - bx lr -ENDPROC(__invoke_psci_fn_smc)
arch/arm64/kernel/Makefile +1 -1
@@ -14,7 +14,7 @@ CFLAGS_REMOVE_return_address.o = -pg arm64-obj-y := debug-monitors.o entry.o irq.o fpsimd.o \ entry-fpsimd.o process.o ptrace.o setup.o signal.o \ sys.o stacktrace.o time.o traps.o io.o vdso.o \ - hyp-stub.o psci.o psci-call.o cpu_ops.o insn.o \ + hyp-stub.o psci.o cpu_ops.o insn.o \ return_address.o cpuinfo.o cpu_errata.o \ cpufeature.o alternative.o cacheinfo.o \ smp.o smp_spin_table.o topology.o smccc-call.o
arch/arm64/kernel/psci-call.S deleted +0 -28
@@ -1,28 +0,0 @@ -/* - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License version 2 as - * published by the Free Software Foundation. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * Copyright (C) 2015 ARM Limited - * - * Author: Will Deacon <[email protected]> - */ - -#include <linux/linkage.h> - -/* int __invoke_psci_fn_hvc(u64 function_id, u64 arg0, u64 arg1, u64 arg2) */ -ENTRY(__invoke_psci_fn_hvc) - hvc #0 - ret -ENDPROC(__invoke_psci_fn_hvc) - -/* int __invoke_psci_fn_smc(u64 function_id, u64 arg0, u64 arg1, u64 arg2) */ -ENTRY(__invoke_psci_fn_smc) - smc #0 - ret -ENDPROC(__invoke_psci_fn_smc)
drivers/firmware/psci.c +21 -2
@@ -13,6 +13,7 @@#define pr_fmt (fmt) "psci: " fmt +#include <linux/arm-smccc.h> #include <linux/errno.h> #include <linux/linkage.h> #include <linux/of.h>
@@ -58,8 +59,6 @@ struct psci_operations psci_ops;typedef unsigned long (psci_fn )(unsigned long ,unsigned long ,unsigned long ,unsigned long ); -asmlinkage psci_fn __invoke_psci_fn_hvc; -asmlinkage psci_fn __invoke_psci_fn_smc;static psci_fn *invoke_psci_fn;enum psci_function {
@@ -107,6 +106,26 @@ bool psci_power_state_is_valid(u32 state)return !(state & ~valid_mask); } +static unsigned long __invoke_psci_fn_hvc (unsigned long function_id, +unsigned long arg0,unsigned long arg1, +unsigned long arg2) +{ +struct arm_smccc_res res; + +arm_smccc_hvc (function_id, arg0, arg1, arg2,0 ,0 ,0 ,0 , &res); +return res.a0; +} + +static unsigned long __invoke_psci_fn_smc (unsigned long function_id, +unsigned long arg0,unsigned long arg1, +unsigned long arg2) +{ +struct arm_smccc_res res; + +arm_smccc_smc (function_id, arg0, arg1, arg2,0 ,0 ,0 ,0 , &res); +return res.a0; +} +static int psci_to_linux_errno (int errno) {switch (errno) {
Signature · 1 line
1.9.1
v5 cover ARM SMC Calling Convention interface
In reply to Jens WiklanderHi Jens,
Quoted 10 lines · Jens Wiklander
This patch set is based on the Generic TEE subsystem v6 patchset
(https://lwn.net/Articles/662495/) sent out a few weeks ago. By isolating the ARM SMC Calling Convention patches that are useful for other purposes than to support the Generic TEE subsystem some complexity is removed from that patch set.This patch set adds a common interface to do an SMC or HVC following ARM SMC Calling Convention. The interface is implemented for both the arm and arm64 architectures and updates the PSCI driver to use this interface instead for firmware communication.
Build and boot tested on a variety of arm32 and arm64 platforms using kernelci.org. The previous THUMB2_KERNEL=y build failures are gone.
kernelci.org results:
Build: http://kernelci.org/build/arm-soc/kernel/v4.4-rc3-4-gccfbab1c1ebd/
Boot: http://kernelci.org/boot/all/job/arm-soc/kernel/v4.4-rc3-4-gccfbab1c1ebd/
(NOTE: the boot failures there appear to be lab-related issues, not related tot his patch.)
Kevin