extensions: libxt_mark: Add translation to nft
PATCH v2 1/1 extensions: libxt_mark: Add translation to nft
Add translation of the metainformation mark to nft.
---
Changes in v2:
Fix syntax according to nft and remove trailing whitespaces
extensions/libxt_mark.c | 64 +++++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 62 insertions(+), 2 deletions(-)
extensions/libxt_mark.c +62 -2
@@ -75,7 +75,7 @@ mark_print(const void *ip, const struct xt_entry_match *match, int numeric)if (info->invert)printf (" !" ); - +print_mark (info->mark, info->mask); }
@@ -97,11 +97,69 @@ mark_save(const void *ip, const struct xt_entry_match *match)if (info->invert)printf (" !" ); - +printf (" --mark" );print_mark (info->mark, info->mask); } +static void +print_mark_xlate (struct xt_buf *buf, +unsigned int mark,unsigned int mask) +{ +if (mask !=0xffffffffU ) +xt_buf_add (buf," & x%x == x%x" , mark, mask); +else +xt_buf_add (buf," & x%x" , mark); +} + +static void +mark_mt_xlate_print (const struct xt_entry_match *match, +struct xt_buf *buf,int numeric) +{ +const struct xt_mark_mtinfo1 *info = (const void *)match->data; + +if (info->invert) +xt_buf_add (buf," !=" ); +print_mark_xlate (buf, info->mark, info->mask); +} + +static int +mark_mt_xlate (const struct xt_entry_match *match, +struct xt_buf *buf,int numeric) +{ +const struct xt_mark_mtinfo1 *info = (const void *)match->data; + +xt_buf_add (buf,"ct mark %s" , info->invert ?" !=" :"" ); +print_mark_xlate (buf, info->mark, info->mask); +xt_buf_add (buf," " ); + +return 1 ; +} + +static void +mark_xlate_print (const struct xt_entry_match *match, +struct xt_buf *buf,int numeric) +{ +const struct xt_mark_info *info = (const void *)match->data; + +if (info->invert) +xt_buf_add (buf," !=" ); +print_mark_xlate (buf, info->mark, info->mask); +} + +static int +mark_xlate (const struct xt_entry_match *match, +struct xt_buf *buf,int numeric) +{ +const struct xt_mark_info *info = (const void *)match->data; + +xt_buf_add (buf,"ct mark %s" , info->invert ?" !=" :"" ); +print_mark_xlate (buf, info->mark, info->mask); +xt_buf_add (buf," " ); + +return 1 ; +} +static struct xtables_match mark_mt_reg[] = { { .family =NFPROTO_UNSPEC ,
@@ -115,6 +173,7 @@ static struct xtables_match mark_mt_reg[] = { .save = mark_save, .x6_parse = mark_parse, .x6_options = mark_mt_opts, + .xlate = mark_xlate, }, { .version = XTABLES_VERSION,
@@ -128,6 +187,7 @@ static struct xtables_match mark_mt_reg[] = { .save = mark_mt_save, .x6_parse = mark_mt_parse, .x6_options = mark_mt_opts, + .xlate = mark_mt_xlate, }, };
Signature · 1 line
1.9.1
Pablo Neira Ayuso
maintainerQuoted 1 line · Shivani Bhardwaj
Add translation of the metainformation mark to nft.
Much better, but I still need some changes.
Could you include in the description the commands and the result of testing this, eg.
$ iptables-xlate -I INPUT -m mark --mark 20 nft add rule filter INPUT mark 20
Several examples like that would be good covering all possible cases, just to make sure you're testing all possible branches in the code (even if this kind of manual way, there are better ways to cover-test this in an automated way but this simple testing is fine by now).
More comments below.
Quoted 51 lines
Signed-off-by Shivani Bhardwaj <[email protected]>---
Changes in v2:
Fix syntax according to nft and remove trailing whitespacesextensions/libxt_mark.c | 64 +++++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 62 insertions(+), 2 deletions(-)extensions/libxt_mark.c +22
-2@@ -75,7 +75,7 @@ mark_print(const void *ip, const struct xt_entry_match *match, int numeric)if (info->invert)printf (" !" ); - +print_mark (info->mark, info->mask); }@@ -97,11 +97,69 @@ mark_save(const void *ip, const struct xt_entry_match *match)if (info->invert)printf (" !" ); - +printf (" --mark" );print_mark (info->mark, info->mask); } +static void +print_mark_xlate (struct xt_buf *buf, +unsigned int mark,unsigned int mask) +{ +if (mask !=0xffffffffU ) +xt_buf_add (buf," & x%x == x%x" , mark, mask); +else +xt_buf_add (buf," & x%x" , mark); +} + +static void +mark_mt_xlate_print (const struct xt_entry_match *match, +struct xt_buf *buf,int numeric) +{ +const struct xt_mark_mtinfo1 *info = (const void *)match->data; + +if (info->invert) +xt_buf_add (buf," !=" ); +print_mark_xlate (buf, info->mark, info->mask); +}
extensions/libxt_mark.c mark_save(const void *ip, const struct xt_entry_match *match) · line 134
Quoted 10 lines
extensions/libxt_mark.c +10
-0+ +static int +mark_mt_xlate (const struct xt_entry_match *match, +struct xt_buf *buf,int numeric) +{ +const struct xt_mark_mtinfo1 *info = (const void *)match->data; + +xt_buf_add (buf,"ct mark %s" , info->invert ?" !=" :"" ); +print_mark_xlate (buf, info->mark, info->mask); +xt_buf_add (buf," " );
^^^^^^^^
This indentation is not correct.
extensions/libxt_mark.c mark_save(const void *ip, const struct xt_entry_match *match) · line 147
Quoted 13 lines
extensions/libxt_mark.c +13
-0+ +return 1 ; +} + +static void +mark_xlate_print (const struct xt_entry_match *match, +struct xt_buf *buf,int numeric) +{ +const struct xt_mark_info *info = (const void *)match->data; + +if (info->invert) +xt_buf_add (buf," !=" ); +print_mark_xlate (buf, info->mark, info->mask);
^^^
Same here.
Thanks.
Quoted 11 lines · Pablo Neira Ayuso
Quoted 1 line · Shivani Bhardwaj
Add translation of the metainformation mark to nft.
Much better, but I still need some changes.
Could you include in the description the commands and the result of testing this, eg.
$ iptables-xlate -I INPUT -m mark --mark 20 nft add rule filter INPUT mark 20
Hi Pablo,
I don't get these results.
I get the following:
nft # -I INPUT -m mark --mark 123
What could be the reason for this? A bug in the code or some dependency? I have checked the code. It seems to follow the correct pattern as per the latest 6 patches.
Could you please help?
Quoted 70 lines
Several examples like that would be good covering all possible cases, just to make sure you're testing all possible branches in the code (even if this kind of manual way, there are better ways to cover-test this in an automated way but this simple testing is fine by now).
More comments below.
Quoted 51 lines
Signed-off-by Shivani Bhardwaj <[email protected]>---
Changes in v2:
Fix syntax according to nft and remove trailing whitespacesextensions/libxt_mark.c | 64 +++++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 62 insertions(+), 2 deletions(-)extensions/libxt_mark.c +22
-2@@ -75,7 +75,7 @@ mark_print(const void *ip, const struct xt_entry_match *match, int numeric)if (info->invert)printf (" !" ); - +print_mark (info->mark, info->mask); }@@ -97,11 +97,69 @@ mark_save(const void *ip, const struct xt_entry_match *match)if (info->invert)printf (" !" ); - +printf (" --mark" );print_mark (info->mark, info->mask); } +static void +print_mark_xlate (struct xt_buf *buf, +unsigned int mark,unsigned int mask) +{ +if (mask !=0xffffffffU ) +xt_buf_add (buf," & x%x == x%x" , mark, mask); +else +xt_buf_add (buf," & x%x" , mark); +} + +static void +mark_mt_xlate_print (const struct xt_entry_match *match, +struct xt_buf *buf,int numeric) +{ +const struct xt_mark_mtinfo1 *info = (const void *)match->data; + +if (info->invert) +xt_buf_add (buf," !=" ); +print_mark_xlate (buf, info->mark, info->mask); +}extensions/libxt_mark.c mark_save(const void *ip, const struct xt_entry_match *match) · line 134
Quoted 10 lines
extensions/libxt_mark.c +10
-0+ +static int +mark_mt_xlate (const struct xt_entry_match *match, +struct xt_buf *buf,int numeric) +{ +const struct xt_mark_mtinfo1 *info = (const void *)match->data; + +xt_buf_add (buf,"ct mark %s" , info->invert ?" !=" :"" ); +print_mark_xlate (buf, info->mark, info->mask); +xt_buf_add (buf," " );^^^^^^^^
Quoted 2 lines
This indentation is not correct.
I'm using checkpatch to look for indentation errors now. Sorry for the inconvenience caused.
Thank you
Quoted 18 lines
extensions/libxt_mark.c mark_save(const void *ip, const struct xt_entry_match *match) · line 147
Quoted 13 lines
extensions/libxt_mark.c +13
-0+ +return 1 ; +} + +static void +mark_xlate_print (const struct xt_entry_match *match, +struct xt_buf *buf,int numeric) +{ +const struct xt_mark_info *info = (const void *)match->data; + +if (info->invert) +xt_buf_add (buf," !=" ); +print_mark_xlate (buf, info->mark, info->mask);^^^Same here.
Thanks.
Quoted 94 lines · Shivani Bhardwaj
Quoted 11 lines · Pablo Neira Ayuso
Quoted 1 line · Shivani Bhardwaj
Add translation of the metainformation mark to nft.
Much better, but I still need some changes.
Could you include in the description the commands and the result of testing this, eg.
$ iptables-xlate -I INPUT -m mark --mark 20 nft add rule filter INPUT mark 20Hi Pablo,
I don't get these results.
I get the following:
nft # -I INPUT -m mark --mark 123What could be the reason for this? A bug in the code or some dependency? I have checked the code. It seems to follow the correct pattern as per the latest 6 patches.
Could you please help?Quoted 70 lines
Several examples like that would be good covering all possible cases, just to make sure you're testing all possible branches in the code (even if this kind of manual way, there are better ways to cover-test this in an automated way but this simple testing is fine by now).
More comments below.
Quoted 51 lines
Signed-off-by Shivani Bhardwaj <[email protected]>---
Changes in v2:
Fix syntax according to nft and remove trailing whitespacesextensions/libxt_mark.c | 64 +++++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 62 insertions(+), 2 deletions(-)extensions/libxt_mark.c +22
-2@@ -75,7 +75,7 @@ mark_print(const void *ip, const struct xt_entry_match *match, int numeric)if (info->invert)printf (" !" ); - +print_mark (info->mark, info->mask); }@@ -97,11 +97,69 @@ mark_save(const void *ip, const struct xt_entry_match *match)if (info->invert)printf (" !" ); - +printf (" --mark" );print_mark (info->mark, info->mask); } +static void +print_mark_xlate (struct xt_buf *buf, +unsigned int mark,unsigned int mask) +{ +if (mask !=0xffffffffU ) +xt_buf_add (buf," & x%x == x%x" , mark, mask); +else +xt_buf_add (buf," & x%x" , mark); +} + +static void +mark_mt_xlate_print (const struct xt_entry_match *match, +struct xt_buf *buf,int numeric) +{ +const struct xt_mark_mtinfo1 *info = (const void *)match->data; + +if (info->invert) +xt_buf_add (buf," !=" ); +print_mark_xlate (buf, info->mark, info->mask); +}extensions/libxt_mark.c mark_save(const void *ip, const struct xt_entry_match *match) · line 134
Quoted 10 lines
extensions/libxt_mark.c +10
-0+ +static int +mark_mt_xlate (const struct xt_entry_match *match, +struct xt_buf *buf,int numeric) +{ +const struct xt_mark_mtinfo1 *info = (const void *)match->data; + +xt_buf_add (buf,"ct mark %s" , info->invert ?" !=" :"" ); +print_mark_xlate (buf, info->mark, info->mask); +xt_buf_add (buf," " );^^^^^^^^
Quoted 26 lines
Quoted 2 lines
This indentation is not correct.
I'm using checkpatch to look for indentation errors now. Sorry for the inconvenience caused.
Thank you
Quoted 18 lines
extensions/libxt_mark.c mark_save(const void *ip, const struct xt_entry_match *match) · line 147
Quoted 13 lines
extensions/libxt_mark.c +13
-0+ +return 1 ; +} + +static void +mark_xlate_print (const struct xt_entry_match *match, +struct xt_buf *buf,int numeric) +{ +const struct xt_mark_info *info = (const void *)match->data; + +if (info->invert) +xt_buf_add (buf," !=" ); +print_mark_xlate (buf, info->mark, info->mask);^^^Same here.
Thanks.
Hi,
While writing another patch, I realized I've done some mismatch in the name of print functions (comparing with the patch for libxt_tcp). Could you please suggest me the correct naming convention for them if this is the case. I've tried some but they don't seem to be working.
If the reason is something else please let me know.
Also, please tell how the functions are logged in the binary iptables-translate.
Thank you
Quoted 129 lines · Shivani Bhardwaj
Quoted 94 lines · Shivani Bhardwaj
Quoted 11 lines · Pablo Neira Ayuso
Quoted 1 line · Shivani Bhardwaj
Add translation of the metainformation mark to nft.
Much better, but I still need some changes.
Could you include in the description the commands and the result of testing this, eg.
$ iptables-xlate -I INPUT -m mark --mark 20 nft add rule filter INPUT mark 20Hi Pablo,
I don't get these results.
I get the following:
nft # -I INPUT -m mark --mark 123What could be the reason for this? A bug in the code or some dependency? I have checked the code. It seems to follow the correct pattern as per the latest 6 patches.
Could you please help?Quoted 70 lines
Several examples like that would be good covering all possible cases, just to make sure you're testing all possible branches in the code (even if this kind of manual way, there are better ways to cover-test this in an automated way but this simple testing is fine by now).
More comments below.
Quoted 51 lines
Signed-off-by Shivani Bhardwaj <[email protected]>---
Changes in v2:
Fix syntax according to nft and remove trailing whitespacesextensions/libxt_mark.c | 64 +++++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 62 insertions(+), 2 deletions(-)extensions/libxt_mark.c +22
-2@@ -75,7 +75,7 @@ mark_print(const void *ip, const struct xt_entry_match *match, int numeric)if (info->invert)printf (" !" ); - +print_mark (info->mark, info->mask); }@@ -97,11 +97,69 @@ mark_save(const void *ip, const struct xt_entry_match *match)if (info->invert)printf (" !" ); - +printf (" --mark" );print_mark (info->mark, info->mask); } +static void +print_mark_xlate (struct xt_buf *buf, +unsigned int mark,unsigned int mask) +{ +if (mask !=0xffffffffU ) +xt_buf_add (buf," & x%x == x%x" , mark, mask); +else +xt_buf_add (buf," & x%x" , mark); +} + +static void +mark_mt_xlate_print (const struct xt_entry_match *match, +struct xt_buf *buf,int numeric) +{ +const struct xt_mark_mtinfo1 *info = (const void *)match->data; + +if (info->invert) +xt_buf_add (buf," !=" ); +print_mark_xlate (buf, info->mark, info->mask); +}extensions/libxt_mark.c mark_save(const void *ip, const struct xt_entry_match *match) · line 134
Quoted 10 lines
extensions/libxt_mark.c +10
-0+ +static int +mark_mt_xlate (const struct xt_entry_match *match, +struct xt_buf *buf,int numeric) +{ +const struct xt_mark_mtinfo1 *info = (const void *)match->data; + +xt_buf_add (buf,"ct mark %s" , info->invert ?" !=" :"" ); +print_mark_xlate (buf, info->mark, info->mask); +xt_buf_add (buf," " );^^^^^^^^
Quoted 26 lines
Quoted 2 lines
This indentation is not correct.
I'm using checkpatch to look for indentation errors now. Sorry for the inconvenience caused.
Thank you
Quoted 18 lines
extensions/libxt_mark.c mark_save(const void *ip, const struct xt_entry_match *match) · line 147
Quoted 13 lines
extensions/libxt_mark.c +13
-0+ +return 1 ; +} + +static void +mark_xlate_print (const struct xt_entry_match *match, +struct xt_buf *buf,int numeric) +{ +const struct xt_mark_info *info = (const void *)match->data; + +if (info->invert) +xt_buf_add (buf," !=" ); +print_mark_xlate (buf, info->mark, info->mask);^^^Same here.
Thanks.
Hi,
While writing another patch, I realized I've done some mismatch in the name of print functions (comparing with the patch for
libxt_tcp). Could you please suggest me the correct naming convention for them if this is the case. I've tried some but they don't seem to be working.
Quoted 5 lines
If the reason is something else please let me know.
Also, please tell how the functions are logged in the binary iptables-translate.
Thank you
Hi,
So far, I've been able to figure out that the problem is arising because of wrong return value by the function xlate of xtables-translate. This return value is further dependent on a function cb() which I am not able to understand. Could you please help me with this?
Thank you
Pablo Neira Ayuso
maintainerQuoted 7 lines · Shivani Bhardwaj
Hi,
So far, I've been able to figure out that the problem is arising because of wrong return value by the function xlate of xtables-translate. This return value is further dependent on a function
cb()which I am not able to understand. Could you please help me with this?
I'm getting this here:
libxt_mark.c:116:1: warning: ‘mark_mt_xlate_print’ defined but not used [-Wunused-function]
mark_mt_xlate_print(const struct xt_entry_match *match, ^
libxt_mark.c:140:1: warning: ‘mark_xlate_print’ defined but not used [-Wunused-function]
mark_xlate_print(const struct xt_entry_match *match,
^
These two functions are unused, so there is some problem there.
But, anyway after applying you patch I can see:
# iptables-translate -I INPUT -m mark --mark 10 nft insert rule ip filter INPUT ct mark & xa counter
So this kind of work already.
Be careful about shared libraries for extensions (here I have them at /usr/lib/xtables/*.so or maybe you have it at /usr/local/lib/xtables)
The thing is that probably you have an older iptables installation, so you iptables-translate binary refers to the old .so file which has no translation.
So make sure you don't have several .so in your setup, probably that's the problem.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 32 lines · Pablo Neira Ayuso
Quoted 7 lines · Shivani Bhardwaj
Hi,
So far, I've been able to figure out that the problem is arising because of wrong return value by the function xlate of xtables-translate. This return value is further dependent on a function
cb()which I am not able to understand. Could you please help me with this?I'm getting this here:
libxt_mark.c:116:1: warning: ‘mark_mt_xlate_print’ defined but not used [-Wunused-function]
mark_mt_xlate_print(const structxt_entry_match*match, ^
libxt_mark.c:140:1: warning: ‘mark_xlate_print’ defined but not used [-Wunused-function]
mark_xlate_print(const structxt_entry_match*match,
^These two functions are unused, so there is some problem there.
But, anyway after applying you patch I can see:
# iptables-translate -I INPUT -m mark --mark 10 nft insert rule ip filter INPUT ct mark & xa counterSo this kind of work already.
Be careful about shared libraries for extensions (here I have them at
/usr/lib/xtables/*.soor maybe you have it at/usr/local/lib/xtables)
Quoted 6 lines
The thing is that probably you have an older iptables installation, so you iptables-translate binary refers to the old .so file which has no translation.
So make sure you don't have several .so in your setup, probably that's the problem.
I had multiple .so files. Thanks a lot. It works now. Also, I have done some other patches but I need to know if the syntax I have used in them goes in accordance with nftables. Is there any source to see that? I'm able to figure out some by seeing the examples on wiki page. But, I'm confused with some other ones.
Thank you
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 20 lines · Pablo Neira Ayuso
Quoted 7 lines · Shivani Bhardwaj
Hi,
So far, I've been able to figure out that the problem is arising because of wrong return value by the function xlate of xtables-translate. This return value is further dependent on a function
cb()which I am not able to understand. Could you please help me with this?I'm getting this here:
libxt_mark.c:116:1: warning: ‘mark_mt_xlate_print’ defined but not used [-Wunused-function]
mark_mt_xlate_print(const structxt_entry_match*match, ^
libxt_mark.c:140:1: warning: ‘mark_xlate_print’ defined but not used [-Wunused-function]
mark_xlate_print(const structxt_entry_match*match,
^
Quoted 9 lines
These two functions are unused, so there is some problem there.
But, anyway after applying you patch I can see:
# iptables-translate -I INPUT -m mark --mark 10 nft insert rule ip filter INPUT ct mark & xa counterSo this kind of work already.
Hi,
I just tried adding this rule to nft. It does not work. It only works for integer values of mark. nft shows syntax error for ampersand and hex values.
Isn't there something wrong? Please let me know.
Thank you
Quoted 9 lines
Be careful about shared libraries for extensions (here I have them at
/usr/lib/xtables/*.soor maybe you have it at/usr/local/lib/xtables)The thing is that probably you have an older iptables installation, so you iptables-translate binary refers to the old .so file which has no translation.
So make sure you don't have several .so in your setup, probably that's the problem.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Pablo Neira Ayuso
maintainerQuoted 9 lines · Shivani Bhardwaj
Quoted 7 lines · Pablo Neira Ayuso
But, anyway after applying you patch I can see:
# iptables-translate -I INPUT -m mark --mark 10 nft insert rule ip filter INPUT ct mark & xa counterSo this kind of work already.
Quoted 7 lines
Hi,
I just tried adding this rule to nft. It does not work. It only works for integer values of mark. nft shows syntax error for ampersand and hex values.
Isn't there something wrong? Please let me know.
The line above should be:
nft insert rule ip filter INPUT ct mark & 0xa counter
You have to add a simple table and chain configuration to test it:
nft add table filter
nft add chain filter INPUT { type filter hook input priority 0\; }
The two lines above create a filter table, then it adds an INPUT chain to that table.
The correct translation for:
iptables-translate -I INPUT -m mark --mark 10
is:
nft insert rule ip filter INPUT ct mark 0xa counter
Then for:
iptables-translate -I INPUT -m mark --mark 10/10
is:
nft insert rule ip filter INPUT ct mark and 0xa == 0xa counter
You have to take the time to find the right translation too and make sure they work.
Thanks.
Quoted 16 lines · Pablo Neira Ayuso
Quoted 15 lines · Shivani Bhardwaj
Quoted 7 lines · Pablo Neira Ayuso
But, anyway after applying you patch I can see:
# iptables-translate -I INPUT -m mark --mark 10 nft insert rule ip filter INPUT ct mark & xa counterSo this kind of work already.
Hi,
I just tried adding this rule to nft. It does not work. It only works for integer values of mark. nft shows syntax error for ampersand and hex values.
Quoted 6 lines
Quoted 1 line
Isn't there something wrong? Please let me know.
The line above should be:
nft insert rule ip filter INPUT ct mark &
0xacounter
One more question. Why ct mark when we have no conntrack information in this module? Shouldn't ct mark be a complete module of conntrack?
Quoted 28 lines
You have to add a simple table and chain configuration to test it:
nft add table filter
nft add chain filter INPUT { type filter hook input priority 0\; }The two lines above create a filter table, then it adds an INPUT chain to that table.
The correct translation for:
iptables-translate -I INPUT -m mark --mark 10
is:
nft insert rule ip filter INPUT ct mark
0xacounterThen for:
iptables-translate -I INPUT -m mark --mark 10/10
is:
nft insert rule ip filter INPUT ct mark and
0xa==0xacounterYou have to take the time to find the right translation too and make sure they work.
Thanks.
Quoted 17 lines · Shivani Bhardwaj
Quoted 16 lines · Pablo Neira Ayuso
Quoted 15 lines · Shivani Bhardwaj
Quoted 7 lines · Pablo Neira Ayuso
But, anyway after applying you patch I can see:
# iptables-translate -I INPUT -m mark --mark 10 nft insert rule ip filter INPUT ct mark & xa counterSo this kind of work already.
Hi,
I just tried adding this rule to nft. It does not work. It only works for integer values of mark. nft shows syntax error for ampersand and hex values.
Quoted 7 lines
Quoted 6 lines
Quoted 1 line
Isn't there something wrong? Please let me know.
The line above should be:
nft insert rule ip filter INPUT ct mark &
0xacounter
Ampersand again causes syntax error. However, it works fine as below:
nft insert rule ip filter INPUT ct mark 0xa counter
Please tell me if this is wrong.
Quoted 31 lines
One more question. Why ct mark when we have no conntrack information in this module? Shouldn't ct mark be a complete module of conntrack?
Quoted 28 lines
You have to add a simple table and chain configuration to test it:
nft add table filter
nft add chain filter INPUT { type filter hook input priority 0\; }The two lines above create a filter table, then it adds an INPUT chain to that table.
The correct translation for:
iptables-translate -I INPUT -m mark --mark 10
is:
nft insert rule ip filter INPUT ct mark
0xacounterThen for:
iptables-translate -I INPUT -m mark --mark 10/10
is:
nft insert rule ip filter INPUT ct mark and
0xa==0xacounterYou have to take the time to find the right translation too and make sure they work.
Thanks.
A message that is not in the archive (sent off-list or not yet received): 20151219183443.GA2170@salvia
Quoted 28 lines · Pablo Neira Ayuso
Quoted 27 lines · Shivani Bhardwaj
Quoted 24 lines · Shivani Bhardwaj
Quoted 22 lines · Pablo Neira Ayuso
Quoted 9 lines · Shivani Bhardwaj
Quoted 7 lines · Pablo Neira Ayuso
But, anyway after applying you patch I can see:
# iptables-translate -I INPUT -m mark --mark 10 nft insert rule ip filter INPUT ct mark & xa counterSo this kind of work already.
Quoted 7 lines
Hi,
I just tried adding this rule to nft. It does not work. It only works for integer values of mark. nft shows syntax error for ampersand and hex values.
Isn't there something wrong? Please let me know.
The line above should be:
nft insert rule ip filter INPUT ct mark &
0xacounter
Quoted 5 lines
Quoted 3 lines
Ampersand again causes syntax error. However, it works fine as below:
nft insert rule ip filter INPUT ct mark
0xacounterYes, that is fine as I indicated in a previous email.
Thank you.
Could you please tell why ct mark and not simply mark?
Pablo Neira Ayuso
maintainerQuoted 10 lines · Shivani Bhardwaj
Quoted 6 lines · Pablo Neira Ayuso
Quoted 3 lines · Shivani Bhardwaj
Ampersand again causes syntax error. However, it works fine as below:
nft insert rule ip filter INPUT ct mark
0xacounterYes, that is fine as I indicated in a previous email.
Thank you.
Could you please tell why ct mark and not simply mark?
This should obviously be simply mark, not ct mark.