Skip to contentSkip to conversation

crypto: qat - uint8_t is not large enough for accel_id

PATCH In review Dan Carpenter 3 participants 3 messages Dec 10, 2015 – Dec 14, 2015

Subsystems (2)
Kernel janitors Crypto API
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 crypto: qat - uint8_t is not large enough for accel_id

->accel_id has to be large enough to hold ADF_MAX_DEVICES + 1 (which is 1025) so uint8_t is too small.

Fixes 890c55f4dc0e ('crypto: qat - add support for c3xxx accel type')
Signed-off-by Dan Carpenter <[email protected]>
drivers/crypto/qat/qat_common/adf_accel_devices.h +1 -1
index 4d78ec0..1e1cdef 100644
@@ -251,6 +251,6 @@ struct adf_accel_dev {
 		} vf;
 	};
 	bool is_vf;
-	uint8_t accel_id;
+	unsigned int accel_id;
 } __packed;
 #endif
#1 lore raw

Hi Dan,

Quoted 11 lines · Dan Carpenter

->accel_id has to be large enough to hold ADF_MAX_DEVICES + 1 (which is 1025) so uint8_t is too small.

Fixes 890c55f4dc0e ('crypto: qat - add support for c3xxx accel type')
Signed-off-by Dan Carpenter <[email protected]>
drivers/crypto/qat/qat_common/adf_accel_devices.h +0 -0
index 4d78ec0..1e1cdef 100644

drivers/crypto/qat/qat_common/adf_accel_devices.h struct adf_accel_dev { · line 256

Quoted 7 lines
drivers/crypto/qat/qat_common/adf_accel_devices.h +1 -1
@@ -251,6 +251,6 @@ struct adf_accel_dev {
 		} vf;
 	};
 	bool is_vf;
-	uint8_t accel_id;
+	unsigned int accel_id;
 } __packed;
 #endif

Yes, that's correct. That was part of my next patchset, but since you sent the patch..
We also need to change the corresponding field in the struct adf_dev_status_info, and change the instance_id to match the instance_id in the adf_hw_device_data struct.
I would also prefer u32 instead of unsigned int.

---8<---
accel_id has to be large enough to hold ADF_MAX_DEVICES + 1 (which is > 1025) so uint8_t is too small.

Reported-by Dan Carpenter <[email protected]>
Signed-off-by Tadeusz Struk <[email protected]>

---

drivers/crypto/qat/qat_common/adf_accel_devices.h +1 -1
index 4d78ec0..f96d427 100644
@@ -251,6 +251,6 @@ struct adf_accel_dev {
 		} vf;
 	};
 	bool is_vf;
-	uint8_t accel_id;
+	u32 accel_id;
 } __packed;
 #endif
drivers/crypto/qat/qat_common/adf_cfg_common.h +2 -2
index 673dbf7..8c4f657 100644
@@ -80,8 +80,8 @@ enum adf_device_type {
 
 struct adf_dev_status_info {
 	enum adf_device_type type;
-	uint8_t accel_id;
-	uint8_t instance_id;
+	u32 accel_id;
+	u32 instance_id;
 	uint8_t num_ae;
 	uint8_t num_accel;
 	uint8_t num_logical_accel;