staging: goldfish: Coding Style Fix Comparison to NULL could
PATCH 1/1 staging: goldfish: Coding Style Fix Comparison to NULL could
Quoted 1 line
From
4b8ce6b3bd7effdfff2c95fbeb4a20cb93d5e9e5Mon Sep 17 00:00:00 2001
From: Benjamin Young <[email protected]>
Date: Thu, 10 Dec 2015 17:31:00 -0500
Subject: [PATCH] staging: goldfish: Coding Style Fix - spaces preferred around
that '+'
Helped improve coding style to make arithemethic easier to read
--- drivers/staging/goldfish/goldfish_audio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/goldfish/goldfish_audio.c +1 -1
@@ -63,7 +63,7 @@ struct goldfish_audio {#define AUDIO_READ (data, addr) (readl(data->reg_base + addr))#define AUDIO_WRITE (data, addr, x) (writel(x, data->reg_base + addr))#define AUDIO_WRITE64 (data, addr, addr2, x) \ - (gf_write_dma_addr((x), data->reg_base + addr, data->reg_base+addr2)) + (gf_write_dma_addr((x), data->reg_base + addr, data->reg_base + addr2))/* * temporary variable used between goldfish_audio_probe() and
Signature · 1 line
2.5.0
Quoted 5 lines · Benjamin Young
From
4b8ce6b3bd7effdfff2c95fbeb4a20cb93d5e9e5Mon Sep 17 00:00:00 2001
From: Benjamin Young <[email protected]>
Date: Thu, 10 Dec 2015 17:31:00 -0500
Subject: [PATCH] staging: goldfish: Coding Style Fix - spaces preferred around
that '+'
Regarding all the three patches: The above header information should not be here.
Regarding this patch: This is a repeat of the previous patch with the subject of the next patch.
regards
sudip
Quoted 7 lines · Sudip Mukherjee
Quoted 5 lines · Benjamin Young
From
4b8ce6b3bd7effdfff2c95fbeb4a20cb93d5e9e5Mon Sep 17 00:00:00 2001
From: Benjamin Young <[email protected]>
Date: Thu, 10 Dec 2015 17:31:00 -0500
Subject: [PATCH] staging: goldfish: Coding Style Fix - spaces preferred around
that '+'
Quoted 8 lines
Regarding all the three patches: The above header information should not be here.
Regarding this patch: This is a repeat of the previous patch with the subject of the next patch.
regards
sudip
Sorry about the duplicate emails with one having the wrong subject line. My fingers betrayed me and hit Enter before I was done editing
As for the header information, i will remove it and send out the patches
Thank you again for being so pacient, since i am a noobie to kernel development
Thanks,
Benjamin