ARM: mvebu: kirkwood: add PogoPlug series 4 device tree

PATCH Superseded Linus Walleij 2 participants 3 messages Dec 11, 2015 – Dec 14, 2015

Subsystems (2)

Device tree bindings Arm and arm64 SoC sub-architectures (common parts)

lore

Share & tools

lore

Linus Walleij

author

2015-12-11 08:57 UTC #0 lore raw

PATCH v2 2/2 ARM: mvebu: kirkwood: add PogoPlug series 4 device tree

This adds a device tree for the CloudEngines PogoPlug series 4 NAS device. Inspired by out-of-tree boardfiles from ArchLinux by Kevin Mihelich.

Cc Moonman <[email protected]>

Cc Kevin Mihelich <[email protected]>

Signed-off-by Linus Walleij <[email protected]>

---
ChangeLog v1->v2:
- Use <dt-bindings/input/linux-event-codes.h>
- Specify default baud rate etc differently
- Rename LEDs "pogoplugv4*"
- Skip registering i2c0 as there is nothing on it

---
 arch/arm/boot/dts/Makefile                       |   1 +
 arch/arm/boot/dts/kirkwood-pogoplug-series-4.dts | 179 +++++++++++++++++++++++
 2 files changed, 180 insertions(+)
 create mode 100644 arch/arm/boot/dts/kirkwood-pogoplug-series-4.dts

arch/arm/boot/dts/Makefile +1 -0

index 30bbc3746130..2d9f475a9ceb 100644
@@ -206,6 +206,7 @@ dtb-$(CONFIG_MACH_KIRKWOOD) += \
 	kirkwood-openrd-client.dtb \
 	kirkwood-openrd-ultimate.dtb \
 	kirkwood-pogo_e02.dtb \
+	kirkwood-pogoplug-series-4.dtb \
 	kirkwood-rd88f6192.dtb \
 	kirkwood-rd88f6281-z0.dtb \
 	kirkwood-rd88f6281-a.dtb \

arch/arm/boot/dts/kirkwood-pogoplug-series-4.dts new file +179 -0

179 lines not on this page · raw message

Signature · 1 line

2.4.3

Andrew Lunn

2015-12-11 14:39 UTC #1 lore raw

PATCH v2 2/2 ARM: mvebu: kirkwood: add PogoPlug series 4 device tree

Hi Linus

arch/arm/boot/dts/kirkwood-pogoplug-series-4.dts line 102

Quoted 4 lines

+&uart0 {
arch/arm/boot/dts/kirkwood-pogoplug-series-4.dts new file +3 -0
+	status = "okay";
+	current-speed = <115200>;
+};

You should not need this. There are no other DTS files with it. As far as i understand, the bootloader may add this to the DT blob before passing it to the kernel, but i doubt the stock bootloader on your device is doing it.

Otherwise this looks good.

Andrew

Linus Walleij

author

2015-12-14 14:29 UTC #2 lore raw

PATCH v2 2/2 ARM: mvebu: kirkwood: add PogoPlug series 4 device tree

Quoted 8 lines · Andrew Lunn

Hi Linus
arch/arm/boot/dts/kirkwood-pogoplug-series-4.dts line 102
Quoted 4 lines
+&uart0 {
arch/arm/boot/dts/kirkwood-pogoplug-series-4.dts new file +3 -0
+     status = "okay";
+     current-speed = <115200>;
+};
You should not need this. There are no other DTS files with it.

git grep 'current-speed' arch/arm/boot/dts

arch/arm/boot/dts/k2l.dtsi:                     current-speed = <115200>;
arch/arm/boot/dts/k2l.dtsi:                     current-speed = <115200>;
arch/arm/boot/dts/keystone.dtsi:                        current-speed

= <115200>;
arch/arm/boot/dts/keystone.dtsi: current-speed
= <115200>;
arch/arm/boot/dts/omap-zoom-common.dtsi: current-speed
= <115200>;
arch/arm/boot/dts/omap-zoom-common.dtsi: current-speed
= <115200>;
arch/arm/boot/dts/omap-zoom-common.dtsi: current-speed
= <115200>;
arch/arm/boot/dts/omap-zoom-common.dtsi: current-speed
= <115200>;

Quoted 4 lines

As far
as i understand, the bootloader may add this to the DT blob before passing it to the kernel, but i doubt the stock bootloader on your device is doing it.

Sure I can drop it.

Yours,
Linus Walleij