Skip to contentSkip to conversation

clk: sunxi: signedness bug in sun8i_h3_bus_gates_init()

PATCH Applied Dan Carpenter 2 participants 2 messages Dec 12, 2015 – Dec 13, 2015

Subsystems (4)
Kernel janitors Common clk Arm/Allwinner sunXi SoC support Arm/Allwinner SoC Clock Support
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 clk: sunxi: signedness bug in sun8i_h3_bus_gates_init()

"index" needs to be signed for the error handling to work.

Fixes ab6e23a4e388 ('clk: sunxi: Add H3 clocks support')
Signed-off-by Dan Carpenter <[email protected]>
drivers/clk/sunxi/clk-sun8i-bus-gates.c +1 -1
index 7ab60c5..b8c7753 100644
@@ -40,7 +40,7 @@ static void __init sun8i_h3_bus_gates_init(struct device_node *node)
 	const __be32 *p;
 	int number, i;
 	u8 clk_bit;
-	u32 index;
+	int index;
 
 	reg = of_io_request_and_map(node, 0, of_node_full_name(node));
 	if (IS_ERR(reg))
Applied
#1 lore raw
Quoted 4 lines · Dan Carpenter

"index" needs to be signed for the error handling to work.

Fixes ab6e23a4e388 ('clk: sunxi: Add H3 clocks support')
Signed-off-by Dan Carpenter <[email protected]>

Applied, thanks!
Maxime

Signature · 3 lines
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com