Remove unused pisize parameter from dump_portinfo in ibdiag_common

PATCH Applied Hal Rosenstock 2 participants 2 messages Nov 10, 2015 – Dec 12, 2015 1 message not in the archive InfiniBand

lore

Share & tools

lore

Hal Rosenstock

author

2015-11-10 11:22 UTC #0 lore raw

PATCH 1/1 Remove unused pisize parameter from dump_portinfo in ibdiag_common

src/ibdiag_common.c: In function ?dump_portinfo?:
src/ibdiag_common.c:856: warning: unused parameter ?pisize?

Signed-off-by Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/[email protected]>

---

include/ibdiag_common.h +1 -1

index af5b3c4..21b0522 100644
@@ -150,7 +150,7 @@ int vsnprint_field(char *buf, size_t n, enum MAD_FIELDS f, int spacing,
 		   const char *format, va_list va_args);
 int snprint_field(char *buf, size_t n, enum MAD_FIELDS f, int spacing,
 		  const char *format, ...);
-void dump_portinfo(void *pi, int pisize, int tabs);
+void dump_portinfo(void *pi, int tabs);
 
 /**
  * Some common command line parsing

src/ibdiag_common.c +1 -1

index 5ec0167..3ebdbb9 100644
@@ -853,7 +853,7 @@ int snprint_field(char *buf, size_t n, enum MAD_FIELDS f, int spacing,
 	return ret;
 }
 
-void dump_portinfo(void *pi, int pisize, int tabs)
+void dump_portinfo(void *pi, int tabs)
 {
 	int field, i;
 	char val[64];

src/saquery.c +1 -1

index cc8d8dc..bd70b7b 100644
@@ -304,7 +304,7 @@ static void dump_one_portinfo_record(void *data, struct query_params *p)
 	       "\t\tOptions.................0x%x\n"
 	       "\tPortInfo dump:\n",
 	       cl_ntoh16(pir->lid), pir->port_num, pir->options);
-	dump_portinfo(pi, sizeof(*pi), 2);
+	dump_portinfo(pi, 2);
 }
 
 static void dump_one_mcmember_record(void *data, struct query_params *p)

src/smpquery.c +1 -1

index 187ef61..2bd7132 100644
@@ -161,7 +161,7 @@ static char *port_info(ib_portid_t * dest, char **argv, int argc)
 		return "port info query failed";
 
 	printf("# Port info: %s port %d\n", portid2str(dest), orig_portnum);
-	dump_portinfo(data, sizeof data, 0);
+	dump_portinfo(data, 0);
 	return 0;
 }

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): [email protected]

ira.weiny

Applied

2015-12-12 16:34 UTC #2 lore raw

Quoted 5 lines · Hal Rosenstock

src/ibdiag_common.c: In function ?dump_portinfo?:
src/ibdiag_common.c:856: warning: unused parameter ?pisize?
Signed-off-by Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/[email protected]>

Thanks applied,
Ira

Quoted 45 lines

---

include/ibdiag_common.h +1 -1

index af5b3c4..21b0522 100644
@@ -150,7 +150,7 @@ int vsnprint_field(char *buf, size_t n, enum MAD_FIELDS f, int spacing,
 		   const char *format, va_list va_args);
 int snprint_field(char *buf, size_t n, enum MAD_FIELDS f, int spacing,
 		  const char *format, ...);
-void dump_portinfo(void *pi, int pisize, int tabs);
+void dump_portinfo(void *pi, int tabs);
 
 /**
  * Some common command line parsing

src/ibdiag_common.c +1 -1

index 5ec0167..3ebdbb9 100644
@@ -853,7 +853,7 @@ int snprint_field(char *buf, size_t n, enum MAD_FIELDS f, int spacing,
 	return ret;
 }
 
-void dump_portinfo(void *pi, int pisize, int tabs)
+void dump_portinfo(void *pi, int tabs)
 {
 	int field, i;
 	char val[64];

src/saquery.c +1 -1

index cc8d8dc..bd70b7b 100644
@@ -304,7 +304,7 @@ static void dump_one_portinfo_record(void *data, struct query_params *p)
 	       "\t\tOptions.................0x%x\n"
 	       "\tPortInfo dump:\n",
 	       cl_ntoh16(pir->lid), pir->port_num, pir->options);
-	dump_portinfo(pi, sizeof(*pi), 2);
+	dump_portinfo(pi, 2);
 }
 
 static void dump_one_mcmember_record(void *data, struct query_params *p)

src/smpquery.c +0 -0

index 187ef61..2bd7132 100644

src/smpquery.c static char *port_info(ib_portid_t * dest, char **argv, int argc) · line 167

Quoted 8 lines

src/smpquery.c +1 -1

@@ -161,7 +161,7 @@ static char *port_info(ib_portid_t * dest, char **argv, int argc)
 		return "port info query failed";
 
 	printf("# Port info: %s port %d\n", portid2str(dest), orig_portnum);
-	dump_portinfo(data, sizeof data, 0);
+	dump_portinfo(data, 0);
 	return 0;
 }

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html