package/libhdhomerun: new package

PATCH Superseded Bernd Kuhls 2 participants 6 messages Dec 13, 2015

lore

Share & tools

lore

Bernd Kuhls

author

2015-12-13 10:58 UTC #0 lore raw

PATCH 1/1 package/libhdhomerun: new package

Needed for new kodi-pvr-hdhomerun package.

Signed-off-by Bernd Kuhls <[email protected]>

---
 package/Config.in                          |  1 +
 package/libhdhomerun/0001-dont-strip.patch | 18 ++++++++++++++++
 package/libhdhomerun/Config.in             | 12 +++++++++++
 package/libhdhomerun/libhdhomerun.hash     |  2 ++
 package/libhdhomerun/libhdhomerun.mk       | 33 ++++++++++++++++++++++++++++++
 5 files changed, 66 insertions(+)
 create mode 100644 package/libhdhomerun/0001-dont-strip.patch
 create mode 100644 package/libhdhomerun/Config.in
 create mode 100644 package/libhdhomerun/libhdhomerun.hash
 create mode 100644 package/libhdhomerun/libhdhomerun.mk

package/Config.in +1 -0

index fd9863a..dfb89c3 100644
@@ -982,6 +982,7 @@ menu "Multimedia"
 	source "package/libfslcodec/Config.in"
 	source "package/libfslparser/Config.in"
 	source "package/libfslvpuwrap/Config.in"
+	source "package/libhdhomerun/Config.in"
 	source "package/libmatroska/Config.in"
 	source "package/libmms/Config.in"
 	source "package/libmpeg2/Config.in"

package/libhdhomerun/0001-dont-strip.patch new file +18 -0

new file mode 100644
index 0000000..17a9ff4
@@ -0,0 +1,18 @@
+Disable strip in Makefile.
+
+Patch downloaded from Gentoo:
+https://gitweb.gentoo.org/repo/gentoo.git/tree/media-libs/libhdhomerun/files/dont-strip.patch
+
+Signed-off-by: Bernd Kuhls <[email protected]>
+
+diff -Nur libhdhomerun/Makefile libhdhomerun.fix/Makefile
+--- libhdhomerun/Makefile	2012-08-30 15:46:27.000000000 -0500
++++ libhdhomerun.fix/Makefile	2013-03-24 14:47:08.740937164 -0500
+@@ -42,7 +42,6 @@
+ 
+ hdhomerun_config$(BINEXT) : hdhomerun_config.c $(LIBSRCS)
+ 	$(CC) $(CFLAGS) $+ $(LDFLAGS) -o $@
+-	$(STRIP) $@
+ 
+ libhdhomerun$(LIBEXT) : $(LIBSRCS)
+ 	$(CC) $(CFLAGS) -fPIC -DDLL_EXPORT $(SHARED) $+ $(LDFLAGS) -o $@

package/libhdhomerun/Config.in new file +12 -0

new file mode 100644
index 0000000..a49527a
@@ -0,0 +1,12 @@
+config BR2_PACKAGE_LIBHDHOMERUN
+	bool "libhdhomerun"
+	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on !BR2_STATIC_LIBS
+	help
+	  HDHomeRun is a network-attached digital television tuner box,
+	  produced by the company SiliconDust USA, Inc.
+
+	  http://www.silicondust.com
+
+comment "libhdhomerun needs a toolchain w/ threads, dynamic library"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS

package/libhdhomerun/libhdhomerun.hash new file +2 -0

new file mode 100644
index 0000000..7897764
@@ -0,0 +1,2 @@
+# Locally computed
+sha256	907dfbd1eb82aebd8b09e7c00c21a02433e6baaacf4a4f99aa2511b1d5244baf	libhdhomerun_20150826.tgz

package/libhdhomerun/libhdhomerun.mk new file +33 -0

new file mode 100644
index 0000000..2dc3a99
@@ -0,0 +1,33 @@
+################################################################################
+#
+# libhdhomerun
+#
+################################################################################
+
+LIBHDHOMERUN_VERSION = 20150826
+LIBHDHOMERUN_SOURCE = libhdhomerun_$(LIBHDHOMERUN_VERSION).tgz
+LIBHDHOMERUN_SITE = http://download.silicondust.com/hdhomerun
+LIBHDHOMERUN_LICENSE = LGPLv2.1+
+LIBHDHOMERUN_LICENSE_FILES = lgpl.txt
+LIBHDHOMERUN_INSTALL_STAGING = YES
+
+define LIBHDHOMERUN_BUILD_CMDS
+	$(TARGET_CONFIGURE_OPTS) $(MAKE) \
+		CROSS_COMPILE="$(TARGET_CROSS)" -C $(@D)
+endef
+
+define LIBHDHOMERUN_INSTALL_STAGING_CMDS
+	$(INSTALL) -D -m 0755 $(@D)/libhdhomerun.so \
+		$(STAGING_DIR)/usr/lib/libhdhomerun.so
+	$(INSTALL) -D -m 0644 $(@D)/*.h \
+		$(STAGING_DIR)/usr/include/
+endef
+
+define LIBHDHOMERUN_INSTALL_TARGET_CMDS
+	$(INSTALL) -D -m 0755 $(@D)/hdhomerun_config \
+		$(TARGET_DIR)/usr/bin/hdhomerun_config
+	$(INSTALL) -D -m 0755 $(@D)/libhdhomerun.so \
+		$(TARGET_DIR)/usr/lib/libhdhomerun.so
+endef
+
+$(eval $(generic-package))

Signature · 1 line

2.6.2

Baruch Siach

2015-12-13 11:33 UTC #1 lore raw

PATCH 1/1 package/libhdhomerun: new package

Hi Bernd,

package/libhdhomerun/libhdhomerun.mk line 28

Quoted 10 lines · Bernd Kuhls

package/libhdhomerun/libhdhomerun.mk new file +10 -0

+define LIBHDHOMERUN_INSTALL_STAGING_CMDS
+	$(INSTALL) -D -m 0755 $(@D)/libhdhomerun.so \
+		$(STAGING_DIR)/usr/lib/libhdhomerun.so
+	$(INSTALL) -D -m 0644 $(@D)/*.h \
+		$(STAGING_DIR)/usr/include/
+endef
+
+define LIBHDHOMERUN_INSTALL_TARGET_CMDS
+	$(INSTALL) -D -m 0755 $(@D)/hdhomerun_config \
+		$(TARGET_DIR)/usr/bin/hdhomerun_config

Are you sure this is not for staging?

package/libhdhomerun/libhdhomerun.mk line 31

Quoted 3 lines

package/libhdhomerun/libhdhomerun.mk new file +3 -0
+	$(INSTALL) -D -m 0755 $(@D)/libhdhomerun.so \
+		$(TARGET_DIR)/usr/lib/libhdhomerun.so
+endef

baruch

Signature · 3 lines

     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

Bernd Kuhls

author

2015-12-13 11:47 UTC #2 lore raw

PATCH 1/1 package/libhdhomerun: new package

Hi Baruch,

Am Sun, 13 Dec 2015 13:33:42 +0200 schrieb Baruch Siach:

Quoted 5 lines

Hi Bernd,
Quoted 2 lines · Bernd Kuhls
+define LIBHDHOMERUN_INSTALL_STAGING_CMDS + $(INSTALL) -D -m 0755
$(@D)/libhdhomerun.so \ + $(STAGING_DIR)/usr/lib/

libhdhomerun.so +

Quoted 1 line

Quoted 1 line
$(INSTALL) -D -m 0644 $(@D)/*.h \ + $(STAGING_DIR)/usr/

include/

Quoted 6 lines

package/libhdhomerun/libhdhomerun.mk line 28
Quoted 4 lines
(quoted diff) +2 -0
+endef +
+define LIBHDHOMERUN_INSTALL_TARGET_CMDS +	$(INSTALL) -D -m 0755
$(@D)/hdhomerun_config \
package/libhdhomerun/libhdhomerun.mk new file +1 -0
+		$(TARGET_DIR)/usr/bin/hdhomerun_config
Are you sure this is not for staging?

yes, because it is not a script but a binary compiled for the target:

$ file /home/bernd/buildroot/br2_kodi16/output/target/usr/bin/
hdhomerun_config
/home/bernd/buildroot/br2_kodi16/output/target/usr/bin/hdhomerun_config: 
ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, 
interpreter /lib/ld64-uClibc.so.0, not stripped

I am not sure whether the file is really needed on the target or not but it is definitely not suited for staging.

Regards, Bernd

Baruch Siach

2015-12-13 12:03 UTC #3 lore raw

PATCH 1/1 package/libhdhomerun: new package

Hi Bernd,

Quoted 14 lines · Bernd Kuhls

Am Sun, 13 Dec 2015 13:33:42 +0200 schrieb Baruch Siach:
Quoted 3 lines · Bernd Kuhls
Quoted 2 lines
+define LIBHDHOMERUN_INSTALL_STAGING_CMDS + $(INSTALL) -D -m 0755
$(@D)/libhdhomerun.so \ + $(STAGING_DIR)/usr/lib/
libhdhomerun.so +
Quoted 1 line
Quoted 1 line
$(INSTALL) -D -m 0644 $(@D)/*.h \ + $(STAGING_DIR)/usr/
include/
Quoted 6 lines
package/libhdhomerun/libhdhomerun.mk line 28
Quoted 4 lines
(quoted diff) +2 -0
+endef +
+define LIBHDHOMERUN_INSTALL_TARGET_CMDS +	$(INSTALL) -D -m 0755
$(@D)/hdhomerun_config \
package/libhdhomerun/libhdhomerun.mk new file +1 -0
+		$(TARGET_DIR)/usr/bin/hdhomerun_config
Are you sure this is not for staging?

Quoted 7 lines

yes, because it is not a script but a binary compiled for the target:

$ file /home/bernd/buildroot/br2_kodi16/output/target/usr/bin/
hdhomerun_config
/home/bernd/buildroot/br2_kodi16/output/target/usr/bin/hdhomerun_config: 
ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, 
interpreter /lib/ld64-uClibc.so.0, not stripped

This most likely matches your host. Is that your target as well?

Quoted 2 lines

I am not sure whether the file is really needed on the target or not but it is definitely not suited for staging.

Agreed. But is this file really intended for target use? Most library *_config files are only useful during build. What is the purpose of hdhomerun_config?

baruch

Signature · 3 lines

     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

Bernd Kuhls

author

2015-12-13 13:43 UTC #4 lore raw

PATCH 1/1 package/libhdhomerun: new package

Hi Baruch,

Am Sun, 13 Dec 2015 14:03:53 +0200 schrieb Baruch Siach:

Quoted 12 lines

Hi Bernd,
Quoted 9 lines · Bernd Kuhls
Am Sun, 13 Dec 2015 13:33:42 +0200 schrieb Baruch Siach:
Quoted 2 lines
Are you sure this is not for staging?
yes, because it is not a script but a binary compiled for the target:
$ file /home/bernd/buildroot/br2_kodi16/output/target/usr/bin/
hdhomerun_config
/home/bernd/buildroot/br2_kodi16/output/target/usr/bin/

hdhomerun_config:

Quoted 4 lines

Quoted 2 lines
ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib/ld64-uClibc.so.0, not stripped
This most likely matches your host. Is that your target as well?

coincidentally yes, here is the arm version:

$ file /home/bernd/buildroot/br2_kodi16/output/target/usr/bin/
hdhomerun_config
/home/bernd/buildroot/br2_kodi16/output/target/usr/bin/hdhomerun_config: 
ELF 32-bit LSB executable, ARM, EABI5 version 1 (SYSV), dynamically 
linked, interpreter /lib/ld-uClibc.so.0, not stripped

Quoted 6 lines

Quoted 2 lines
I am not sure whether the file is really needed on the target or not but it is definitely not suited for staging.
Agreed. But is this file really intended for target use? Most library *_config files are only useful during build. What is the purpose of hdhomerun_config?

Honestly I do not know, so I sent v2 of my patch:
http://patchwork.ozlabs.org/patch/556182/
If someone misses hdhomerun_config a follow-up patch is needed ;)

Regards, Bernd

Baruch Siach

2015-12-13 18:59 UTC #5 lore raw

PATCH 1/1 package/libhdhomerun: new package

Hi Bernd,

Quoted 4 lines · Bernd Kuhls

Am Sun, 13 Dec 2015 14:03:53 +0200 schrieb Baruch Siach:
Quoted 3 lines
Agreed. But is this file really intended for target use? Most library *_config files are only useful during build. What is the purpose of hdhomerun_config?

Some digging shows that this is a configuration utility for the Silicon Dust HDHomeRun hardware. Debian ships it in a separate hdhomerun-config package.

Quoted 3 lines

Honestly I do not know, so I sent v2 of my patch:
http://patchwork.ozlabs.org/patch/556182/
If someone misses hdhomerun_config a follow-up patch is needed ;)

Fair enough.

baruch

Signature · 3 lines

     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -