Skip to contentSkip to conversation

package/read-edid: Needs c++

PATCH New Bernd Kuhls 2 participants 2 messages Dec 13, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/read-edid: Needs c++

Fixes
http://autobuild.buildroot.net/results/8c1/8c11e463b68121fe0331acf9f8a42a1d3fef40c7//
and others

---
 package/read-edid/Config.in | 4 ++++
 1 file changed, 4 insertions(+)
package/read-edid/Config.in +4 -0
index c830e17..6f39037 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_READ_EDID
 	bool "read-edid"
+	depends on BR2_INSTALL_LIBSTDCPP
 	help
 	  Read-edid is a pair of tools for reading the EDID from a
 	  monitor. It should work with most monitors made since 1996
@@ -11,3 +12,6 @@ config BR2_PACKAGE_READ_EDID
 	  XF86Config-compatible monitor section.
 
 	  http://polypux.org/projects/read-edid/
+
+comment "read-edid needs a toolchain w/ C++"
+	depends on !BR2_INSTALL_LIBSTDCPP
Signature · 1 line
2.6.2
#1 lore raw

PATCH 1/1 package/read-edid: Needs c++

Dear Bernd Kuhls,

Quoted 5 lines · Bernd Kuhls

Fixes
http://autobuild.buildroot.net/results/8c1/8c11e463b68121fe0331acf9f8a42a1d3fef40c7//
and others

This is not the proper fix: there is no C++ code in this package. The proper fix is to adjust CMakeLists.txt to remove the C++ check. This is done by doing:

project (read-edid C)

See https://cmake.org/cmake/help/v3.0/command/project.html for details, and especially: "Optionally you can specify which languages your project supports. Example languages are C, CXX (i.e. C++), Fortran, etc. By default C and CXX are enabled if no language options are given."

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com