Skip to contentSkip to conversation

package/libass: Fix fontconfig detection

PATCH New Bernd Kuhls 2 participants 2 messages Dec 13, 2015

lore
Share & tools
lore

Bernd Kuhls

author
#0 lore raw

PATCH 1/1 package/libass: Fix fontconfig detection

This patch is a combination of the approaches by Vicente and Yann discussed in http://patchwork.ozlabs.org/patch/553448/ to fix the configure bug due to fontconfig being disabled.

Fixes
http://autobuild.buildroot.net/results/923/923e8688ab6a294b51fa146cd2ed23db20fe7341/
and many others

Signed-off-by Bernd Kuhls <[email protected]>
---
 package/libass/libass.mk | 9 +++++++++
 1 file changed, 9 insertions(+)
package/libass/libass.mk +9 -0
index 83939e2..72770e2 100644
@@ -24,6 +24,15 @@ ifeq ($(BR2_i386)$(BR2_x86_64),y)
 LIBASS_DEPENDENCIES += host-yasm
 endif
 
+# libass uses the concept of a "system font provider", in the linux case
+# this is currently only fontconfig. If fontconfig is disabled we need
+# the following configure option to avoid a configure error. This option
+# can be appended in the future when other linux packages are taking care
+# of the role as "system font provider".
+ifneq ($(BR2_PACKAGE_FONTCONFIG),y)
+LIBASS_CONF_OPTS = --disable-require-system-font-provider
+endif
+
 ifeq ($(BR2_PACKAGE_FONTCONFIG),y)
 LIBASS_DEPENDENCIES += fontconfig
 LIBASS_CONF_OPTS += --enable-fontconfig
Signature · 1 line
2.6.2
#1 lore raw

PATCH 1/1 package/libass: Fix fontconfig detection

Bernd, all,

On 2015-12-13 17:57 +0100, Bernd Kuhls spake thusly:

Quoted 3 lines

This patch is a combination of the approaches by Vicente and Yann discussed in http://patchwork.ozlabs.org/patch/553448/ to fix the configure bug due to fontconfig being disabled.

Thanks for your patch! :-)

however, see my comments, below...

Quoted 15 lines

Fixes
http://autobuild.buildroot.net/results/923/923e8688ab6a294b51fa146cd2ed23db20fe7341/
and many others

Signed-off-by Bernd Kuhls <[email protected]>
---
 package/libass/libass.mk | 9 +++++++++
 1 file changed, 9 insertions(+)
package/libass/libass.mk +0 -0
index 83939e2..72770e2 100644
@@ -24,6 +24,15 @@ ifeq ($(BR2_i386)$(BR2_x86_64),y)
 LIBASS_DEPENDENCIES += host-yasm

package/libass/libass.mk ifeq ($(BR2_i386)$(BR2_x86_64),y) · line 34

Quoted 10 lines
package/libass/libass.mk +8 -0
 endif
 
+# libass uses the concept of a "system font provider", in the linux case
+# this is currently only fontconfig. If fontconfig is disabled we need
+# the following configure option to avoid a configure error. This option
+# can be appended in the future when other linux packages are taking care
+# of the role as "system font provider".
+ifneq ($(BR2_PACKAGE_FONTCONFIG),y)
+LIBASS_CONF_OPTS = --disable-require-system-font-provider
+endif

Again, I'm not too happy with this. We already have a fontconfig conditional block, below. So this code should go strainght in the else clause.

Then, when/if (and *only* then) libass gains support for another system font provider, we can think of changing it.

At worse, I'd prefer Vicente's solution.

Regards,
Yann E. MORIN.

Quoted 10 lines
package/libass/libass.mk +0 -0
 ifeq ($(BR2_PACKAGE_FONTCONFIG),y)
 LIBASS_DEPENDENCIES += fontconfig
 LIBASS_CONF_OPTS += --enable-fontconfig
Signature · 6 lines
2.6.2

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'