Skip to contentSkip to conversation

package/netsniff: fix missing depend on statements

PATCH New Samuel Martin 3 participants 4 messages Dec 13, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/netsniff: fix missing depend on statements

Add missing architecture dependencies inherited from liburcu.

Fixes:
http://autobuild.buildroot.org/results/0a9/0a90d7c8f523b90b8a4ca6312ab4835547590fb2/

---
 package/netsniff-ng/Config.in | 3 +++
 1 file changed, 3 insertions(+)
package/netsniff-ng/Config.in +3 -0
index 8c48f39..65b2a0f 100644
@@ -11,14 +11,17 @@ config BR2_PACKAGE_NETSNIFF_NG
 	depends on BR2_TOOLCHAIN_USES_GLIBC
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_58854 # liburcu
+	depends on BR2_arm || BR2_armeb || BR2_aarch64 || BR2_i386 || BR2_powerpc || BR2_x86_64 # liburcu
 	help
 	  netsniff-ng is a free, performant Linux network analyzer and
 	  networking toolkit. If you will, the Swiss army knife for
 	  network packets.
 
 comment "netsniff-ng needs an (e)glibc toolchain w/ threads"
+	depends on BR2_arm || BR2_armeb || BR2_aarch64 || BR2_i386 || BR2_powerpc || BR2_x86_64
 	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_USES_GLIBC
 	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_58854
 
 comment "netsniff-ng needs a toolchain not affected by GCC bug 58854"
+	depends on BR2_arm || BR2_armeb || BR2_aarch64 || BR2_i386 || BR2_powerpc || BR2_x86_64
 	depends on BR2_TOOLCHAIN_HAS_GCC_BUG_58854
Signature · 1 line
2.6.4
#1 lore raw

PATCH 1/1 package/netsniff: fix missing depend on statements

Samuel, All,

On 2015-12-13 17:19 +0100, Samuel Martin spake thusly:

Quoted 6 lines

Add missing architecture dependencies inherited from liburcu.

Fixes:
http://autobuild.buildroot.org/results/0a9/0a90d7c8f523b90b8a4ca6312ab4835547590fb2/

Regards,
Yann E. MORIN.

Quoted 33 lines
---
 package/netsniff-ng/Config.in | 3 +++
 1 file changed, 3 insertions(+)
package/netsniff-ng/Config.in +3 -0
index 8c48f39..65b2a0f 100644
@@ -11,14 +11,17 @@ config BR2_PACKAGE_NETSNIFF_NG
 	depends on BR2_TOOLCHAIN_USES_GLIBC
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_58854 # liburcu
+	depends on BR2_arm || BR2_armeb || BR2_aarch64 || BR2_i386 || BR2_powerpc || BR2_x86_64 # liburcu
 	help
 	  netsniff-ng is a free, performant Linux network analyzer and
 	  networking toolkit. If you will, the Swiss army knife for
 	  network packets.
 
 comment "netsniff-ng needs an (e)glibc toolchain w/ threads"
+	depends on BR2_arm || BR2_armeb || BR2_aarch64 || BR2_i386 || BR2_powerpc || BR2_x86_64
 	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_USES_GLIBC
 	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_58854
 
 comment "netsniff-ng needs a toolchain not affected by GCC bug 58854"
+	depends on BR2_arm || BR2_armeb || BR2_aarch64 || BR2_i386 || BR2_powerpc || BR2_x86_64
 	depends on BR2_TOOLCHAIN_HAS_GCC_BUG_58854
Signature · 6 lines
2.6.4

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 package/netsniff: fix missing depend on statements

In reply to Samuel Martin

Dear Samuel Martin,

Quoted 15 lines · Samuel Martin

Add missing architecture dependencies inherited from liburcu.

Fixes:
http://autobuild.buildroot.org/results/0a9/0a90d7c8f523b90b8a4ca6312ab4835547590fb2/

---
 package/netsniff-ng/Config.in | 3 +++
 1 file changed, 3 insertions(+)
package/netsniff-ng/Config.in +0 -0
index 8c48f39..65b2a0f 100644

package/netsniff-ng/Config.in config BR2_PACKAGE_NETSNIFF_NG · line 14

Quoted 4 lines
package/netsniff-ng/Config.in +1 -0
@@ -11,14 +11,17 @@ config BR2_PACKAGE_NETSNIFF_NG
 	depends on BR2_TOOLCHAIN_USES_GLIBC
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_58854 # liburcu
+	depends on BR2_arm || BR2_armeb || BR2_aarch64 || BR2_i386 || BR2_powerpc || BR2_x86_64 # liburcu

The list of architecture dependencies from liburcu is already duplicated in liburcu (two times), in lttng-libust (two times), lttng-tools (two times) and now in netsniff (three times).

Isn't it time to switch to BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS ?

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#3 lore raw

PATCH 1/1 package/netsniff: fix missing depend on statements

Quoted 27 lines · Thomas Petazzoni

Dear Samuel Martin,

Quoted 15 lines · Samuel Martin

Add missing architecture dependencies inherited from liburcu.

Fixes:
http://autobuild.buildroot.org/results/0a9/0a90d7c8f523b90b8a4ca6312ab4835547590fb2/

---
 package/netsniff-ng/Config.in | 3 +++
 1 file changed, 3 insertions(+)
package/netsniff-ng/Config.in +0 -0
index 8c48f39..65b2a0f 100644

package/netsniff-ng/Config.in config BR2_PACKAGE_NETSNIFF_NG · line 14

Quoted 4 lines
package/netsniff-ng/Config.in +1 -0
@@ -11,14 +11,17 @@ config BR2_PACKAGE_NETSNIFF_NG
      depends on BR2_TOOLCHAIN_USES_GLIBC
      depends on BR2_TOOLCHAIN_HAS_THREADS
      depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_58854 # liburcu
+     depends on BR2_arm || BR2_armeb || BR2_aarch64 || BR2_i386 || BR2_powerpc || BR2_x86_64 # liburcu

The list of architecture dependencies from liburcu is already duplicated in liburcu (two times), in lttng-libust (two times), lttng-tools (two times) and now in netsniff (three times).

Quoted 1 line

Isn't it time to switch to BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS ?

Certainly!
On it.

Quoted 8 lines

Thanks,

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Signature · 1 line
Samuel