package/liburcu: introduce BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS symbol

PATCH New Samuel Martin 3 participants 9 messages Dec 13, 2015

Share & tools

Samuel Martin

author

2015-12-13 18:47 UTC #0 lore raw

PATCH v2 1/4 package/liburcu: introduce BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS symbol

This new hidden symbol will allow simplifying the architecture dependencies on package that depends on liburcu. These packages will be updated in follow-up patches.

Signed-off-by Samuel Martin <[email protected]>

---
changes v1->v2:
- new patch

---
 package/liburcu/Config.in | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

package/liburcu/Config.in +7 -2

index a4e8dc8..36d5353 100644
@@ -1,6 +1,11 @@
+config BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS
+	bool
+	depends on BR2_arm || BR2_armeb || BR2_aarch64 || BR2_i386 || BR2_powerpc || BR2_x86_64
+	default y
+
 config BR2_PACKAGE_LIBURCU
 	bool "liburcu"
-	depends on BR2_arm || BR2_armeb || BR2_aarch64 || BR2_i386 || BR2_powerpc || BR2_x86_64
+	depends on BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS
 	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_58854 # liburcu/gcc-4.8.x bug
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	help

@@ -18,7 +23,7 @@ config BR2_PACKAGE_LIBURCU
 	  http://lttng.org/urcu
 
 comment "liburcu needs a toolchain w/ threads"
-	depends on BR2_arm || BR2_armeb || BR2_aarch64 || BR2_i386 || BR2_powerpc || BR2_x86_64
+	depends on BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS
 	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_58854 # liburcu/gcc-4.8.x bug
 	depends on !BR2_TOOLCHAIN_HAS_THREADS

Signature · 1 line

2.6.4

Samuel Martin

author

2015-12-13 18:47 UTC #1 lore raw

PATCH v2 2/4 package/lttng-libust: use BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS dependency

Using this newly introduced symbol lets to simplify the dependency code.

This change also adds the missing architecture dependencies on the second comment.

Signed-off-by Samuel Martin <[email protected]>

---
changes v1->v2:
- new patch

---
 package/lttng-libust/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

package/lttng-libust/Config.in +3 -2

index 3c26055..26838bb 100644
@@ -5,7 +5,7 @@ config BR2_PACKAGE_LTTNG_LIBUST
 	select BR2_PACKAGE_UTIL_LINUX_LIBUUID
 	depends on BR2_USE_WCHAR # util-linux
 	# liburcu only works on some architectures and requires threads support"
-	depends on BR2_arm || BR2_armeb || BR2_aarch64 || BR2_i386 || BR2_powerpc || BR2_x86_64
+	depends on BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS
 	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_58854 # liburcu/gcc-4.8.x bug
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on !BR2_STATIC_LIBS

@@ -18,9 +18,10 @@ config BR2_PACKAGE_LTTNG_LIBUST
 	  http://lttng.org
 
 comment "lttng-libust needs a toolchain w/ dynamic library, wchar, threads"
-	depends on BR2_arm || BR2_armeb || BR2_aarch64 || BR2_i386 || BR2_powerpc || BR2_x86_64
+	depends on BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS
 	depends on BR2_STATIC_LIBS || !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
 	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_58854 # liburcu/gcc-4.8.x bug
 
 comment "lttng-libust needs a toolchain not affected by GCC bug 58854"
+	depends on BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS
 	depends on BR2_TOOLCHAIN_HAS_GCC_BUG_58854

Signature · 1 line

2.6.4

Yann E. MORIN

2015-12-13 20:09 UTC #2 lore raw

PATCH v2 2/4 package/lttng-libust: use BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS dependency

Samuel, All,

On 2015-12-13 19:47 +0100, Samuel Martin spake thusly:

Quoted 6 lines

Using this newly introduced symbol lets to simplify the dependency code.
This change also adds the missing architecture dependencies on the second comment.
Signed-off-by Samuel Martin <[email protected]>

Reviewed-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 39 lines

---
changes v1->v2:
- new patch

---
 package/lttng-libust/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

package/lttng-libust/Config.in +3 -2

index 3c26055..26838bb 100644
@@ -5,7 +5,7 @@ config BR2_PACKAGE_LTTNG_LIBUST
 	select BR2_PACKAGE_UTIL_LINUX_LIBUUID
 	depends on BR2_USE_WCHAR # util-linux
 	# liburcu only works on some architectures and requires threads support"
-	depends on BR2_arm || BR2_armeb || BR2_aarch64 || BR2_i386 || BR2_powerpc || BR2_x86_64
+	depends on BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS
 	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_58854 # liburcu/gcc-4.8.x bug
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on !BR2_STATIC_LIBS

@@ -18,9 +18,10 @@ config BR2_PACKAGE_LTTNG_LIBUST
 	  http://lttng.org
 
 comment "lttng-libust needs a toolchain w/ dynamic library, wchar, threads"
-	depends on BR2_arm || BR2_armeb || BR2_aarch64 || BR2_i386 || BR2_powerpc || BR2_x86_64
+	depends on BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS
 	depends on BR2_STATIC_LIBS || !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
 	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_58854 # liburcu/gcc-4.8.x bug
 
 comment "lttng-libust needs a toolchain not affected by GCC bug 58854"
+	depends on BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS
 	depends on BR2_TOOLCHAIN_HAS_GCC_BUG_58854

Signature · 6 lines

2.6.4

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 6 lines

.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

Samuel Martin

author

2015-12-13 18:47 UTC #3 lore raw

PATCH v2 3/4 package/lttng-tools: use BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS dependency

In reply to Samuel Martin

Using this newly introduced symbol lets to simplify the dependency code.

This change also adds the missing architecture dependencies on the second comment.

Signed-off-by Samuel Martin <[email protected]>

---
changes v1-> v2:
- new patch

---
 package/lttng-tools/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

package/lttng-tools/Config.in +3 -2

index 4c5b5f6..599095d 100644
@@ -6,7 +6,7 @@ config BR2_PACKAGE_LTTNG_TOOLS
 	select BR2_PACKAGE_UTIL_LINUX
 	select BR2_PACKAGE_UTIL_LINUX_LIBUUID
 	# liburcu only works on some architectures and requires thread support
-	depends on BR2_arm || BR2_armeb || BR2_aarch64 || BR2_i386 || BR2_powerpc || BR2_x86_64
+	depends on BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS
 	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_58595 # lttng-tools/gcc-4.{7,8}.x bug
 	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_58854 # liburcu/gcc-4.8.x bug
 	depends on BR2_USE_WCHAR # util-linux

@@ -30,10 +30,11 @@ config BR2_PACKAGE_LTTNG_TOOLS
 	  http://lttng.org
 
 comment "lttng-tools needs a toolchain w/ threads, wchar"
-	depends on BR2_arm || BR2_armeb || BR2_aarch64 || BR2_i386 || BR2_powerpc || BR2_x86_64
+	depends on BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS
 	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR
 	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_58595 # lttng-tools/gcc-4.{7,8}.x bug
 	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_58854 # liburcu/gcc-4.8.x bug
 
 comment "lttng-tools needs a toolchain not affected by GCC bug 58854 and 58595"
+	depends on BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS
 	depends on BR2_TOOLCHAIN_HAS_GCC_BUG_58854 || BR2_TOOLCHAIN_HAS_GCC_BUG_58595

Signature · 1 line

2.6.4

Yann E. MORIN

2015-12-13 20:15 UTC #4 lore raw

PATCH v2 3/4 package/lttng-tools: use BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS dependency

Samuel, All,

On 2015-12-13 19:47 +0100, Samuel Martin spake thusly:

Quoted 6 lines

Using this newly introduced symbol lets to simplify the dependency code.
This change also adds the missing architecture dependencies on the second comment.
Signed-off-by Samuel Martin <[email protected]>

Reviewed-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 40 lines

---
changes v1-> v2:
- new patch

---
 package/lttng-tools/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

package/lttng-tools/Config.in +3 -2

index 4c5b5f6..599095d 100644
@@ -6,7 +6,7 @@ config BR2_PACKAGE_LTTNG_TOOLS
 	select BR2_PACKAGE_UTIL_LINUX
 	select BR2_PACKAGE_UTIL_LINUX_LIBUUID
 	# liburcu only works on some architectures and requires thread support
-	depends on BR2_arm || BR2_armeb || BR2_aarch64 || BR2_i386 || BR2_powerpc || BR2_x86_64
+	depends on BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS
 	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_58595 # lttng-tools/gcc-4.{7,8}.x bug
 	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_58854 # liburcu/gcc-4.8.x bug
 	depends on BR2_USE_WCHAR # util-linux

@@ -30,10 +30,11 @@ config BR2_PACKAGE_LTTNG_TOOLS
 	  http://lttng.org
 
 comment "lttng-tools needs a toolchain w/ threads, wchar"
-	depends on BR2_arm || BR2_armeb || BR2_aarch64 || BR2_i386 || BR2_powerpc || BR2_x86_64
+	depends on BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS
 	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR
 	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_58595 # lttng-tools/gcc-4.{7,8}.x bug
 	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_58854 # liburcu/gcc-4.8.x bug
 
 comment "lttng-tools needs a toolchain not affected by GCC bug 58854 and 58595"
+	depends on BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS
 	depends on BR2_TOOLCHAIN_HAS_GCC_BUG_58854 || BR2_TOOLCHAIN_HAS_GCC_BUG_58595

Signature · 6 lines

2.6.4

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 6 lines

.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

Samuel Martin

author

2015-12-13 18:47 UTC #5 lore raw

PATCH v2 4/4 package/netsniff: fix missing depend on statements

In reply to Samuel Martin

Add missing architecture dependencies inherited from liburcu.

Fixes:
http://autobuild.buildroot.org/results/0a9/0a90d7c8f523b90b8a4ca6312ab4835547590fb2/

Signed-off-by Samuel Martin <[email protected]>

---
changes v1->v2:
- use BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS (ThomasP)

---
 package/netsniff-ng/Config.in | 3 +++
 1 file changed, 3 insertions(+)

package/netsniff-ng/Config.in +3 -0

index 8c48f39..b39ec96 100644
@@ -11,14 +11,17 @@ config BR2_PACKAGE_NETSNIFF_NG
 	depends on BR2_TOOLCHAIN_USES_GLIBC
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_58854 # liburcu
+	depends on BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS
 	help
 	  netsniff-ng is a free, performant Linux network analyzer and
 	  networking toolkit. If you will, the Swiss army knife for
 	  network packets.
 
 comment "netsniff-ng needs an (e)glibc toolchain w/ threads"
+	depends on BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS
 	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_USES_GLIBC
 	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_58854
 
 comment "netsniff-ng needs a toolchain not affected by GCC bug 58854"
+	depends on BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS
 	depends on BR2_TOOLCHAIN_HAS_GCC_BUG_58854

Signature · 1 line

2.6.4

Yann E. MORIN

2015-12-13 20:16 UTC #6 lore raw

PATCH v2 4/4 package/netsniff: fix missing depend on statements

Samuel, All,

On 2015-12-13 19:47 +0100, Samuel Martin spake thusly:

Quoted 6 lines

Add missing architecture dependencies inherited from liburcu.
Fixes:
http://autobuild.buildroot.org/results/0a9/0a90d7c8f523b90b8a4ca6312ab4835547590fb2/
Signed-off-by Samuel Martin <[email protected]>

Reviewed-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 36 lines

---
changes v1->v2:
- use BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS (ThomasP)

---
 package/netsniff-ng/Config.in | 3 +++
 1 file changed, 3 insertions(+)

package/netsniff-ng/Config.in +3 -0

index 8c48f39..b39ec96 100644
@@ -11,14 +11,17 @@ config BR2_PACKAGE_NETSNIFF_NG
 	depends on BR2_TOOLCHAIN_USES_GLIBC
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_58854 # liburcu
+	depends on BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS
 	help
 	  netsniff-ng is a free, performant Linux network analyzer and
 	  networking toolkit. If you will, the Swiss army knife for
 	  network packets.
 
 comment "netsniff-ng needs an (e)glibc toolchain w/ threads"
+	depends on BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS
 	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_USES_GLIBC
 	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_58854
 
 comment "netsniff-ng needs a toolchain not affected by GCC bug 58854"
+	depends on BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS
 	depends on BR2_TOOLCHAIN_HAS_GCC_BUG_58854

Signature · 6 lines

2.6.4

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 6 lines

.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

Yann E. MORIN

2015-12-13 20:05 UTC #7 lore raw

PATCH v2 1/4 package/liburcu: introduce BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS symbol

In reply to Samuel Martin

Samuel, All,

On 2015-12-13 19:47 +0100, Samuel Martin spake thusly:

Quoted 5 lines

This new hidden symbol will allow simplifying the architecture dependencies on package that depends on liburcu. These packages will be updated in follow-up patches.
Signed-off-by Samuel Martin <[email protected]>

Reviewed-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 40 lines

---
changes v1->v2:
- new patch

---
 package/liburcu/Config.in | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

package/liburcu/Config.in +7 -2

index a4e8dc8..36d5353 100644
@@ -1,6 +1,11 @@
+config BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS
+	bool
+	depends on BR2_arm || BR2_armeb || BR2_aarch64 || BR2_i386 || BR2_powerpc || BR2_x86_64
+	default y
+
 config BR2_PACKAGE_LIBURCU
 	bool "liburcu"
-	depends on BR2_arm || BR2_armeb || BR2_aarch64 || BR2_i386 || BR2_powerpc || BR2_x86_64
+	depends on BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS
 	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_58854 # liburcu/gcc-4.8.x bug
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	help

@@ -18,7 +23,7 @@ config BR2_PACKAGE_LIBURCU
 	  http://lttng.org/urcu
 
 comment "liburcu needs a toolchain w/ threads"
-	depends on BR2_arm || BR2_armeb || BR2_aarch64 || BR2_i386 || BR2_powerpc || BR2_x86_64
+	depends on BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS
 	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_58854 # liburcu/gcc-4.8.x bug
 	depends on !BR2_TOOLCHAIN_HAS_THREADS

Signature · 6 lines

2.6.4

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 6 lines

.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

Thomas Petazzoni

2015-12-13 21:37 UTC #8 lore raw

PATCH v2 1/4 package/liburcu: introduce BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS symbol

In reply to Samuel Martin

Dear Samuel Martin,

Quoted 4 lines · Samuel Martin

This new hidden symbol will allow simplifying the architecture dependencies on package that depends on liburcu. These packages will be updated in follow-up patches.

Quoted 8 lines

Signed-off-by Samuel Martin <[email protected]>
---
changes v1->v2:
- new patch
---
 package/liburcu/Config.in | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

All four patches applied, thanks!

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com