Skip to contentSkip to conversation

package/mplayer: Needs threads

PATCH New Bernd Kuhls 3 participants 3 messages Dec 13, 2015

lore
Share & tools
lore

Bernd Kuhls

author
#0 lore raw

PATCH 1/1 package/mplayer: Needs threads

Fixes
http://autobuild.buildroot.net/results/fc0/fc02e01514965e13ee1de8f520a5b45f63a1103e/
http://autobuild.buildroot.net/results/b9c/b9cb712b321de4528d1a8dfb9bdfb16190bb660a/
http://autobuild.buildroot.net/results/22a/22aa0367ff76a3024faec69c762a08a4a441f45f/
and others

Signed-off-by Bernd Kuhls <[email protected]>
---
 package/mplayer/Config.in | 5 +++++
 1 file changed, 5 insertions(+)
package/mplayer/Config.in +5 -0
index 7a8b03f..686b3b0 100644
@@ -10,12 +10,17 @@ config BR2_PACKAGE_MPLAYER_ARCH_SUPPORTS
 config BR2_PACKAGE_MPLAYER
 	bool "mplayer"
 	depends on BR2_PACKAGE_MPLAYER_ARCH_SUPPORTS
+	depends on BR2_TOOLCHAIN_HAS_THREADS
 	help
 	  MPlayer is a movie player which runs on many systems and supports
 	  many different file formats.
 
 	  http://www.mplayerhq.hu/
 
+comment "mplayer needs a toolchain w/ threads"
+	depends on BR2_PACKAGE_MPLAYER_ARCH_SUPPORTS
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
+
 if BR2_PACKAGE_MPLAYER
 
 config BR2_PACKAGE_MPLAYER_MPLAYER
Signature · 1 line
2.6.2
#1 lore raw

PATCH 1/1 package/mplayer: Needs threads

Bernd, all,

On 2015-12-13 19:34 +0100, Bernd Kuhls spake thusly:

Quoted 16 lines

Fixes
http://autobuild.buildroot.net/results/fc0/fc02e01514965e13ee1de8f520a5b45f63a1103e/
http://autobuild.buildroot.net/results/b9c/b9cb712b321de4528d1a8dfb9bdfb16190bb660a/
http://autobuild.buildroot.net/results/22a/22aa0367ff76a3024faec69c762a08a4a441f45f/
and others

Signed-off-by Bernd Kuhls <[email protected]>
---
 package/mplayer/Config.in | 5 +++++
 1 file changed, 5 insertions(+)
package/mplayer/Config.in +0 -0
index 7a8b03f..686b3b0 100644

package/mplayer/Config.in config BR2_PACKAGE_MPLAYER_ARCH_SUPPORTS · line 13

Quoted 4 lines
package/mplayer/Config.in +1 -0
@@ -10,12 +10,17 @@ config BR2_PACKAGE_MPLAYER_ARCH_SUPPORTS
 config BR2_PACKAGE_MPLAYER
 	bool "mplayer"
 	depends on BR2_PACKAGE_MPLAYER_ARCH_SUPPORTS
+	depends on BR2_TOOLCHAIN_HAS_THREADS

There's an option to disable threads in mplayer, but I think it odes not make much sense to do so, so your patch is fine with me.

Reviewed-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 20 lines
package/mplayer/Config.in +4 -0
 	help
 	  MPlayer is a movie player which runs on many systems and supports
 	  many different file formats.
 
 	  http://www.mplayerhq.hu/
 
+comment "mplayer needs a toolchain w/ threads"
+	depends on BR2_PACKAGE_MPLAYER_ARCH_SUPPORTS
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
+
 if BR2_PACKAGE_MPLAYER
 
 config BR2_PACKAGE_MPLAYER_MPLAYER
Signature · 6 lines
2.6.2

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 package/mplayer: Needs threads

In reply to Bernd Kuhls

Dear Bernd Kuhls,

Quoted 10 lines · Bernd Kuhls

Fixes
http://autobuild.buildroot.net/results/fc0/fc02e01514965e13ee1de8f520a5b45f63a1103e/
http://autobuild.buildroot.net/results/b9c/b9cb712b321de4528d1a8dfb9bdfb16190bb660a/
http://autobuild.buildroot.net/results/22a/22aa0367ff76a3024faec69c762a08a4a441f45f/
and others

Signed-off-by Bernd Kuhls <[email protected]>
---
 package/mplayer/Config.in | 5 +++++
 1 file changed, 5 insertions(+)

I agree with Yann, we could disable thread support in Mplayer, but who wants a big thing like Mplayer on a non-threaded system anyway?

So: applied. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com