Skip to contentSkip to conversation

crypto: omap-aes,omap-des: Removed unused variable "err"

PATCH In review Pathak, Rahul (R.) 1 participant 1 message Dec 14, 2015 Crypto API

lore
Share & tools
lore

Pathak, Rahul (R.)

author
#0 lore raw

PATCH 2/2 crypto: omap-aes,omap-des: Removed unused variable "err"

From: Rahul Pathak <[email protected]>

Removed unused variable "err" and directly return "0"

Reported by coccicheck -
./drivers/crypto/omap-aes.c:542:5-8: Unneeded variable: "err". Return "0" on line 551 ./drivers/crypto/omap-des.c:530:5-8: Unneeded variable: "err". Return "0" on line 539

Signed-off-by Rahul Pathak <[email protected]>
---
 drivers/crypto/omap-aes.c | 4 +---
 drivers/crypto/omap-des.c | 4 +---
 2 files changed, 2 insertions(+), 6 deletions(-)
drivers/crypto/omap-aes.c +1 -3
index eba2314..dd355bd 100644
@@ -539,8 +539,6 @@ static void omap_aes_finish_req(struct omap_aes_dev *dd, int err)
 
 static int omap_aes_crypt_dma_stop(struct omap_aes_dev *dd)
 {
-	int err = 0;
-
 	pr_debug("total: %d\n", dd->total);
 
 	omap_aes_dma_stop(dd);

@@ -548,7 +546,7 @@ static int omap_aes_crypt_dma_stop(struct omap_aes_dev *dd)
 	dmaengine_terminate_all(dd->dma_lch_in);
 	dmaengine_terminate_all(dd->dma_lch_out);
 
-	return err;
+	return 0;
 }
 
 static int omap_aes_check_aligned(struct scatterlist *sg, int total)
drivers/crypto/omap-des.c +1 -3
index 0a70e46..a95ee4f 100644
@@ -527,8 +527,6 @@ static void omap_des_finish_req(struct omap_des_dev *dd, int err)
 
 static int omap_des_crypt_dma_stop(struct omap_des_dev *dd)
 {
-	int err = 0;
-
 	pr_debug("total: %d\n", dd->total);
 
 	omap_des_dma_stop(dd);

@@ -536,7 +534,7 @@ static int omap_des_crypt_dma_stop(struct omap_des_dev *dd)
 	dmaengine_terminate_all(dd->dma_lch_in);
 	dmaengine_terminate_all(dd->dma_lch_out);
 
-	return err;
+	return 0;
 }
 
 static int omap_des_copy_needed(struct scatterlist *sg)
Signature · 1 line
1.9.1