misc/bmp085: Enable building as a module
PATCH RESEND 1/1 misc/bmp085: Enable building as a module
Commit 985087dbcb02 'misc: add support for bmp18x chips to the bmp085 driver' changed the BMP085 config symbol to a boolean. I see no reason why the shared code cannot be built as a module, so change it back to tristate.
Fixes 985087dbcb02 ("misc: add support for bmp18x chips to the bmp085 driver")
Cc Eric Andersson <[email protected]>
Signed-off-by Ben Hutchings <[email protected]>
--- drivers/misc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/misc/Kconfig +1 -1
@@ -439,7 +439,7 @@ config ARM_CHARLCD still useful. config BMP085 - bool + tristate depends on SYSFS config BMP085_I2C
Quoted 9 lines · On Monday 14 December 2015 14:29:23 Ben Hutchings wrote:
Commit
985087dbcb02'misc: add support for bmp18x chips to the bmp085 driver' changed the BMP085 config symbol to a boolean. I see no reason why the shared code cannot be built as a module, so change it back to tristate.Fixes 985087dbcb02 ("misc: add support for bmp18x chips to the bmp085 driver")Cc Eric Andersson <[email protected]>Signed-off-by Ben Hutchings <[email protected]>
Looks good to me. There are often subtle bugs in configurations like these where a driver can depend on either SPI or I2C, but I don't see a problem here, because the common code still only gets built as a module if neither front-end is built-in.
Acked-by Arnd Bergmann <[email protected]>