xen: building with perfc=y was broken
PATCH 1/1 xen: building with perfc=y was broken
because of b38d426ad09 ("x86/viridian: flush remote tlbs by hypercall") which was defining mshv_call_flush, but using mshv_flush.
--- xen/arch/x86/hvm/viridian.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
xen/arch/x86/hvm/viridian.c +1 -1
@@ -607,7 +607,7 @@ int viridian_hypercall(struct cpu_user_regs *regs)* See Microsoft Hypervisor Top Level Spec. sections 12.4.2 * and 12.4.3. */ -perfc_incr (mshv_flush); +perfc_incr (mshv_call_flush);/* These hypercalls should never use the fast-call convention. */ status =HV_STATUS_INVALID_PARAMETER ;
Quoted 8 lines · Dario Faggioli
because of
b38d426ad09("x86/viridian: flush remote tlbs by hypercall") which was definingmshv_call_flush, but usingmshv_flush.Signed-off-by Dario Faggioli <[email protected]>Cc Jan Beulich <[email protected]>Cc Andrew Cooper <[email protected]>Cc Paul Durrant <[email protected]>
FYI, when the Kconfig series lands, I plan to port the Linux IS_ENABLED() infrastructure to Xen, which will allow bugs like this to be caught by the compiler even when the option is disabled.
~Andrew
Quoted 10 lines
-----Original Message-----
From: Dario Faggioli [mailto:[email protected]] On Behalf Of Dario Faggioli
Sent: 14 December 2015 17:45
To: [email protected]
Cc: Andrew Cooper; Paul Durrant; Jan Beulich
Subject: [PATCH] xen: building with perfc=y was brokenbecause of
b38d426ad09("x86/viridian: flush remote tlbs by hypercall") which was definingmshv_call_flush, but usingmshv_flush.
Oops. Sorry about that.
Quoted 5 lines
Signed-off-by Dario Faggioli <[email protected]>Cc Jan Beulich <[email protected]>Cc Andrew Cooper <[email protected]>Cc Paul Durrant <[email protected]>
Quoted 17 lines
--- xen/arch/x86/hvm/viridian.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)xen/arch/x86/hvm/viridian.c +1
-1@@ -607,7 +607,7 @@ int viridian_hypercall(struct cpu_user_regs *regs)* See Microsoft Hypervisor Top Level Spec. sections 12.4.2 * and 12.4.3. */ -perfc_incr (mshv_flush); +perfc_incr (mshv_call_flush);/* These hypercalls should never use the fast-call convention. */ status =HV_STATUS_INVALID_PARAMETER ;