Skip to contentSkip to conversation

gnutls: needs argp-standalone for musl/uclibc

PATCH New Gustavo Zacarias 3 participants 6 messages Dec 4, 2015 – Dec 14, 2015

lore
Share & tools
lore

Gustavo Zacarias

author
#0 lore raw

PATCH 1/1 gnutls: needs argp-standalone for musl/uclibc

It's required for crywrap (tools), fixes:
http://autobuild.buildroot.net/results/2d9/2d98fced7ff7c3b5c39a97eb1c8db7dd651fa86c/

Signed-off-by Gustavo Zacarias <[email protected]>
---
 package/gnutls/Config.in | 2 ++
 package/gnutls/gnutls.mk | 6 ++++++
 2 files changed, 8 insertions(+)
package/gnutls/Config.in +2 -0
index dde23ce..998e213 100644
@@ -14,6 +14,8 @@ if BR2_PACKAGE_GNUTLS
 
 config BR2_PACKAGE_GNUTLS_TOOLS
 	bool "install tools"
+	select BR2_PACKAGE_ARGP_STANDALONE \
+		if BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_MUSL
 	help
 	  Install GnuTLS command line tools for various cryptographic tasks.
package/gnutls/gnutls.mk +6 -0
index 3b9fc7f..a7342d6 100644
@@ -44,6 +44,12 @@ ifeq ($(BR2_PACKAGE_GNUTLS_TOOLS),)
 GNUTLS_CONF_OPTS += --disable-crywrap
 endif
 
+# Prerequisite for crywrap
+ifeq ($(BR2_PACKAGE_ARGP_STANDALONE),y)
+GNUTLS_CONF_ENV += LIBS="-largp"
+GNUTLS_DEPENDENCIES += argp-standalone
+endif
+
 # libidn support for nommu must exclude the crywrap wrapper (uses fork)
 GNUTLS_CONF_OPTS += $(if $(BR2_USE_MMU),,--disable-crywrap)
Signature · 1 line
2.4.10
#2 lore raw

PATCH 1/1 gnutls: needs argp-standalone for musl/uclibc

In reply to Gustavo Zacarias

Gustavo,

package/gnutls/Config.in if BR2_PACKAGE_GNUTLS · line 20

Quoted 12 lines · Gustavo Zacarias
package/gnutls/Config.in +2 -0
index dde23ce..998e213 100644
@@ -14,6 +14,8 @@ if BR2_PACKAGE_GNUTLS
 
 config BR2_PACKAGE_GNUTLS_TOOLS
 	bool "install tools"
+	select BR2_PACKAGE_ARGP_STANDALONE \
+		if BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_MUSL
 	help
 	  Install GnuTLS command line tools for various cryptographic tasks.

Seems like BR2_PACKAGE_GNUTLS needs argp.h as well, not only BR2_PACKAGE_GNUTLS_TOOLS. See
http://autobuild.buildroot.org/results/d86/d8604fe448bb11395e8443726d09b041eb34c6d5//.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#3 lore raw

PATCH 1/1 gnutls: needs argp-standalone for musl/uclibc

Quoted 10 lines · Thomas Petazzoni

package/gnutls/Config.in if BR2_PACKAGE_GNUTLS · line 20

Quoted 6 lines

config BR2_PACKAGE_GNUTLS_TOOLS
bool "install tools"

package/gnutls/Config.in +2 -0
+	select BR2_PACKAGE_ARGP_STANDALONE \
+		if BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_MUSL
  	help
  	  Install GnuTLS command line tools for various cryptographic tasks.

Seems like BR2_PACKAGE_GNUTLS needs argp.h as well, not only BR2_PACKAGE_GNUTLS_TOOLS. See
http://autobuild.buildroot.org/results/d86/d8604fe448bb11395e8443726d09b041eb34c6d5//.

Hi.
It's still crywrap failing, hence tools.
Probably --disable-crywrap isn't doing it's job efficently, i'll take a look.
Regards.

#4 lore raw

PATCH 1/1 gnutls: needs argp-standalone for musl/uclibc

Dear Gustavo Zacarias,

Quoted 13 lines · Gustavo Zacarias
Quoted 10 lines · Thomas Petazzoni

package/gnutls/Config.in if BR2_PACKAGE_GNUTLS · line 20

Quoted 6 lines

config BR2_PACKAGE_GNUTLS_TOOLS
bool "install tools"

package/gnutls/Config.in +2 -0
+	select BR2_PACKAGE_ARGP_STANDALONE \
+		if BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_MUSL
  	help
  	  Install GnuTLS command line tools for various cryptographic tasks.

Seems like BR2_PACKAGE_GNUTLS needs argp.h as well, not only BR2_PACKAGE_GNUTLS_TOOLS. See
http://autobuild.buildroot.org/results/d86/d8604fe448bb11395e8443726d09b041eb34c6d5//.

Quoted 2 lines

Hi.
It's still crywrap failing, hence tools.

Well the failing config I'm pointing to has BR2_PACKAGE_GNUTLS_TOOLS disabled, but BR2_PACKAGE_GNUTLS enabled.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#5 lore raw

PATCH 1/1 gnutls: needs argp-standalone for musl/uclibc

Quoted 7 lines · Thomas Petazzoni
Quoted 2 lines

Hi.
It's still crywrap failing, hence tools.

Well the failing config I'm pointing to has BR2_PACKAGE_GNUTLS_TOOLS disabled, but BR2_PACKAGE_GNUTLS enabled.

Thomas

crywrap isn't part of tools in the gnutls sense, it's only so in the buildroot package sense/option.
Essentially --disable-crywrap is a no-op in gnutls, that's what the patch fixes, so it was never disabled.
Regards.