Skip to contentSkip to conversation

ARM: dts: Add compatible property to "partitions" node

PATCH Superseded Geert Uytterhoeven 3 participants 13 messages Dec 14, 2015 – Dec 15, 2015

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

cover ARM: dts: Add compatible property to "partitions" node

	Hi,

As of commit e488ca9f8d4f62c2 ("doc: dt: mtd: partitions: add compatible property to "partitions" node"), the "partitions" subnode of an SPI FLASH device node must have a compatible property. The partitions are no longer detected if it is not present.

I marked this series as "RFC", as the abovementioned commit is not yet upstream. Ideally, the users should be fixed first, to avoid breakage.

Tested on r8a7791/koelsch.

Thanks!

Geert Uytterhoeven (7):
ARM: dt: mvebu: ix4-300d: Add compatible property to "partitions" node
ARM: shmobile: bockw dts: Add compatible property to "partitions" node
ARM: shmobile: lager dts: Add compatible property to "partitions" node
ARM: shmobile: koelsch dts: Add compatible property to "partitions"
node
ARM: shmobile: porter dts: Add compatible property to "partitions"
node
ARM: shmobile: gose dts: Add compatible property to "partitions" node
ARM: shmobile: silk dts: Add compatible property to "partitions" node

 arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts | 1 +
 arch/arm/boot/dts/r8a7778-bockw.dts             | 1 +
 arch/arm/boot/dts/r8a7790-lager.dts             | 1 +
 arch/arm/boot/dts/r8a7791-koelsch.dts           | 1 +
 arch/arm/boot/dts/r8a7791-porter.dts            | 1 +
 arch/arm/boot/dts/r8a7793-gose.dts              | 1 +
 arch/arm/boot/dts/r8a7794-silk.dts              | 1 +
 7 files changed, 7 insertions(+)
Signature · 12 lines
1.9.1

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
#1 lore raw

PATCH 1/7 ARM: dt: mvebu: ix4-300d: Add compatible property to "partitions" node

As of commit e488ca9f8d4f62c2 ("doc: dt: mtd: partitions: add compatible property to "partitions" node"), the "partitions" subnode of an SPI FLASH device node must have a compatible property. The partitions are no longer detected if it is not present.

---
The abovementioned commit is destined for v4.4.

---
 arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts | 1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts +1 -0
index 13cf69a8d0fb392b..fb9e1bbf23385b85 100644
@@ -152,6 +152,7 @@
 				nand-on-flash-bbt;
 
 				partitions {
+					compatible = "fixed-partitions";
 					#address-cells = <1>;
 					#size-cells = <1>;
 
Signature · 1 line
1.9.1
#2 lore raw

PATCH 2/7 ARM: shmobile: bockw dts: Add compatible property to "partitions" node

In reply to Geert Uytterhoeven

As of commit e488ca9f8d4f62c2 ("doc: dt: mtd: partitions: add compatible property to "partitions" node"), the "partitions" subnode of an SPI FLASH device node must have a compatible property. The partitions are no longer detected if it is not present.

---
The abovementioned commit is destined for v4.4.

---
 arch/arm/boot/dts/r8a7778-bockw.dts | 1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/r8a7778-bockw.dts +1 -0
index 482228b8a984656e..06ceefe3cb500dc7 100644
@@ -212,6 +212,7 @@
 		m25p,fast-read;
 
 		partitions {
+			compatible = "fixed-partitions";
 			#address-cells = <1>;
 			#size-cells = <1>;
 
Signature · 1 line
1.9.1
#3 lore raw

PATCH 3/7 ARM: shmobile: lager dts: Add compatible property to "partitions" node

In reply to Geert Uytterhoeven

As of commit e488ca9f8d4f62c2 ("doc: dt: mtd: partitions: add compatible property to "partitions" node"), the "partitions" subnode of an SPI FLASH device node must have a compatible property. The partitions are no longer detected if it is not present.

---
The abovementioned commit is destined for v4.4.

---
 arch/arm/boot/dts/r8a7790-lager.dts | 1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/r8a7790-lager.dts +1 -0
index 7773cb1f10317d85..cdc0414f5f0716dd 100644
@@ -457,6 +457,7 @@
 		m25p,fast-read;
 
 		partitions {
+			compatible = "fixed-partitions";
 			#address-cells = <1>;
 			#size-cells = <1>;
 
Signature · 1 line
1.9.1
#4 lore raw

PATCH 4/7 ARM: shmobile: koelsch dts: Add compatible property to "partitions" node

In reply to Geert Uytterhoeven

As of commit e488ca9f8d4f62c2 ("doc: dt: mtd: partitions: add compatible property to "partitions" node"), the "partitions" subnode of an SPI FLASH device node must have a compatible property. The partitions are no longer detected if it is not present.

---
The abovementioned commit is destined for v4.4.

---
 arch/arm/boot/dts/r8a7791-koelsch.dts | 1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/r8a7791-koelsch.dts +1 -0
index f8024c0d1114c607..0ad71b81d3a25f59 100644
@@ -502,6 +502,7 @@
 		m25p,fast-read;
 
 		partitions {
+			compatible = "fixed-partitions";
 			#address-cells = <1>;
 			#size-cells = <1>;
 
Signature · 1 line
1.9.1
#5 lore raw

PATCH 5/7 ARM: shmobile: porter dts: Add compatible property to "partitions" node

In reply to Geert Uytterhoeven

As of commit e488ca9f8d4f62c2 ("doc: dt: mtd: partitions: add compatible property to "partitions" node"), the "partitions" subnode of an SPI FLASH device node must have a compatible property. The partitions are no longer detected if it is not present.

---
The abovementioned commit is destined for v4.4.

---
 arch/arm/boot/dts/r8a7791-porter.dts | 1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/r8a7791-porter.dts +1 -0
index b93016896378c350..f8d8e2e2169a9c40 100644
@@ -213,6 +213,7 @@
 		m25p,fast-read;
 
 		partitions {
+			compatible = "fixed-partitions";
 			#address-cells = <1>;
 			#size-cells = <1>;
 
Signature · 1 line
1.9.1
#6 lore raw

PATCH 6/7 ARM: shmobile: gose dts: Add compatible property to "partitions" node

In reply to Geert Uytterhoeven

As of commit e488ca9f8d4f62c2 ("doc: dt: mtd: partitions: add compatible property to "partitions" node"), the "partitions" subnode of an SPI FLASH device node must have a compatible property. The partitions are no longer detected if it is not present.

---
The abovementioned commit is destined for v4.4.

---
 arch/arm/boot/dts/r8a7793-gose.dts | 1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/r8a7793-gose.dts +1 -0
index 077ab9423f5e17d6..3d4bd3c02c4fece0 100644
@@ -128,6 +128,7 @@
 		m25p,fast-read;
 
 		partitions {
+			compatible = "fixed-partitions";
 			#address-cells = <1>;
 			#size-cells = <1>;
 
Signature · 1 line
1.9.1
#7 lore raw

PATCH 7/7 ARM: shmobile: silk dts: Add compatible property to "partitions" node

In reply to Geert Uytterhoeven

As of commit e488ca9f8d4f62c2 ("doc: dt: mtd: partitions: add compatible property to "partitions" node"), the "partitions" subnode of an SPI FLASH device node must have a compatible property. The partitions are no longer detected if it is not present.

---
The abovementioned commit is destined for v4.4.

---
 arch/arm/boot/dts/r8a7794-silk.dts | 1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/r8a7794-silk.dts +1 -0
index eb608283a24c070c..c0ae94979a71b04c 100644
@@ -217,6 +217,7 @@
 		m25p,fast-read;
 
 		partitions {
+			compatible = "fixed-partitions";
 			#address-cells = <1>;
 			#size-cells = <1>;
 
Signature · 1 line
1.9.1
#8 lore raw

cover ARM: dts: Add compatible property to "partitions" node

In reply to Geert Uytterhoeven
Quoted 6 lines · Geert Uytterhoeven
	Hi,

As of commit e488ca9f8d4f62c2 ("doc: dt: mtd: partitions: add compatible property to "partitions" node"), the "partitions" subnode of an SPI FLASH device node must have a compatible property. The partitions are no longer detected if it is not present.

For all patches:

Quoted 2 lines

I marked this series as "RFC", as the abovementioned commit is not yet upstream. Ideally, the users should be fixed first, to avoid breakage.

I'd differ on the last sentence. It's more important to straighten out the release features for 4.4 than to make sure that linux-next has perfect DTS files. So I'll submit whenever ready :)

FWIW, I plan to submit my pullreq this week, hopefully by end-of-Wednesday. (There are other potential MTD fixes that haven't stabilized. I may just send them separately.)

Regards,
Brian

Quoted 37 lines

Tested on r8a7791/koelsch.

Thanks!

Geert Uytterhoeven (7):
ARM: dt: mvebu: ix4-300d: Add compatible property to "partitions" node
ARM: shmobile: bockw dts: Add compatible property to "partitions" node
ARM: shmobile: lager dts: Add compatible property to "partitions" node
ARM: shmobile: koelsch dts: Add compatible property to "partitions"
node
ARM: shmobile: porter dts: Add compatible property to "partitions"
node
ARM: shmobile: gose dts: Add compatible property to "partitions" node
ARM: shmobile: silk dts: Add compatible property to "partitions" node

 arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts | 1 +
 arch/arm/boot/dts/r8a7778-bockw.dts             | 1 +
 arch/arm/boot/dts/r8a7790-lager.dts             | 1 +
 arch/arm/boot/dts/r8a7791-koelsch.dts           | 1 +
 arch/arm/boot/dts/r8a7791-porter.dts            | 1 +
 arch/arm/boot/dts/r8a7793-gose.dts              | 1 +
 arch/arm/boot/dts/r8a7794-silk.dts              | 1 +
 7 files changed, 7 insertions(+)
Signature · 12 lines
1.9.1

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
#9 lore raw

cover ARM: dts: Add compatible property to "partitions" node

Hi Brian,

Quoted 12 lines · Brian Norris
Quoted 4 lines · Geert Uytterhoeven

As of commit e488ca9f8d4f62c2 ("doc: dt: mtd: partitions: add compatible property to "partitions" node"), the "partitions" subnode of an SPI FLASH device node must have a compatible property. The partitions are no longer detected if it is not present.

For all patches:

Quoted 2 lines

I marked this series as "RFC", as the abovementioned commit is not yet upstream. Ideally, the users should be fixed first, to avoid breakage.

It breaks bisectability in mainline.

Quoted 3 lines

I'd differ on the last sentence. It's more important to straighten out the release features for 4.4 than to make sure that linux-next has perfect DTS files. So I'll submit whenever ready :)

If the DTS changes go in first, bisectability is preserved.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

#10 lore raw

cover ARM: dts: Add compatible property to "partitions" node

Quoted 8 lines · Geert Uytterhoeven
Quoted 6 lines · Brian Norris
Quoted 4 lines · Geert Uytterhoeven

As of commit e488ca9f8d4f62c2 ("doc: dt: mtd: partitions: add compatible property to "partitions" node"), the "partitions" subnode of an SPI FLASH device node must have a compatible property. The partitions are no longer detected if it is not present.

Quoted 8 lines
Quoted 6 lines

For all patches:

Quoted 2 lines

I marked this series as "RFC", as the abovementioned commit is not yet upstream. Ideally, the users should be fixed first, to avoid breakage.

It breaks bisectability in mainline.

The files you are fixing are not converted in mainline yet, are they?

Quoted 5 lines
Quoted 3 lines

I'd differ on the last sentence. It's more important to straighten out the release features for 4.4 than to make sure that linux-next has perfect DTS files. So I'll submit whenever ready :)

If the DTS changes go in first, bisectability is preserved.

Are you asking me to delay fixing the DT binding until 4.5, just because your for-next branches can't be fixed? IOW, you want me to release the bad DT binding for a whole cycle?

Brian

#11 lore raw

cover ARM: dts: Add compatible property to "partitions" node

+ real linux-mtd mailing list

Quoted 31 lines · Brian Norris
Quoted 8 lines · Geert Uytterhoeven
Quoted 6 lines · Brian Norris
Quoted 4 lines · Geert Uytterhoeven

As of commit e488ca9f8d4f62c2 ("doc: dt: mtd: partitions: add compatible property to "partitions" node"), the "partitions" subnode of an SPI FLASH device node must have a compatible property. The partitions are no longer detected if it is not present.

Quoted 8 lines
Quoted 6 lines

For all patches:

Quoted 2 lines

I marked this series as "RFC", as the abovementioned commit is not yet upstream. Ideally, the users should be fixed first, to avoid breakage.

It breaks bisectability in mainline.

The files you are fixing are not converted in mainline yet, are they?

Quoted 5 lines
Quoted 3 lines

I'd differ on the last sentence. It's more important to straighten out the release features for 4.4 than to make sure that linux-next has perfect DTS files. So I'll submit whenever ready :)

If the DTS changes go in first, bisectability is preserved.

Are you asking me to delay fixing the DT binding until 4.5, just because your for-next branches can't be fixed? IOW, you want me to release the bad DT binding for a whole cycle?

Brian

#12 lore raw

cover ARM: dts: Add compatible property to "partitions" node

Hi Brian,

Quoted 23 lines · Brian Norris

+ real linux-mtd mailing list

Quoted 19 lines · Brian Norris
Quoted 8 lines · Geert Uytterhoeven
Quoted 6 lines · Brian Norris
Quoted 4 lines · Geert Uytterhoeven

As of commit e488ca9f8d4f62c2 ("doc: dt: mtd: partitions: add compatible property to "partitions" node"), the "partitions" subnode of an SPI FLASH device node must have a compatible property. The partitions are no longer detected if it is not present.

Quoted 8 lines
Quoted 6 lines

For all patches:

Quoted 2 lines

I marked this series as "RFC", as the abovementioned commit is not yet upstream. Ideally, the users should be fixed first, to avoid breakage.

It breaks bisectability in mainline.

The files you are fixing are not converted in mainline yet, are they?

Sorry, too long after my morning coffee...
Yes, you're right, they won't be in mainline before v4.5-rc1.

When I noticed the problem, I didn't see the cause immediately, so I did a bisect. Which didn't help much, as the problem only occurs when merging l2-mtd/master...

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 3 lines

I'd differ on the last sentence. It's more important to straighten out the release features for 4.4 than to make sure that linux-next has perfect DTS files. So I'll submit whenever ready :)

If the DTS changes go in first, bisectability is preserved.

Scrap, they can't go in first...

Quoted 3 lines
Quoted 3 lines

Are you asking me to delay fixing the DT binding until 4.5, just because your for-next branches can't be fixed? IOW, you want me to release the bad DT binding for a whole cycle?

No, please don't delay it to 4.5.

But I'm afraid the for-next branches can't be fixed, as the DTS updates been in arm-soc/for-next for a while. I don't think the arm-soc maintainers can be bothered redoing all their merges, so we'll have to live with it...

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds