Skip to contentSkip to conversation

media_entity: logical vs bitwise AND typo

PATCH New Dan Carpenter 1 participant 1 message Dec 15, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 media_entity: logical vs bitwise AND typo

This was obviously supposed to be a bitwise AND.

Fixes 403da6ca3465 ('[media] media: move MEDIA_LNK_FL_INTERFACE_LINK logic to link creation')
drivers/media/media-entity.c +1 -1
index 7895e17..6926e06 100644
@@ -526,7 +526,7 @@ media_create_pad_link(struct media_entity *source, u16 source_pad,
 
 	link->source = &source->pads[source_pad];
 	link->sink = &sink->pads[sink_pad];
-	link->flags = flags && ~MEDIA_LNK_FL_INTERFACE_LINK;
+	link->flags = flags & ~MEDIA_LNK_FL_INTERFACE_LINK;
 
 	/* Initialize graph object embedded at the new link */
 	media_gobj_create(source->graph_obj.mdev, MEDIA_GRAPH_LINK,