sfc: fix a timeout loop
Subsystems (4)
PATCH 1/1 sfc: fix a timeout loop
We test for if "tries" is zero at the end but "tries--" is a post-op so it will end with "tries" set to -1. I have changed it to a pre-op instead.
Signed-off-by Dan Carpenter <[email protected]>
drivers/net/ethernet/sfc/txc43128_phy.c +1 -1
@@ -418,7 +418,7 @@ static void txc_reset_logic_mmd(struct efx_nic *efx, int mmd) val |= (1 <<TXC_GLCMD_LMTSWRST_LBN );efx_mdio_write (efx, mmd,TXC_GLRGS_GLCMD , val); -while (tries--) { +while (--tries) { val =efx_mdio_read (efx, mmd,TXC_GLRGS_GLCMD );if (!(val & (1 <<TXC_GLCMD_LMTSWRST_LBN )))break ;
From: Dan Carpenter <[email protected]>
Date: Tue, 15 Dec 2015 14:06:08 +0300
Quoted 5 lines
We test for if "tries" is zero at the end but "tries--" is a post-op so it will end with "tries" set to -1. I have changed it to a pre-op instead.
Signed-off-by Dan Carpenter <[email protected]>
Applied.