Skip to contentSkip to conversation

sbc: new package

PATCH Superseded gustavo.zacarias at free-electrons.com 3 participants 4 messages Dec 14, 2015 – Dec 15, 2015

lore
Share & tools
lore

gustavo.zacarias at free-electrons.com

author
#0 lore raw

PATCH v2 1/1 sbc: new package

From: Gustavo Zacarias <[email protected]>

Signed-off-by Gustavo Zacarias <[email protected]>
---
 package/Config.in     |  1 +
 package/sbc/Config.in |  8 ++++++++
 package/sbc/sbc.hash  |  2 ++
 package/sbc/sbc.mk    | 15 +++++++++++++++
 4 files changed, 26 insertions(+)
 create mode 100644 package/sbc/Config.in
 create mode 100644 package/sbc/sbc.hash
 create mode 100644 package/sbc/sbc.mk
package/Config.in +1 -0
index 1ab5133..1c7c64b 100644
@@ -739,6 +739,7 @@ menu "Audio/Sound"
 	source "package/opus/Config.in"
 	source "package/opusfile/Config.in"
 	source "package/portaudio/Config.in"
+	source "package/sbc/Config.in"
 	source "package/speex/Config.in"
 	source "package/taglib/Config.in"
 	source "package/tinyalsa/Config.in"
package/sbc/Config.in new file +8 -0
new file mode 100644
index 0000000..f1dbc0e
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_SBC
+	bool "sbc"
+	select BR2_PACKAGE_LIBSNDFILE
+	help
+	  An audio codec to connect bluetooth high quality audio
+	  devices like headphones or loudspeakers.
+
+	  http://www.bluez.org/
package/sbc/sbc.hash new file +2 -0
new file mode 100644
index 0000000..be3c8f7
@@ -0,0 +1,2 @@
+# From https://www.kernel.org/pub/linux/bluetooth/sha256sums.asc
+sha256	e61022cf576f14190241e7071753fdacdce5d1dea89ffd704110fc50be689309	sbc-1.3.tar.xz
package/sbc/sbc.mk new file +15 -0
new file mode 100644
index 0000000..60ebc74
@@ -0,0 +1,15 @@
+################################################################################
+#
+# sbc
+#
+################################################################################
+
+SBC_VERSION = 1.3
+SBC_SOURCE = sbc-$(SBC_VERSION).tar.xz
+SBC_SITE = $(BR2_KERNEL_MIRROR)/linux/bluetooth
+SBC_INSTALL_STAGING = YES
+SBC_DEPENDENCIES = libsndfile host-pkgconf
+SBC_LICENSE = GPLv2+ (programs), LGPLv2.1+ (library)
+SBC_LICENSE_FILES = COPYING COPYING.LIB
+
+$(eval $(autotools-package))
Signature · 1 line
2.4.10
#1 lore raw

PATCH v2 1/1 sbc: new package

Dear Gustavo Zacarias,

Quoted 4 lines · gustavo.zacarias at free-electrons.com

From: Gustavo Zacarias <[email protected]>

Signed-off-by Gustavo Zacarias <[email protected]>

---

I was expecting some sort of changelog here, as the manual says:

"21.5.2. Patch revision changelog

When improvements are requested, the new revision of each commit should include a changelog of the modifications between each submission."

Quoted 27 lines
 package/Config.in     |  1 +
 package/sbc/Config.in |  8 ++++++++
 package/sbc/sbc.hash  |  2 ++
 package/sbc/sbc.mk    | 15 +++++++++++++++
 4 files changed, 26 insertions(+)
 create mode 100644 package/sbc/Config.in
 create mode 100644 package/sbc/sbc.hash
 create mode 100644 package/sbc/sbc.mk
package/Config.in +1 -0
index 1ab5133..1c7c64b 100644
@@ -739,6 +739,7 @@ menu "Audio/Sound"
 	source "package/opus/Config.in"
 	source "package/opusfile/Config.in"
 	source "package/portaudio/Config.in"
+	source "package/sbc/Config.in"
 	source "package/speex/Config.in"
 	source "package/taglib/Config.in"
 	source "package/tinyalsa/Config.in"
package/sbc/Config.in new file +0 -0
new file mode 100644
index 0000000..f1dbc0e

package/sbc/Config.in line 6

Quoted 6 lines
package/sbc/Config.in new file +6 -0
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_SBC
+	bool "sbc"
+	select BR2_PACKAGE_LIBSNDFILE
+	help
+	  An audio codec to connect bluetooth high quality audio
+	  devices like headphones or loudspeakers.

The "devices" word fits in the first line.

Apart from that, everything looks OK to me, so...

Reviewed-by Vicente Olivert Riera <[email protected]>
Tested-by Vicente Olivert Riera <[email protected]>

Build test for MIPS architecture:

$ file output/target/usr/lib/libsbc.so.1.2.1
output/target/usr/lib/libsbc.so.1.2.1: ELF 32-bit LSB shared object,
MIPS, MIPS32 rel2 version 1 (SYSV), dynamically linked, stripped

Regards,

Vincent.

author
#2 lore raw

PATCH v2 1/1 sbc: new package

Quoted 8 lines · Vicente Olivert Riera

Dear Gustavo Zacarias,

Quoted 4 lines · gustavo.zacarias at free-electrons.com

From: Gustavo Zacarias <[email protected]>

Signed-off-by Gustavo Zacarias <[email protected]>

---

Quoted 6 lines

I was expecting some sort of changelog here, as the manual says:

"21.5.2. Patch revision changelog

When improvements are requested, the new revision of each commit should include a changelog of the modifications between each submission."

Hi.
It was lost in the shuffle, it's just the licensing style change. Regards.

Applied
#3 lore raw

PATCH v2 1/1 sbc: new package

In reply to gustavo.zacarias at free-electrons.com

Gustavo,

Quoted 12 lines · gustavo.zacarias at free-electrons.com

From: Gustavo Zacarias <[email protected]>

Signed-off-by Gustavo Zacarias <[email protected]>
---
 package/Config.in     |  1 +
 package/sbc/Config.in |  8 ++++++++
 package/sbc/sbc.hash  |  2 ++
 package/sbc/sbc.mk    | 15 +++++++++++++++
 4 files changed, 26 insertions(+)
 create mode 100644 package/sbc/Config.in
 create mode 100644 package/sbc/sbc.hash
 create mode 100644 package/sbc/sbc.mk

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com