gptfdisk: Add host package

PATCH Superseded Trent Piepho 3 participants 5 messages Dec 8, 2015 – Dec 15, 2015

Share & tools

Trent Piepho

author

2015-12-08 23:27 UTC #0 lore raw

PATCH 1/1 gptfdisk: Add host package

This tool is useful for scripts that create flash images with multiple partitions. The host-parted package can do this too, but is missing a number of features that the gptfdisk program has for dealing with GPT.

The interactive gdisk and curses based sgdisk aren't built. Just the scriptable tool sgdisk. The target package allows configuring which tools are built, but this seem unnecessarily complex for the host package.

Signed-off-by Trent Piepho <[email protected]>

---
 package/Config.in.host          |  1 +
 package/gptfdisk/Config.in.host |  9 +++++++++
 package/gptfdisk/gptfdisk.mk    | 11 +++++++++++
 3 files changed, 21 insertions(+)
 create mode 100644 package/gptfdisk/Config.in.host

package/Config.in.host +1 -0

index ce1b6bc..d757316 100644
@@ -12,6 +12,7 @@ menu "Host utilities"
 	source "package/genext2fs/Config.in.host"
 	source "package/genimage/Config.in.host"
 	source "package/genpart/Config.in.host"
+	source "package/gptfdisk/Config.in.host"
 	source "package/imx-usb-loader/Config.in.host"
 	source "package/jq/Config.in.host"
 	source "package/lpc3250loader/Config.in.host"

package/gptfdisk/Config.in.host new file +9 -0

new file mode 100644
index 0000000..7bdfd00
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_HOST_GPTFDISK
+	bool "host gptfdisk"
+	help
+          GPT fdisk (consisting of the gdisk and sgdisk programs) is a
+          text-mode partitioning tool that works on Globally Unique Identifier
+          (GUID) Partition Table (GPT) disks, rather than on the more common
+          (through 2010) Master Boot Record (MBR) partition tables.
+
+          http://www.rodsbooks.com/gdisk/

package/gptfdisk/gptfdisk.mk +11 -0

index abfddfb..089e862 100644
@@ -46,4 +46,15 @@ define GPTFDISK_INSTALL_TARGET_CMDS
 	done
 endef
 
+HOST_GPTFDISK_DEPENDENCIES = host-util-linux host-popt
+define HOST_GPTFDISK_BUILD_CMDS
+	$(HOST_MAKE_ENV) $(MAKE) $(HOST_CONFIGURE_OPTS) -C $(@D) \
+		sgdisk
+endef
+
+define HOST_GPTFDISK_INSTALL_CMDS
+	$(INSTALL) -D -m 0755 $(@D)/sgdisk $(HOST_DIR)/usr/sbin/sgdisk
+endef
+
 $(eval $(generic-package))
+$(eval $(host-generic-package))

Signature · 1 line

1.8.3.1

Yann E. MORIN

2015-12-13 21:00 UTC #1 lore raw

PATCH 1/1 gptfdisk: Add host package

Trent, All,

On 2015-12-08 23:27 +0000, Trent Piepho spake thusly:

Quoted 9 lines

This tool is useful for scripts that create flash images with multiple partitions. The host-parted package can do this too, but is missing a number of features that the gptfdisk program has for dealing with GPT.
The interactive gdisk and curses based sgdisk aren't built. Just the scriptable tool sgdisk. The target package allows configuring which tools are built, but this seem unnecessarily complex for the host package.

I agree. We normally do not have configurable options for host packages. And since in this case only the scriptable sgdisj is really of any interest, that's totally OK with me.

However, I have a few comments, see below...

Quoted 26 lines

Signed-off-by Trent Piepho <[email protected]>

---
 package/Config.in.host          |  1 +
 package/gptfdisk/Config.in.host |  9 +++++++++
 package/gptfdisk/gptfdisk.mk    | 11 +++++++++++
 3 files changed, 21 insertions(+)
 create mode 100644 package/gptfdisk/Config.in.host

package/Config.in.host +1 -0

index ce1b6bc..d757316 100644
@@ -12,6 +12,7 @@ menu "Host utilities"
 	source "package/genext2fs/Config.in.host"
 	source "package/genimage/Config.in.host"
 	source "package/genpart/Config.in.host"
+	source "package/gptfdisk/Config.in.host"
 	source "package/imx-usb-loader/Config.in.host"
 	source "package/jq/Config.in.host"
 	source "package/lpc3250loader/Config.in.host"

package/gptfdisk/Config.in.host new file +0 -0

new file mode 100644
index 0000000..7bdfd00

package/gptfdisk/Config.in.host line 2

Quoted 2 lines

package/gptfdisk/Config.in.host new file +2 -0
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_HOST_GPTFDISK
+	bool "host gptfdisk"

The target variant needs libuuid from util-linux, so I guess you also want to select BR2_PACKAGE_HOST_UTIL_LINUX.

I see below that you just added a build-time dependency. Although this is usually enough for most host packages, you still need to do the select in Kconfig since util-linux does have an entry in Kconfig.

Otherwise, that's good for me. Care to fix and respin, please? Thanks!

Regards,
Yann E. MORIN.

Quoted 35 lines

package/gptfdisk/Config.in.host new file +7 -0

+	help
+          GPT fdisk (consisting of the gdisk and sgdisk programs) is a
+          text-mode partitioning tool that works on Globally Unique Identifier
+          (GUID) Partition Table (GPT) disks, rather than on the more common
+          (through 2010) Master Boot Record (MBR) partition tables.
+
+          http://www.rodsbooks.com/gdisk/

package/gptfdisk/gptfdisk.mk +11 -0

index abfddfb..089e862 100644
@@ -46,4 +46,15 @@ define GPTFDISK_INSTALL_TARGET_CMDS
 	done
 endef
 
+HOST_GPTFDISK_DEPENDENCIES = host-util-linux host-popt
+define HOST_GPTFDISK_BUILD_CMDS
+	$(HOST_MAKE_ENV) $(MAKE) $(HOST_CONFIGURE_OPTS) -C $(@D) \
+		sgdisk
+endef
+
+define HOST_GPTFDISK_INSTALL_CMDS
+	$(INSTALL) -D -m 0755 $(@D)/sgdisk $(HOST_DIR)/usr/sbin/sgdisk
+endef
+
 $(eval $(generic-package))
+$(eval $(host-generic-package))

Signature · 7 lines

1.8.3.1


_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 6 lines

.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

Trent Piepho

author

2015-12-15 01:53 UTC #2 lore raw

PATCH v2 1/1 gptfdisk: Add host package

Thomas Petazzoni

Applied

2015-12-15 21:34 UTC #3 lore raw

PATCH 1/1 gptfdisk: Add host package

In reply to Trent Piepho

Dear Trent Piepho,

Quoted 10 lines · Trent Piepho

This tool is useful for scripts that create flash images with multiple partitions. The host-parted package can do this too, but is missing a number of features that the gptfdisk program has for dealing with GPT.
The interactive gdisk and curses based sgdisk aren't built. Just the scriptable tool sgdisk. The target package allows configuring which tools are built, but this seem unnecessarily complex for the host package.

Quoted 7 lines

Signed-off-by Trent Piepho <[email protected]>

---
 package/Config.in.host          |  1 +
 package/gptfdisk/Config.in.host |  9 +++++++++
 package/gptfdisk/gptfdisk.mk    | 11 +++++++++++
 3 files changed, 21 insertions(+)
 create mode 100644 package/gptfdisk/Config.in.host

Applied, thanks.

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Thomas Petazzoni

2015-12-15 21:34 UTC #4 lore raw

PATCH 1/1 gptfdisk: Add host package

Hello,

Quoted 7 lines · Thomas Petazzoni

Quoted 5 lines

 package/Config.in.host          |  1 +
 package/gptfdisk/Config.in.host |  9 +++++++++
 package/gptfdisk/gptfdisk.mk    | 11 +++++++++++
 3 files changed, 21 insertions(+)
 create mode 100644 package/gptfdisk/Config.in.host

Applied, thanks.

Obviously, I applied the v2 of your patch, not the v1.

Thanks,

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com