Skip to contentSkip to conversation

wil6210: fix a warning message condition

PATCH Applied Dan Carpenter 3 participants 3 messages Dec 16, 2015 – Dec 31, 2015

Subsystems (2)
Kernel janitors Wilocity WIL6210 wireless driver
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 wil6210: fix a warning message condition

"iter" is -1 at the end of the loop and not zero. It means we don't print a warning message.

Signed-off-by Dan Carpenter <[email protected]>
drivers/net/wireless/ath/wil6210/main.c +1 -1
index 48687f1..4544e8c 100644
@@ -985,7 +985,7 @@ int __wil_down(struct wil6210_priv *wil)
 	}
 	mutex_lock(&wil->mutex);
 
-	if (!iter)
+	if (iter < 0)
 		wil_err(wil, "timeout waiting for idle FW/HW\n");
 
 	wil_reset(wil, false);
Acked-by Maya Erez on v1 1/1
#1 lore raw
Acked-by Maya Erez <[email protected]>

-----Original Message-----
From: Dan Carpenter [mailto:[email protected]]
Sent: Wednesday, December 16, 2015 1:10 PM
To: qca_merez
Cc: Kalle Valo; [email protected]; wil6210; [email protected]
Subject: [patch] wil6210: fix a warning message condition

"iter" is -1 at the end of the loop and not zero. It means we don't print a warning message.

Signed-off-by Dan Carpenter <[email protected]>
drivers/net/wireless/ath/wil6210/main.c +1 -1
index 48687f1..4544e8c 100644
@@ -985,7 +985,7 @@ int __wil_down(struct wil6210_priv *wil)
 	}
 	mutex_lock(&wil->mutex);
 
-	if (!iter)
+	if (iter < 0)
 		wil_err(wil, "timeout waiting for idle FW/HW\n");
 
 	wil_reset(wil, false);