Skip to contentSkip to conversation

ASoC: Intel: Skylake: Fix a couple signedness bugs

PATCH Superseded Dan Carpenter 3 participants 5 messages Dec 12, 2015 – Dec 16, 2015

Subsystems (4)
Sound Kernel janitors ASoC Intel ASoC drivers

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 ASoC: Intel: Skylake: Fix a couple signedness bugs

These need to be unsigned because they hold negative error codes.

Signed-off-by Dan Carpenter <[email protected]>
sound/soc/intel/skylake/skl-sst.c +3 -3
index 8cd5cdb..e26f474 100644
@@ -208,7 +208,7 @@ static unsigned int skl_get_errorcode(struct sst_dsp *ctx)
  * since get/set_module are called from DAPM context,
  * we don't need lock for usage count
  */
-static unsigned int skl_get_module(struct sst_dsp *ctx, u16 mod_id)
+static int skl_get_module(struct sst_dsp *ctx, u16 mod_id)
 {
 	struct skl_module_table *module;
 

@@ -220,7 +220,7 @@ static unsigned int skl_get_module(struct sst_dsp *ctx, u16 mod_id)
 	return -EINVAL;
 }
 
-static unsigned int skl_put_module(struct sst_dsp *ctx, u16 mod_id)
+static int skl_put_module(struct sst_dsp *ctx, u16 mod_id)
 {
 	struct skl_module_table *module;
 

@@ -340,7 +340,7 @@ static int skl_load_module(struct sst_dsp *ctx, u16 mod_id, char *guid)
 
 static int skl_unload_module(struct sst_dsp *ctx, u16 mod_id)
 {
-	unsigned int usage_cnt;
+	int usage_cnt;
 	struct skl_sst *skl = ctx->thread_context;
 	int ret = 0;
Acked-by on v1 1/1
#1 lore raw
Quoted 3 lines · Dan Carpenter

These need to be unsigned because they hold negative error codes.

Signed-off-by Dan Carpenter <[email protected]>
Acked-by Vinod Koul <[email protected]>
Quoted 33 lines
sound/soc/intel/skylake/skl-sst.c +3 -3
index 8cd5cdb..e26f474 100644
@@ -208,7 +208,7 @@ static unsigned int skl_get_errorcode(struct sst_dsp *ctx)
  * since get/set_module are called from DAPM context,
  * we don't need lock for usage count
  */
-static unsigned int skl_get_module(struct sst_dsp *ctx, u16 mod_id)
+static int skl_get_module(struct sst_dsp *ctx, u16 mod_id)
 {
 	struct skl_module_table *module;
 

@@ -220,7 +220,7 @@ static unsigned int skl_get_module(struct sst_dsp *ctx, u16 mod_id)
 	return -EINVAL;
 }
 
-static unsigned int skl_put_module(struct sst_dsp *ctx, u16 mod_id)
+static int skl_put_module(struct sst_dsp *ctx, u16 mod_id)
 {
 	struct skl_module_table *module;
 

@@ -340,7 +340,7 @@ static int skl_load_module(struct sst_dsp *ctx, u16 mod_id, char *guid)
 
 static int skl_unload_module(struct sst_dsp *ctx, u16 mod_id)
 {
-	unsigned int usage_cnt;
+	int usage_cnt;
 	struct skl_sst *skl = ctx->thread_context;
 	int ret = 0;
Signature · 1 line
~Vinod
author
#2 lore raw
Quoted 6 lines · Vinod Koul
Quoted 3 lines · Dan Carpenter

These need to be unsigned because they hold negative error codes.

Signed-off-by Dan Carpenter <[email protected]>
Acked-by Vinod Koul <[email protected]>

Sorry, I sent a v2 of this with "be unsigned" changed to "be signed" in the changelog, but I messed up the In-Reply-To header so it was a new thread.

regards,
dan carpenter

#3 lore raw
Quoted 11 lines · Dan Carpenter
Quoted 6 lines · Vinod Koul
Quoted 3 lines · Dan Carpenter

These need to be unsigned because they hold negative error codes.

Signed-off-by Dan Carpenter <[email protected]>
Acked-by Vinod Koul <[email protected]>

Sorry, I sent a v2 of this with "be unsigned" changed to "be signed" in the changelog, but I messed up the In-Reply-To header so it was a new thread.

No issues, Acked v2 now :)

Signature · 1 line
~Vinod
maintainer
#4 lore raw

Applied "ASoC: Intel: Skylake: Fix a couple signedness bugs" to the asoc tree

In reply to Dan Carpenter

The patch

ASoC: Intel: Skylake: Fix a couple signedness bugs

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From db4e561378b539230feb4db5e7d5d548c2db2cd4 Mon Sep 17 00:00:00 2001

From: Dan Carpenter <[email protected]>
Date: Tue, 15 Dec 2015 12:20:14 +0300
Subject: [PATCH] ASoC: Intel: Skylake: Fix a couple signedness bugs

These need to be signed because they hold negative error codes.

Signed-off-by Dan Carpenter <[email protected]>

Acked-by Vinod Koul <[email protected]>

Signed-off-by Mark Brown <[email protected]>
---
 sound/soc/intel/skylake/skl-sst.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
sound/soc/intel/skylake/skl-sst.c +3 -3
index 8cd5cdb21fd5..e26f4746afb7 100644
@@ -208,7 +208,7 @@ static unsigned int skl_get_errorcode(struct sst_dsp *ctx)
  * since get/set_module are called from DAPM context,
  * we don't need lock for usage count
  */
-static unsigned int skl_get_module(struct sst_dsp *ctx, u16 mod_id)
+static int skl_get_module(struct sst_dsp *ctx, u16 mod_id)
 {
 	struct skl_module_table *module;
 

@@ -220,7 +220,7 @@ static unsigned int skl_get_module(struct sst_dsp *ctx, u16 mod_id)
 	return -EINVAL;
 }
 
-static unsigned int skl_put_module(struct sst_dsp *ctx, u16 mod_id)
+static int skl_put_module(struct sst_dsp *ctx, u16 mod_id)
 {
 	struct skl_module_table *module;
 

@@ -340,7 +340,7 @@ static int skl_load_module(struct sst_dsp *ctx, u16 mod_id, char *guid)
 
 static int skl_unload_module(struct sst_dsp *ctx, u16 mod_id)
 {
-	unsigned int usage_cnt;
+	int usage_cnt;
 	struct skl_sst *skl = ctx->thread_context;
 	int ret = 0;
Signature · 1 line
2.6.2