Skip to contentSkip to conversation

arm: socfpga: Fixed Phy not found error. Fixed QSPI flash not found error Disabled Hardware watch dog by default. Updated MMC clock.

PATCH New ShengjiangWu 3 participants 4 messages Dec 17, 2015 1 message not in the archive

lore
Share & tools
lore

ShengjiangWu

author
#0 lore raw

PATCH 1/1 arm: socfpga: Fixed Phy not found error. Fixed QSPI flash not found error Disabled Hardware watch dog by default. Updated MMC clock.

arm: socfpga: Fixed Phy not found error.
Fixed QSPI flash not found error Disabled Hardware watch dog by default. Updated MMC clock.

Updated pinmux and clock for EMAC1 and QSPI flash. U-BOOT-2015-10 can run on Cyclone V SoC Development Kit (SoCDK) with this fix.

Signed-off-by swu <[email protected]>
Cc Chin Liang See <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Pavel Machek <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Stefan Roese <[email protected]>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-arm-socfpga-Fixed-Phy-not-found-error.patch
Type: application/octet-stream
Size: 8369 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151217/e08e555c/attachment.obj>

#1 lore raw

PATCH 1/1 arm: socfpga: Fixed Phy not found error. Fixed QSPI flash not found error Disabled Hardware watch dog by default. Updated MMC clock.

Quoted 4 lines · ShengjiangWu

arm: socfpga: Fixed Phy not found error.
Fixed QSPI flash not found error Disabled Hardware watch dog by default. Updated MMC clock.

Fix your mailer please.

Quoted 11 lines

Updated pinmux and clock for EMAC1 and QSPI flash. U-BOOT-2015-10 can run on Cyclone V SoC Development Kit (SoCDK) with this fix.

Signed-off-by swu <[email protected]>
Cc Chin Liang See <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Pavel Machek <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Stefan Roese <[email protected]>

Please repost the patch using git send-email , details are at [1] and the process is very similar to Linux.

I briefly skimmed across the patch. I don't understand why do you replace almost the entire pinmux just to fix ethernet issue. (ethernet works on SoCDK I believe, which is another odd thing).

Furthermore, if you're fixing multiple things, split them into multiple patches.

Finally, do not disable HW watchdog.

[1] www.denx.de/wiki/U-Boot/Patches

Best regards,
Marek Vasut

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw

PATCH 1/1 arm: socfpga: Fixed Phy not found error. Fixed QSPI flash not found error Disabled Hardware watch dog by default. Updated MMC clock.

Quoted 1 line · ShengjiangWu

Hi Marek Vasut,

Hi,

Quoted 1 line

I will submit it later, thanks for your reminder.

Thanks.

Also, please do not top-post and please keep the entire Cc list intact. Also keep the ML in the list.

Quoted 49 lines

Best Regards
Shengjiang Wu

------------------ Original ------------------

From:  "marex";<[email protected]>;
Date:  Thu, Dec 17, 2015 11:46 AM
To:  "ShengjiangWu"<[email protected]>;

Cc: "u-boot"<[email protected]>; "shengjiangwu"<[email protected]>; "clsee"<[email protected]>; "dinguyen"<[email protected]>; "dinh.linux"<[email protected]>; "pavel"<[email protected]>; "sr"<[email protected]>; Subject: Re: [PATCH] arm: socfpga: Fixed Phy not found
error. Fixed QSPI flash not found error
Disabled Hardware watch dog by default. Updated MMC clock.

Quoted 5 lines · ShengjiangWu

arm: socfpga: Fixed Phy not found error.

Fixed QSPI flash not found error Disabled Hardware watch dog by default. Updated MMC clock.

Fix your mailer please.

Quoted 11 lines

Updated pinmux and clock for EMAC1 and QSPI flash. U-BOOT-2015-10 can run on Cyclone V SoC Development Kit (SoCDK) with this fix.

Signed-off-by swu <[email protected]>
Cc Chin Liang See <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Pavel Machek <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Stefan Roese <[email protected]>

Please repost the patch using git send-email , details are at [1] and the process is very similar to Linux.

I briefly skimmed across the patch. I don't understand why do you replace almost the entire pinmux just to fix ethernet issue. (ethernet works on SoCDK I believe, which is another odd thing).

Furthermore, if you're fixing multiple things, split them into multiple patches.

Quoted 6 lines

Finally, do not disable HW watchdog.

[1] www.denx.de/wiki/U-Boot/Patches

Best regards,
Marek Vasut

Best regards,
Marek Vasut

#4 lore raw

PATCH 1/1 arm: socfpga: Fixed Phy not found error. Fixed QSPI flash not found error Disabled Hardware watch dog by default. Updated MMC clock.

In reply to ShengjiangWu

Dear Shengjiang Wu,

Quoted 1 line · In message <[email protected]> you wrote:

| Subject: Re: [U-Boot] [PATCH] arm: socfpga: Fixed Phy not found error. Fixed QSPI flash not found error Disabled Hardware watch dog by default. Updated MMC clock.

Please move this information into the commit message; the Subject should be short - some 60 characters or so, not more.

Thanks.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Above all else -- sky.