Skip to contentSkip to conversation

ARM: shmobile: r8a7790: DU and IPMMU-MX prototype

PATCH In review Magnus Damm 2 participants 3 messages Dec 17, 2015

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: shmobile: r8a7790: DU and IPMMU-MX prototype

From: Magnus Damm <[email protected]>

Enable the IPMMU-MX device and hook up the DU on r8a7790, and also include enable debug messages.

On boards such as r8a7790 Lager the DU will with this change included use IOMMU framework and IPMMU-MX device when driving on-board video output via VGA, HDMI and LVDS.

Not-Yet-Signed-off-by Magnus Damm <[email protected]>

---

Written against renesas-devel-20151217v2-v4.4-rc5

 arch/arm/boot/dts/r8a7790.dtsi |    3 ++-
 drivers/iommu/iommu.c          |    2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)
arch/arm/boot/dts/r8a7790.dtsi +2 -1
@@ -886,6 +886,7 @@
 			 <&mstp7_clks R8A7790_CLK_LVDS0>,
 			 <&mstp7_clks R8A7790_CLK_LVDS1>;
 		clock-names = "du.0", "du.1", "du.2", "lvds.0", "lvds.1";
+		iommus = <&ipmmu_mx 15>, <&ipmmu_mx 16>;
 		status = "disabled";
 
 		ports {
@@ -1809,7 +1810,7 @@
 		interrupts = <0 222 IRQ_TYPE_LEVEL_HIGH>,
 			     <0 221 IRQ_TYPE_LEVEL_HIGH>;
 		#iommu-cells = <1>;
-		status = "disabled";
+		status = "okay";
 	};
 
 	ipmmu_rt: mmu@ffc80000 {
drivers/iommu/iommu.c +1 -1
@@ -15,7 +15,7 @@
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307 USA
  */
-
+#define DEBUG
 #define pr_fmt(fmt)    "iommu: " fmt
 
 #include <linux/device.h>
#1 lore raw

Hello.

Quoted 29 lines · Magnus Damm

From: Magnus Damm <[email protected]>

Enable the IPMMU-MX device and hook up the DU on r8a7790, and also include enable debug messages.

On boards such as r8a7790 Lager the DU will with this change included use IOMMU framework and IPMMU-MX device when driving on-board video output via VGA, HDMI and LVDS.

Not-Yet-Signed-off-by Magnus Damm <[email protected]>

---

Written against renesas-devel-20151217v2-v4.4-rc5

  arch/arm/boot/dts/r8a7790.dtsi |    3 ++-
  drivers/iommu/iommu.c          |    2 +-
  2 files changed, 3 insertions(+), 2 deletions(-)
arch/arm/boot/dts/r8a7790.dtsi +1 -0
@@ -886,6 +886,7 @@
  			 <&mstp7_clks R8A7790_CLK_LVDS0>,
  			 <&mstp7_clks R8A7790_CLK_LVDS1>;
  		clock-names = "du.0", "du.1", "du.2", "lvds.0", "lvds.1";
+		iommus = <&ipmmu_mx 15>, <&ipmmu_mx 16>;
  		status = "disabled";
 
  		ports {

arch/arm/boot/dts/r8a7790.dtsi line 1813

Quoted 5 lines
arch/arm/boot/dts/r8a7790.dtsi +1 -1
@@ -1809,7 +1810,7 @@
  		interrupts = <0 222 IRQ_TYPE_LEVEL_HIGH>,
  			     <0 221 IRQ_TYPE_LEVEL_HIGH>;
  		#iommu-cells = <1>;
-		status = "disabled";
+		status = "okay";

It's enough to just omit the "status" prop, AFAIK.

[...]

drivers/iommu/iommu.c line 18

Quoted 8 lines
drivers/iommu/iommu.c +1 -1
@@ -15,7 +15,7 @@
   * along with this program; if not, write to the Free Software
   * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307 USA
   */
-
+#define DEBUG

Unrelated change?

MBR, Sergei

#2 lore raw
In reply to Magnus Damm

Hello.

Quoted 29 lines · Magnus Damm

From: Magnus Damm <[email protected]>

Enable the IPMMU-MX device and hook up the DU on r8a7790, and also include enable debug messages.

On boards such as r8a7790 Lager the DU will with this change included use IOMMU framework and IPMMU-MX device when driving on-board video output via VGA, HDMI and LVDS.

Not-Yet-Signed-off-by Magnus Damm <[email protected]>

---

Written against renesas-devel-20151217v2-v4.4-rc5

  arch/arm/boot/dts/r8a7790.dtsi |    3 ++-
  drivers/iommu/iommu.c          |    2 +-
  2 files changed, 3 insertions(+), 2 deletions(-)
arch/arm/boot/dts/r8a7790.dtsi +1 -0
@@ -886,6 +886,7 @@
  			 <&mstp7_clks R8A7790_CLK_LVDS0>,
  			 <&mstp7_clks R8A7790_CLK_LVDS1>;
  		clock-names = "du.0", "du.1", "du.2", "lvds.0", "lvds.1";
+		iommus = <&ipmmu_mx 15>, <&ipmmu_mx 16>;
  		status = "disabled";
 
  		ports {

arch/arm/boot/dts/r8a7790.dtsi line 1813

Quoted 5 lines
arch/arm/boot/dts/r8a7790.dtsi +1 -1
@@ -1809,7 +1810,7 @@
  		interrupts = <0 222 IRQ_TYPE_LEVEL_HIGH>,
  			     <0 221 IRQ_TYPE_LEVEL_HIGH>;
  		#iommu-cells = <1>;
-		status = "disabled";
+		status = "okay";

It's enough to just omit the "status" prop, AFAIK.

[...]

drivers/iommu/iommu.c line 18

Quoted 8 lines
drivers/iommu/iommu.c +1 -1
@@ -15,7 +15,7 @@
   * along with this program; if not, write to the Free Software
   * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307 USA
   */
-
+#define DEBUG

Unrelated change?

MBR, Sergei