cgroups: move cpuset specific checks from generic code to cpuset_can_attach
PATCH v3 1/1 cgroups: move cpuset specific checks from generic code to cpuset_can_attach
Move PF_NO_SETAFFINITY check to cpuset cgroups, where it belongs. This makes it possible to attach PF_NO_SETAFFINITY to Intel CAT cgroups.
Reported-by Luiz Capitulino <[email protected]>
Signed-off-by Marcelo Tosatti <[email protected]>
v2: "PF_NO_SETAFFINITY check" -> "PF_NO_SETAFFINITY and kthreadd_task checks"
v3: keep kthreadd_task check for all cgroup controllers
kernel/cgroup.c +3 -4
@@ -2740,11 +2740,10 @@ static ssize_t __cgroup_procs_write(struct kernfs_open_file *of, char *buf, tsk = tsk->group_leader;/* -* Workqueue threads may acquire PF_NO_SETAFFINITY and become -* trapped in a cpuset, or RT worker may be born in a cgroup -* with no rt_runtime allocated. Just say no. +* RT worker may be born in a cgroup with no +* rt_runtime allocated. Just say no. */ -if (tsk == kthreadd_task || (tsk->flags &PF_NO_SETAFFINITY )) { +if (tsk == kthreadd_task) { ret = -EINVAL ; goto out_unlock_rcu; }
kernel/cpuset.c +9 -0
@@ -53,6 +53,7 @@#include <linux/time.h> #include <linux/backing-dev.h> #include <linux/sort.h> +#include <linux/kthread.h> #include <asm/uaccess.h> #include <linux/atomic.h>
@@ -1449,6 +1450,14 @@ static int cpuset_can_attach(struct cgroup_taskset *tset) goto out_unlock;cgroup_taskset_for_each (task, css, tset) { +/* +* Workqueue threads may acquire PF_NO_SETAFFINITY and +* become trapped in a cpuset. +*/ +if (task->flags &PF_NO_SETAFFINITY ) { + ret = -EINVAL ; + goto out_unlock; + } ret =task_can_attach (task, cs->cpus_allowed);if (ret) goto out_unlock;