package/nodejs: Add version 5.2.0
PATCH 1/3 package/nodejs: Add version 5.2.0
v5.2.0 is the current Stable release. See
https://nodejs.org/en/blog/release/v5.2.0 for details on the release.
--- ...01-Remove-dependency-on-Python-bz2-module.patch | 31 +++++++ .../0002-gyp-force-link-command-to-use-CXX.patch | 29 ++++++ ...hon-variable-instead-of-hardcoding-Python.patch | 101 +++++++++++++++++++++ package/nodejs/5.2.0/0004-fix-arm-vfpv2.patch | 46 ++++++++++ .../5.2.0/0005-Fix-va_list-not-declared.patch | 39 ++++++++ package/nodejs/Config.in | 12 +++ package/nodejs/nodejs.hash | 3 + package/nodejs/nodejs.mk | 2 +- 8 files changed, 262 insertions(+), 1 deletion(-) create mode 100644 package/nodejs/5.2.0/0001-Remove-dependency-on-Python-bz2-module.patch create mode 100644 package/nodejs/5.2.0/0002-gyp-force-link-command-to-use-CXX.patch create mode 100644 package/nodejs/5.2.0/0003-Use-a-python-variable-instead-of-hardcoding-Python.patch create mode 100644 package/nodejs/5.2.0/0004-fix-arm-vfpv2.patch create mode 100644 package/nodejs/5.2.0/0005-Fix-va_list-not-declared.patch
package/nodejs/5.2.0/0001-Remove-dependency-on-Python-bz2-module.patch new file +31 -0
@@ -0,0 +1,31 @@ +From 3d4817c152d6f3afddcc699949c4d1664da91e2b Mon Sep 17 00:00:00 2001 +From: Martin Bark <[email protected]> +Date: Tue, 30 Jun 2015 09:43:11 +0100 +Subject: [PATCH 1/4] Remove dependency on Python bz2 module + +Do not import the bz2 module, it is not used. + +Signed-off-by: Thomas Petazzoni <[email protected]> +[Martin: adapt to 0.12.5] +Signed-off-by: Martin Bark <[email protected]> +[yann.morin.1998 at free.fr: adapt to 4.1.2] +Signed-off-by: "Yann E. MORIN" <[email protected]> +--- + deps/v8/tools/js2c.py | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/deps/v8/tools/js2c.py b/deps/v8/tools/js2c.py +index 77485f6..371caf5 100755 +--- a/deps/v8/tools/js2c.py ++++ b/deps/v8/tools/js2c.py +@@ -34,7 +34,6 @@ + import os, re, sys, string + import optparse + import jsmin +-import bz2 + import textwrap + + +-- +2.1.4 +
package/nodejs/5.2.0/0002-gyp-force-link-command-to-use-CXX.patch new file +29 -0
@@ -0,0 +1,29 @@ +From 90a3c113c19ec615249ab880c45c6c0a8d369098 Mon Sep 17 00:00:00 2001 +From: Martin Bark <[email protected]> +Date: Tue, 30 Jun 2015 09:43:47 +0100 +Subject: [PATCH 2/4] gyp: force link command to use CXX + +Signed-off-by: Samuel Martin <[email protected]> +Signed-off-by: Martin Bark <[email protected]> +[yann.morin.1998 at free.fr: adapt to 4.1.2] +Signed-off-by: "Yann E. MORIN" <[email protected]> +--- + tools/gyp/pylib/gyp/generator/make.py | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/tools/gyp/pylib/gyp/generator/make.py b/tools/gyp/pylib/gyp/generator/make.py +index b88a433..0a1f2e0 100644 +--- a/tools/gyp/pylib/gyp/generator/make.py ++++ b/tools/gyp/pylib/gyp/generator/make.py +@@ -142,7 +142,7 @@ cmd_alink_thin = rm -f $@ && $(AR.$(TOOLSET)) crsT $@ $(filter %.o,$^) + # special "figure out circular dependencies" flags around the entire + # input list during linking. + quiet_cmd_link = LINK($(TOOLSET)) $@ +-cmd_link = $(LINK.$(TOOLSET)) $(GYP_LDFLAGS) $(LDFLAGS.$(TOOLSET)) -o $@ -Wl,--start-group $(LD_INPUTS) -Wl,--end-group $(LIBS) ++cmd_link = $(CXX.$(TOOLSET)) $(GYP_LDFLAGS) $(LDFLAGS.$(TOOLSET)) -o $@ -Wl,--start-group $(LD_INPUTS) -Wl,--end-group $(LIBS) + + # We support two kinds of shared objects (.so): + # 1) shared_library, which is just bundling together many dependent libraries +-- +2.1.4 +
package/nodejs/5.2.0/0003-Use-a-python-variable-instead-of-hardcoding-Python.patch new file +101 -0
101 lines not on this page · raw message
package/nodejs/5.2.0/0004-fix-arm-vfpv2.patch new file +46 -0
46 lines not on this page · raw message
package/nodejs/5.2.0/0005-Fix-va_list-not-declared.patch new file +39 -0
@@ -0,0 +1,39 @@ +From 5b3dd2599ebde1846750aaf7c79576ad45246ffa Mon Sep 17 00:00:00 2001 +From: Martin Bark <[email protected]> +Date: Tue, 8 Dec 2015 11:41:08 +0000 +Subject: [PATCH] Fix va_list not declared +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +When compiling with uClibc-ng the following error is seen. + +In file included from ../deps/v8/src/log-utils.cc:5:0: +../deps/v8/src/log-utils.h:64:39: error: ?va_list? has not been declared + void AppendVA(const char* format, va_list args); + +This patch fixes the issue by adding the missing #include <cstdarg>. Note +that this fix has already be included upstream, see +https://github.com/nodejs/node/blob/8a43a3d/deps/v8/src/log-utils.h + +Signed-off-by: Martin Bark <[email protected]> +--- + deps/v8/src/log-utils.h | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/deps/v8/src/log-utils.h b/deps/v8/src/log-utils.h +index 87dab52..6714307 100644 +--- a/deps/v8/src/log-utils.h ++++ b/deps/v8/src/log-utils.h +@@ -5,6 +5,8 @@ + #ifndef V8_LOG_UTILS_H_ + #define V8_LOG_UTILS_H_ + ++#include <cstdarg> ++ + #include "src/allocation.h" + #include "src/base/platform/mutex.h" + #include "src/flags.h" +-- +2.5.0 +
package/nodejs/Config.in +12 -0
@@ -57,6 +57,17 @@ comment "v4.2.3 needs a toolchain w/ gcc >= 4.8" depends on BR2_PACKAGE_NODEJS_V8_ARCH_SUPPORTS depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 +config BR2_BR2_PACKAGE_NODEJS_5_X + bool "v5.2.0" + depends on BR2_PACKAGE_NODEJS_V8_ARCH_SUPPORTS + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 + depends on BR2_USE_WCHAR + +comment "v5.2.0 needs a toolchain w/ gcc >= 4.8, wchar" + depends on BR2_PACKAGE_NODEJS_V8_ARCH_SUPPORTS + depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 + depends on !BR2_USE_WCHAR + endchoice config BR2_PACKAGE_NODEJS_VERSION_STRING
@@ -64,6 +75,7 @@ config BR2_PACKAGE_NODEJS_VERSION_STRING default "0.10.41" if BR2_BR2_PACKAGE_NODEJS_0_10_X default "0.12.9" if BR2_BR2_PACKAGE_NODEJS_0_12_X default "4.2.3" if BR2_BR2_PACKAGE_NODEJS_4_X + default "5.2.0" if BR2_BR2_PACKAGE_NODEJS_5_X menu "Module Selection"
package/nodejs/nodejs.hash +3 -0
@@ -6,3 +6,6 @@ sha256 35daad301191e5f8dd7e5d2fbb711d081b82d1837d59837b8ee224c256cfe5e4 node-v0 # From upstream URL: http://nodejs.org/dist/v4.2.3/SHASUMS256.txt sha256 9e8aef1e47b317575c421c8d10a80e6c319b26969b566d3b84e49e65a92837f4 node-v4.2.3.tar.xz + +# From upstream URL: http://nodejs.org/dist/v5.2.0/SHASUMS256.txt +sha256 0cda6254aea3330a711f5b30425ad363568456ee1fd70336b21890b1c605f356 node-v5.2.0.tar.xz
package/nodejs/nodejs.mk +1 -1
@@ -5,7 +5,7 @@ ################################################################################ NODEJS_VERSION = $(call qstrip,$(BR2_PACKAGE_NODEJS_VERSION_STRING)) -ifeq ($(BR2_BR2_PACKAGE_NODEJS_4_X),y) +ifneq (,$(filter y,$(BR2_BR2_PACKAGE_NODEJS_4_X) $(BR2_BR2_PACKAGE_NODEJS_5_X))) NODEJS_SOURCE = node-v$(NODEJS_VERSION).tar.xz else NODEJS_SOURCE = node-v$(NODEJS_VERSION).tar.gz
Signature · 1 line
2.5.0
PATCH 2/3 package/nodejs: Fix uClibc-ng support
From: "Bark, Martin" <[email protected]>
Fix segmentation fault in node.js when using uClibc-ng.
This patch fixes bug #8296, see
https://bugs.busybox.net/show_bug.cgi?id=8296.
--- .../0006-Fix-crash-in-GetInterfaceAddresses.patch | 37 ++++++++++++++++++++++ .../0.12.9/0007-Fix-support-for-uClibc-ng.patch | 32 +++++++++++++++++++ .../0005-Fix-crash-in-GetInterfaceAddresses.patch | 37 ++++++++++++++++++++++ .../4.2.3/0006-Fix-support-for-uClibc-ng.patch | 32 +++++++++++++++++++ .../0006-Fix-crash-in-GetInterfaceAddresses.patch | 37 ++++++++++++++++++++++ .../5.2.0/0007-Fix-support-for-uClibc-ng.patch | 32 +++++++++++++++++++ 6 files changed, 207 insertions(+) create mode 100644 package/nodejs/0.12.9/0006-Fix-crash-in-GetInterfaceAddresses.patch create mode 100644 package/nodejs/0.12.9/0007-Fix-support-for-uClibc-ng.patch create mode 100644 package/nodejs/4.2.3/0005-Fix-crash-in-GetInterfaceAddresses.patch create mode 100644 package/nodejs/4.2.3/0006-Fix-support-for-uClibc-ng.patch create mode 100644 package/nodejs/5.2.0/0006-Fix-crash-in-GetInterfaceAddresses.patch create mode 100644 package/nodejs/5.2.0/0007-Fix-support-for-uClibc-ng.patch
package/nodejs/0.12.9/0006-Fix-crash-in-GetInterfaceAddresses.patch new file +37 -0
@@ -0,0 +1,37 @@ +From 839bd9d147b2c85fe70196c86dbdbed504762caf Mon Sep 17 00:00:00 2001 +From: "Bark, Martin" <[email protected]> +Date: Mon, 14 Dec 2015 13:27:51 +0000 +Subject: [PATCH 1/2] Fix crash in GetInterfaceAddresses + +If uv_interface_addresses() returns UV_ENOSYS then interfaces and count are +uninitialised. This can cause a segmentation fault inside +GetInterfaceAddresses when it tries to use the invalid interfaces[]. Fix +the issue by returning from GetInterfaceAddresses on the UV_ENOSYS error. + +This issue was observed when using uCLibc-ng version 1.0.9 because +uv_interface_addresses() in deps/uv/src/unix/linux-core.c incorrectly +undefines HAVE_IFADDRS_H. + +Submitted upstream, see https://github.com/nodejs/node/pull/4272 + +Signed-off-by: Martin Bark <[email protected]> +--- + src/node_os.cc | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/src/node_os.cc b/src/node_os.cc +index a100090..92f53a9 100644 +--- a/src/node_os.cc ++++ b/src/node_os.cc +@@ -200,7 +200,7 @@ static void GetInterfaceAddresses(const FunctionCallbackInfo<Value>& args) { + ret = Object::New(env->isolate()); + + if (err == UV_ENOSYS) { +- args.GetReturnValue().Set(ret); ++ return args.GetReturnValue().Set(ret); + } else if (err) { + return env->ThrowUVException(err, "uv_interface_addresses"); + } +-- +2.6.2 +
package/nodejs/0.12.9/0007-Fix-support-for-uClibc-ng.patch new file +32 -0
@@ -0,0 +1,32 @@ +From 1cc08f6ceacbb0e5ba1f4638ca3a97ac002d7792 Mon Sep 17 00:00:00 2001 +From: "Bark, Martin" <[email protected]> +Date: Mon, 14 Dec 2015 13:26:10 +0000 +Subject: [PATCH 2/2] Fix support for uClibc-ng + +uClibc-ng is currently at v1.0.9. The patch corrects the uClibc +version test so that HAVE_IFADDRS_H is defined for uClibc versions +after v0.9.32. + +Submitted upstream to libuv, see https://github.com/libuv/libuv/pull/653 + +Signed-off-by: Bark, Martin <[email protected]> +--- + deps/uv/src/unix/linux-core.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/deps/uv/src/unix/linux-core.c b/deps/uv/src/unix/linux-core.c +index e6e6828..6cbbb71 100644 +--- a/deps/uv/src/unix/linux-core.c ++++ b/deps/uv/src/unix/linux-core.c +@@ -39,7 +39,7 @@ + #define HAVE_IFADDRS_H 1 + + #ifdef __UCLIBC__ +-# if __UCLIBC_MAJOR__ < 0 || __UCLIBC_MINOR__ < 9 || __UCLIBC_SUBLEVEL__ < 32 ++# if __UCLIBC_MAJOR__ < 0 && __UCLIBC_MINOR__ < 9 && __UCLIBC_SUBLEVEL__ < 32 + # undef HAVE_IFADDRS_H + # endif + #endif +-- +2.6.2 +
package/nodejs/4.2.3/0005-Fix-crash-in-GetInterfaceAddresses.patch new file +37 -0
@@ -0,0 +1,37 @@ +From 839bd9d147b2c85fe70196c86dbdbed504762caf Mon Sep 17 00:00:00 2001 +From: "Bark, Martin" <[email protected]> +Date: Mon, 14 Dec 2015 13:27:51 +0000 +Subject: [PATCH 1/2] Fix crash in GetInterfaceAddresses + +If uv_interface_addresses() returns UV_ENOSYS then interfaces and count are +uninitialised. This can cause a segmentation fault inside +GetInterfaceAddresses when it tries to use the invalid interfaces[]. Fix +the issue by returning from GetInterfaceAddresses on the UV_ENOSYS error. + +This issue was observed when using uCLibc-ng version 1.0.9 because +uv_interface_addresses() in deps/uv/src/unix/linux-core.c incorrectly +undefines HAVE_IFADDRS_H. + +Submitted upstream, see https://github.com/nodejs/node/pull/4272 + +Signed-off-by: Martin Bark <[email protected]> +--- + src/node_os.cc | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/src/node_os.cc b/src/node_os.cc +index a100090..92f53a9 100644 +--- a/src/node_os.cc ++++ b/src/node_os.cc +@@ -200,7 +200,7 @@ static void GetInterfaceAddresses(const FunctionCallbackInfo<Value>& args) { + ret = Object::New(env->isolate()); + + if (err == UV_ENOSYS) { +- args.GetReturnValue().Set(ret); ++ return args.GetReturnValue().Set(ret); + } else if (err) { + return env->ThrowUVException(err, "uv_interface_addresses"); + } +-- +2.6.2 +
package/nodejs/4.2.3/0006-Fix-support-for-uClibc-ng.patch new file +32 -0
@@ -0,0 +1,32 @@ +From 1cc08f6ceacbb0e5ba1f4638ca3a97ac002d7792 Mon Sep 17 00:00:00 2001 +From: "Bark, Martin" <[email protected]> +Date: Mon, 14 Dec 2015 13:26:10 +0000 +Subject: [PATCH 2/2] Fix support for uClibc-ng + +uClibc-ng is currently at v1.0.9. The patch corrects the uClibc +version test so that HAVE_IFADDRS_H is defined for uClibc versions +after v0.9.32. + +Submitted upstream to libuv, see https://github.com/libuv/libuv/pull/653 + +Signed-off-by: Bark, Martin <[email protected]> +--- + deps/uv/src/unix/linux-core.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/deps/uv/src/unix/linux-core.c b/deps/uv/src/unix/linux-core.c +index e6e6828..6cbbb71 100644 +--- a/deps/uv/src/unix/linux-core.c ++++ b/deps/uv/src/unix/linux-core.c +@@ -39,7 +39,7 @@ + #define HAVE_IFADDRS_H 1 + + #ifdef __UCLIBC__ +-# if __UCLIBC_MAJOR__ < 0 || __UCLIBC_MINOR__ < 9 || __UCLIBC_SUBLEVEL__ < 32 ++# if __UCLIBC_MAJOR__ < 0 && __UCLIBC_MINOR__ < 9 && __UCLIBC_SUBLEVEL__ < 32 + # undef HAVE_IFADDRS_H + # endif + #endif +-- +2.6.2 +
package/nodejs/5.2.0/0006-Fix-crash-in-GetInterfaceAddresses.patch new file +37 -0
@@ -0,0 +1,37 @@ +From 839bd9d147b2c85fe70196c86dbdbed504762caf Mon Sep 17 00:00:00 2001 +From: "Bark, Martin" <[email protected]> +Date: Mon, 14 Dec 2015 13:27:51 +0000 +Subject: [PATCH 1/2] Fix crash in GetInterfaceAddresses + +If uv_interface_addresses() returns UV_ENOSYS then interfaces and count are +uninitialised. This can cause a segmentation fault inside +GetInterfaceAddresses when it tries to use the invalid interfaces[]. Fix +the issue by returning from GetInterfaceAddresses on the UV_ENOSYS error. + +This issue was observed when using uCLibc-ng version 1.0.9 because +uv_interface_addresses() in deps/uv/src/unix/linux-core.c incorrectly +undefines HAVE_IFADDRS_H. + +Submitted upstream, see https://github.com/nodejs/node/pull/4272 + +Signed-off-by: Martin Bark <[email protected]> +--- + src/node_os.cc | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/src/node_os.cc b/src/node_os.cc +index a100090..92f53a9 100644 +--- a/src/node_os.cc ++++ b/src/node_os.cc +@@ -200,7 +200,7 @@ static void GetInterfaceAddresses(const FunctionCallbackInfo<Value>& args) { + ret = Object::New(env->isolate()); + + if (err == UV_ENOSYS) { +- args.GetReturnValue().Set(ret); ++ return args.GetReturnValue().Set(ret); + } else if (err) { + return env->ThrowUVException(err, "uv_interface_addresses"); + } +-- +2.6.2 +
package/nodejs/5.2.0/0007-Fix-support-for-uClibc-ng.patch new file +32 -0
@@ -0,0 +1,32 @@ +From 1cc08f6ceacbb0e5ba1f4638ca3a97ac002d7792 Mon Sep 17 00:00:00 2001 +From: "Bark, Martin" <[email protected]> +Date: Mon, 14 Dec 2015 13:26:10 +0000 +Subject: [PATCH 2/2] Fix support for uClibc-ng + +uClibc-ng is currently at v1.0.9. The patch corrects the uClibc +version test so that HAVE_IFADDRS_H is defined for uClibc versions +after v0.9.32. + +Submitted upstream to libuv, see https://github.com/libuv/libuv/pull/653 + +Signed-off-by: Bark, Martin <[email protected]> +--- + deps/uv/src/unix/linux-core.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/deps/uv/src/unix/linux-core.c b/deps/uv/src/unix/linux-core.c +index e6e6828..6cbbb71 100644 +--- a/deps/uv/src/unix/linux-core.c ++++ b/deps/uv/src/unix/linux-core.c +@@ -39,7 +39,7 @@ + #define HAVE_IFADDRS_H 1 + + #ifdef __UCLIBC__ +-# if __UCLIBC_MAJOR__ < 0 || __UCLIBC_MINOR__ < 9 || __UCLIBC_SUBLEVEL__ < 32 ++# if __UCLIBC_MAJOR__ < 0 && __UCLIBC_MINOR__ < 9 && __UCLIBC_SUBLEVEL__ < 32 + # undef HAVE_IFADDRS_H + # endif + #endif +-- +2.6.2 +
Signature · 1 line
2.5.0
PATCH 3/3 package/libuv: Fix support for uClibc-ng
In reply to Martin BarkSee https://bugs.busybox.net/show_bug.cgi?id=8296 for further details on the origins of this bug.
--- package/libuv/0001-Fix-support-for-uClibc-ng.patch | 30 ++++++++++++++++++++++ 1 file changed, 30 insertions(+) create mode 100644 package/libuv/0001-Fix-support-for-uClibc-ng.patch
package/libuv/0001-Fix-support-for-uClibc-ng.patch new file +30 -0
@@ -0,0 +1,30 @@ +From e116adf6a0c85b3e4444fc6c87a41e9de036b80f Mon Sep 17 00:00:00 2001 +From: Martin Bark <[email protected]> +Date: Mon, 14 Dec 2015 12:04:44 +0000 +Subject: [PATCH] Fix support for uClibc-ng + +uClibc-ng is currently at v1.0.9. The patch corrects the uClibc +version test so that HAVE_IFADDRS_H is defined for uClibc versions +after v0.9.32. + +Signed-off-by: Martin Bark <[email protected]> +--- + src/unix/linux-core.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/src/unix/linux-core.c b/src/unix/linux-core.c +index 3ff6fb1..4735bc4 100644 +--- a/src/unix/linux-core.c ++++ b/src/unix/linux-core.c +@@ -39,7 +39,7 @@ + #define HAVE_IFADDRS_H 1 + + #ifdef __UCLIBC__ +-# if __UCLIBC_MAJOR__ < 0 || __UCLIBC_MINOR__ < 9 || __UCLIBC_SUBLEVEL__ < 32 ++# if __UCLIBC_MAJOR__ < 0 && __UCLIBC_MINOR__ < 9 && __UCLIBC_SUBLEVEL__ < 32 + # undef HAVE_IFADDRS_H + # endif + #endif +-- +2.6.2 +
Signature · 1 line
2.5.0
PATCH 1/3 package/nodejs: Add version 5.2.0
In reply to Martin BarkMartin,
Quoted 4 lines · Martin Bark
v5.2.0 is the current Stable release. See
https://nodejs.org/en/blog/release/v5.2.0 for details on the release.Signed-off-by Martin Bark <[email protected]>
So, we already have 0.10.x, 0.12.x, 4.2.x and now 5.2.x ?
Is it possible to get rid of some older versions, rather than keeping all of them available ?
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/3 package/nodejs: Add version 5.2.0
Thomas, All,
I'm not sure the answer to that. What i can say is that all four are getting maintained. Also, according to https://github.com/nodejs/LTS
node.js 0.10.x will be maintained all the way until October 2016.
I see two logical approaches for buildroot:
1) Support all four in buildroot because node.js support all four
2) Only Support the 4.x and 5.x because they are the current LTS and Stable releases (i.e. the ones on the front page of
https://nodejs.org)
Personally I'd vote for 2) because it simplifies things.
What are your thoughts?
Thanks
Martin
Quoted 20 lines · Thomas Petazzoni
Martin,
Quoted 4 lines · Martin Bark
v5.2.0 is the current Stable release. See
https://nodejs.org/en/blog/release/v5.2.0 for details on the release.Signed-off-by Martin Bark <[email protected]>So, we already have 0.10.x, 0.12.x, 4.2.x and now 5.2.x ?
Is it possible to get rid of some older versions, rather than keeping all of them available ?
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
PATCH 1/3 package/nodejs: Add version 5.2.0
Hello,
Quoted 6 lines · Martin Bark
I'm not sure the answer to that. What i can say is that all four are getting maintained. Also, according to https://github.com/nodejs/LTS
node.js 0.10.x will be maintained all the way until October 2016.I see two logical approaches for buildroot:
Quoted 8 lines
1) Support all four in buildroot because node.js support all four
2) Only Support the 4.x and 5.x because they are the current LTS and Stable releases (i.e. the ones on the front page of
https://nodejs.org)Personally I'd vote for 2) because it simplifies things.
What are your thoughts?
I'm fine with option (2) as well, but do we have other NodeJS users that would like to see 0.10.x and 0.12.x being kept?
Is there any issue for users of 0.10.x/0.12.x to migrate to 4.2 or 5.2 ?
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/3 package/nodejs: Add version 5.2.0
Thomas, All,
On 2015-12-14 21:43 +0100, Thomas Petazzoni spake thusly:
Quoted 12 lines · Martin Bark
Quoted 11 lines
I'm not sure the answer to that. What i can say is that all four are getting maintained. Also, according to https://github.com/nodejs/LTS
node.js 0.10.x will be maintained all the way until October 2016.I see two logical approaches for buildroot:
1) Support all four in buildroot because node.js support all four
2) Only Support the 4.x and 5.x because they are the current LTS and Stable releases (i.e. the ones on the front page of
https://nodejs.org)
Quoted 8 lines
Quoted 3 lines
Personally I'd vote for 2) because it simplifies things.
What are your thoughts?
I'm fine with option (2) as well, but do we have other NodeJS users that would like to see 0.10.x and 0.12.x being kept?
Is there any issue for users of 0.10.x/0.12.x to migrate to 4.2 or 5.2 ?
We do have the various version of nodejs, because:
- 4.2.x needs gcc >= 4.8 and armv6+
- 0.12.x needs armv6+
- 0.10.x has not requirement
Going back in our history:
- we had nodejs-0.10
- someone proposed to bump to 0.12
- someone else wanted to keep 0.10 around because of armv6+ requirement
- so we added 0.12, and kept 0.10
- the story repeated itself with 4.2.x
So, I think we have a few options here:
1) keep all the three existing versions, add 5.2
2) keep 0.10 and 0.12, replace 4.2 with 5.2
3) keep 0.10, ditch 0.12, replace 4.2 with 5.2
4) dith 0.10 and 0.12, replace 4.2 with 5.2
I would lean toward either 2 or 3.
3 is IMHO the best solution: 5.2 is the best choice when all the conditions are met; 0.10 is the fallback, maybe not the optimum in case 0.12 would have fit, but since that's a fallback I don't think it matters much...
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/3 package/nodejs: Add version 5.2.0
Yann, All,
Quoted 46 lines · Yann E. MORIN
Thomas, All,
On 2015-12-14 21:43 +0100, Thomas Petazzoni spake thusly:
Quoted 12 lines · Martin Bark
Quoted 11 lines
I'm not sure the answer to that. What i can say is that all four are getting maintained. Also, according to https://github.com/nodejs/LTS
node.js 0.10.x will be maintained all the way until October 2016.I see two logical approaches for buildroot:
1) Support all four in buildroot because node.js support all four
2) Only Support the 4.x and 5.x because they are the current LTS and Stable releases (i.e. the ones on the front page of
https://nodejs.org)Quoted 8 lines
Quoted 3 lines
Personally I'd vote for 2) because it simplifies things.
What are your thoughts?
I'm fine with option (2) as well, but do we have other NodeJS users that would like to see 0.10.x and 0.12.x being kept?
Is there any issue for users of 0.10.x/0.12.x to migrate to 4.2 or 5.2 ?
We do have the various version of nodejs, because:
- 4.2.x needs gcc >= 4.8 and armv6+
- 0.12.x needs armv6+
- 0.10.x has not requirementGoing back in our history:
- we had nodejs-0.10
- someone proposed to bump to 0.12
- someone else wanted to keep 0.10 around because of armv6+ requirement
- so we added 0.12, and kept 0.10
- the story repeated itself with 4.2.xSo, I think we have a few options here:
1) keep all the three existing versions, add 5.2
2) keep 0.10 and 0.12, replace 4.2 with 5.2
3) keep 0.10, ditch 0.12, replace 4.2 with 5.2
4) dith 0.10 and 0.12, replace 4.2 with 5.2
Quoted 6 lines
I would lean toward either 2 or 3.
3 is IMHO the best solution: 5.2 is the best choice when all the conditions are met; 0.10 is the fallback, maybe not the optimum in case 0.12 would have fit, but since that's a fallback I don't think it matters much...
Yes I like option 3) too. This would clarify the situation so that buildroot supports the latest version of node.js only, except 0.10.x which is kept purely for armv5 support. Then in the buildroot 2016.11 release 0.10.x can be dropped too as it will no longer be maintained.
Thanks
Martin
Quoted 11 lines
Regards,
Yann E. MORIN.--
.-----------------.--------------------.------------------.--------------------.| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |'------------------------------^-------^------------------^--------------------'
PATCH 1/3 package/nodejs: Add version 5.2.0
Martin, All,
On 2015-12-14 21:31 +0000, Martin Bark spake thusly:
Quoted 21 lines · Yann E. MORIN
Quoted 20 lines
On 2015-12-14 21:43 +0100, Thomas Petazzoni spake thusly:
Quoted 19 lines · Martin Bark
Quoted 6 lines
I'm not sure the answer to that. What i can say is that all four are getting maintained. Also, according to https://github.com/nodejs/LTS
node.js 0.10.x will be maintained all the way until October 2016.I see two logical approaches for buildroot:
Quoted 8 lines
1) Support all four in buildroot because node.js support all four
2) Only Support the 4.x and 5.x because they are the current LTS and Stable releases (i.e. the ones on the front page of
https://nodejs.org)Personally I'd vote for 2) because it simplifies things.
What are your thoughts?
I'm fine with option (2) as well, but do we have other NodeJS users that would like to see 0.10.x and 0.12.x being kept?
Quoted 7 lines
Quoted 7 lines
Quoted 1 line
Is there any issue for users of 0.10.x/0.12.x to migrate to 4.2 or 5.2 ?
We do have the various version of nodejs, because:
- 4.2.x needs gcc >= 4.8 and armv6+
- 0.12.x needs armv6+
- 0.10.x has not requirement
[--SNIP--]
Quoted 14 lines
Quoted 7 lines
So, I think we have a few options here:
1) keep all the three existing versions, add 5.2
2) keep 0.10 and 0.12, replace 4.2 with 5.2
3) keep 0.10, ditch 0.12, replace 4.2 with 5.2
4) dith 0.10 and 0.12, replace 4.2 with 5.2Quoted 6 lines
I would lean toward either 2 or 3.
3 is IMHO the best solution: 5.2 is the best choice when all the conditions are met; 0.10 is the fallback, maybe not the optimum in case 0.12 would have fit, but since that's a fallback I don't think it matters much...
Quoted 4 lines
Yes I like option 3) too. This would clarify the situation so that buildroot supports the latest version of node.js only, except 0.10.x which is kept purely for armv5 support. Then in the buildroot 2016.11 release 0.10.x can be dropped too as it will no longer be maintained.
Most probably we'd keep it forever. If we were to ditch 0.10, we would have no fallback. As long as it builds and still works fine, we should just keep it.
One option would be to completely get rid of the selection choice, and always build the best version for the curent system. I.e. for an armv5 we'd build 0.10, for gcc <4.8, we'd build 0.10. Otherwise, we'd build 5.2. Of course, we'd have to tell the user what version was being used.
Opinions?
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/3 package/nodejs: Add version 5.2.0
In reply to Yann E. MORINQuoted 50 lines · Yann E. MORIN
Thomas, All,
On 2015-12-14 21:43 +0100, Thomas Petazzoni spake thusly:
Quoted 17 lines · Martin Bark
Quoted 16 lines
I'm not sure the answer to that.??What i can say is that all four are
getting maintained.??Also, according to https://github.com/nodejs
/LTS
node.js 0.10.x will be maintained all the way until October 2016.I see two logical approaches for buildroot:
1) Support all four in buildroot because node.js support all four
2) Only Support the 4.x and 5.x because they are the current LTS and
Stable releases (i.e. the ones on the front page of
https://nodejs.org)Personally I'd vote for 2) because it simplifies things.
Quoted 7 lines
Quoted 1 line
What are your thoughts?
I'm fine with option (2) as well, but do we have other NodeJS users that would like to see 0.10.x and 0.12.x being kept?
Is there any issue for users of 0.10.x/0.12.x to migrate to 4.2 or 5.2 ?
We do have the various version of nodejs, because:
? - 4.2.x needs gcc >= 4.8 and armv6+
? - 0.12.x needs armv6+
? - 0.10.x has not requirementGoing back in our history:
? - we had nodejs-0.10
? - someone proposed to bump to 0.12
? - someone else wanted to keep 0.10 around because of armv6+ ????requirement
? - so we added 0.12, and kept 0.10
? - the story repeated itself with 4.2.xSo, I think we have a few options here:
?1) keep all the three existing versions, add 5.2
?2) keep 0.10 and 0.12, replace 4.2 with 5.2
?3) keep 0.10, ditch 0.12, replace 4.2 with 5.2
?4) dith 0.10 and 0.12, replace 4.2 with 5.2
Quoted 7 lines
I would lean toward either 2 or 3.
3 is IMHO the best solution: 5.2 is the best choice when all the conditions are met; 0.10 is the fallback, maybe not the optimum in case 0.12 would have fit, but since that's a fallback I don't think it matters much...
As 4.x is a LTS release I would not drop it for the 5.x release.
I would keep all the three version we have - they are all still maintained and v0.12 and v4 are both even LTS releases.
New versions are often not compatible with older versions of Node.js - it's similiar to Lua.
So I would lean toward 1.
Best regards
J?rg Krause
PATCH 1/3 package/nodejs: Add version 5.2.0
Dear all,
Quoted 61 lines · J?rg Krause
Quoted 50 lines · Yann E. MORIN
Thomas, All,
On 2015-12-14 21:43 +0100, Thomas Petazzoni spake thusly:
Quoted 17 lines · Martin Bark
Quoted 16 lines
I'm not sure the answer to that. What i can say is that all four are
getting maintained. Also, according to https://github.com/nodejs
/LTS
node.js 0.10.x will be maintained all the way until October 2016.I see two logical approaches for buildroot:
1) Support all four in buildroot because node.js support all four
2) Only Support the 4.x and 5.x because they are the current LTS and
Stable releases (i.e. the ones on the front page of
https://nodejs.org)Personally I'd vote for 2) because it simplifies things.
Quoted 7 lines
Quoted 1 line
What are your thoughts?
I'm fine with option (2) as well, but do we have other NodeJS users that would like to see 0.10.x and 0.12.x being kept?
Is there any issue for users of 0.10.x/0.12.x to migrate to 4.2 or 5.2 ?
We do have the various version of nodejs, because:
- 4.2.x needs gcc >= 4.8 and armv6+
- 0.12.x needs armv6+
- 0.10.x has not requirementGoing back in our history:
- we had nodejs-0.10
- someone proposed to bump to 0.12
- someone else wanted to keep 0.10 around because of armv6+ requirement
- so we added 0.12, and kept 0.10
- the story repeated itself with 4.2.xSo, I think we have a few options here:
1) keep all the three existing versions, add 5.2
2) keep 0.10 and 0.12, replace 4.2 with 5.2
3) keep 0.10, ditch 0.12, replace 4.2 with 5.2
4) dith 0.10 and 0.12, replace 4.2 with 5.2Quoted 7 lines
I would lean toward either 2 or 3.
3 is IMHO the best solution: 5.2 is the best choice when all the conditions are met; 0.10 is the fallback, maybe not the optimum in case 0.12 would have fit, but since that's a fallback I don't think it matters much...
As 4.x is a LTS release I would not drop it for the 5.x release.
Quoted 7 lines
I would keep all the three version we have - they are all still maintained and v0.12 and v4 are both even LTS releases.
New versions are often not compatible with older versions of Node.js - it's similiar to Lua.
So I would lean toward 1.
I agree with you. Dropping a LTS version doesn't look good to me. We could do it when it's not maintained anymore. Right now I vote for keeping the three versions we already have plus adding the 5.2.0 because is the new stable: option 1.
Regards,
Vincent.
PATCH 1/3 package/nodejs: Add version 5.2.0
Hello,
Quoted 23 lines · Vicente Olivert Riera
Quoted 23 lines
Quoted 7 lines
So, I think we have a few options here:
1) keep all the three existing versions, add 5.2
2) keep 0.10 and 0.12, replace 4.2 with 5.2
3) keep 0.10, ditch 0.12, replace 4.2 with 5.2
4) dith 0.10 and 0.12, replace 4.2 with 5.2Quoted 7 lines
I would lean toward either 2 or 3.
3 is IMHO the best solution: 5.2 is the best choice when all the conditions are met; 0.10 is the fallback, maybe not the optimum in case 0.12 would have fit, but since that's a fallback I don't think it matters much...
As 4.x is a LTS release I would not drop it for the 5.x release.
I would keep all the three version we have - they are all still maintained and v0.12 and v4 are both even LTS releases.
New versions are often not compatible with older versions of Node.js - it's similiar to Lua.
Quoted 6 lines
Quoted 1 line
So I would lean toward 1.
I agree with you. Dropping a LTS version doesn't look good to me. We could do it when it's not maintained anymore. Right now I vote for keeping the three versions we already have plus adding the 5.2.0 because is the new stable: option 1.
I am personally not very happy with option (1). Keeping gazillions of versions means that we have potentially to test all those options. And the random testing done by the autobuilders does not work to randomize "choice" options, i.e we will never test the non-default versions.
What is the motivation for keeping all those versions around? While I can understand that keeping 0.10.x around to have a fallback solution for ARMv5 platform is desired, I don't understand why we would keep 0.12.x and 4.2.x.
The fact that 0.12.x and 4.2.x are still maintained upstream as LTS versions is completely irrelevant. There are other projects that may maintain older branches as LTS, and still we don't support all the possible maintained versions.
Are there incompatibilities between 0.12.x, 4.2.x and 5.2.x that prevent a user from easily upgrading?
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/3 package/nodejs: Add version 5.2.0
Thomas, All,
On 2015-12-16 14:41 +0100, Thomas Petazzoni spake thusly:
Quoted 31 lines · Vicente Olivert Riera
Quoted 23 lines
Quoted 23 lines
Quoted 7 lines
So, I think we have a few options here:
1) keep all the three existing versions, add 5.2
2) keep 0.10 and 0.12, replace 4.2 with 5.2
3) keep 0.10, ditch 0.12, replace 4.2 with 5.2
4) dith 0.10 and 0.12, replace 4.2 with 5.2Quoted 7 lines
I would lean toward either 2 or 3.
3 is IMHO the best solution: 5.2 is the best choice when all the conditions are met; 0.10 is the fallback, maybe not the optimum in case 0.12 would have fit, but since that's a fallback I don't think it matters much...
As 4.x is a LTS release I would not drop it for the 5.x release.
I would keep all the three version we have - they are all still maintained and v0.12 and v4 are both even LTS releases.
New versions are often not compatible with older versions of Node.js - it's similiar to Lua.
Quoted 6 lines
Quoted 1 line
So I would lean toward 1.
I agree with you. Dropping a LTS version doesn't look good to me. We could do it when it's not maintained anymore. Right now I vote for keeping the three versions we already have plus adding the 5.2.0 because is the new stable: option 1.
Quoted 4 lines
I am personally not very happy with option (1). Keeping gazillions of versions means that we have potentially to test all those options. And the random testing done by the autobuilders does not work to randomize "choice" options, i.e we will never test the non-default versions.
Not completey true, since the higher versions ahve dependencies not always fulfilled (armv6+, gcc >= 4.8...) so, as we do randomize the CPU from time to time, we would eventually have all versions being built.
But I do agree that this is not the best situation. I would prefer if we could find a solution that does not imply having so many versions. I deeply believe that we should limit ourselves to just having 0.10.x and 5.2.x .
Quoted 9 lines
What is the motivation for keeping all those versions around? While I can understand that keeping 0.10.x around to have a fallback solution for ARMv5 platform is desired, I don't understand why we would keep 0.12.x and 4.2.x.
The fact that 0.12.x and 4.2.x are still maintained upstream as LTS versions is completely irrelevant. There are other projects that may maintain older branches as LTS, and still we don't support all the possible maintained versions.
Totally agreed. LTS status of uostream versions does not mean we should have all of them.
Quoted 2 lines
Are there incompatibilities between 0.12.x, 4.2.x and 5.2.x that prevent a user from easily upgrading?
Are all those versions API/ABI/whatevrer incompatible with each others? Or is it possible to narrow down the set of versions?
I.e. if 4.2.x and 5.2.x are compatible, there is no reason to keep 4.2.x, since 5.2.x is enough and does not have requirements more stringents than 4.2.x. And so on...
Regards,
Yann E. MORIN, in the train...
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/3 package/nodejs: Add version 5.2.0
Quoted 34 lines · Yann E. MORIN
Thomas, All,
On 2015-12-16 14:41 +0100, Thomas Petazzoni spake thusly:
Quoted 31 lines · Vicente Olivert Riera
Quoted 29 lines
Quoted 17 lines
Quoted 7 lines
So, I think we have a few options here:
1) keep all the three existing versions, add 5.2
2) keep 0.10 and 0.12, replace 4.2 with 5.2
3) keep 0.10, ditch 0.12, replace 4.2 with 5.2
4) dith 0.10 and 0.12, replace 4.2 with 5.2Quoted 7 lines
I would lean toward either 2 or 3.
3 is IMHO the best solution: 5.2 is the best choice when all the conditions are met; 0.10 is the fallback, maybe not the optimum in case 0.12 would have fit, but since that's a fallback I don't think it matters much...
As 4.x is a LTS release I would not drop it for the 5.x release.
Quoted 7 lines
I would keep all the three version we have - they are all still maintained and v0.12 and v4 are both even LTS releases.
New versions are often not compatible with older versions of Node.js - it's similiar to Lua.
So I would lean toward 1.
I agree with you. Dropping a LTS version doesn't look good to me. We could do it when it's not maintained anymore. Right now I vote for keeping the three versions we already have plus adding the 5.2.0 because is the new stable: option 1.
Quoted 8 lines
Quoted 4 lines
I am personally not very happy with option (1). Keeping gazillions of versions means that we have potentially to test all those options. And the random testing done by the autobuilders does not work to randomize "choice" options, i.e we will never test the non-default versions.
Not completey true, since the higher versions ahve dependencies not always fulfilled (armv6+, gcc >= 4.8...) so, as we do randomize the CPU from time to time, we would eventually have all versions being built.
One point to note, 5.x also adds the requirement for wchar too which 4.x did not need.
Quoted 22 lines
But I do agree that this is not the best situation. I would prefer if we could find a solution that does not imply having so many versions. I deeply believe that we should limit ourselves to just having 0.10.x and 5.2.x .
Quoted 9 lines
What is the motivation for keeping all those versions around? While I can understand that keeping 0.10.x around to have a fallback solution for ARMv5 platform is desired, I don't understand why we would keep 0.12.x and 4.2.x.
The fact that 0.12.x and 4.2.x are still maintained upstream as LTS versions is completely irrelevant. There are other projects that may maintain older branches as LTS, and still we don't support all the possible maintained versions.
Totally agreed. LTS status of uostream versions does not mean we should have all of them.
Quoted 2 lines
Are there incompatibilities between 0.12.x, 4.2.x and 5.2.x that prevent a user from easily upgrading?
Quoted 6 lines
Are all those versions API/ABI/whatevrer incompatible with each others? Or is it possible to narrow down the set of versions?
I.e. if 4.2.x and 5.2.x are compatible, there is no reason to keep 4.2.x, since 5.2.x is enough and does not have requirements more stringents than 4.2.x. And so on...
There are api changes between the main versions. See
https://github.com/nodejs/node/wiki/API-changes-between-v0.10-and-v0.12,
https://github.com/nodejs/node/wiki/API-changes-between-v0.10-and-v4,
https://nodejs.org/en/blog/release/v5.0.0/ for example. Although these versions have some api changes you really need to keep up to date and are encouraged to upgrade.
Note, 5.3.0 was just released hence this patch set is already outdated.
Thanks
Martin
Quoted 11 lines
Regards,
Yann E. MORIN, in the train...--
.-----------------.--------------------.------------------.--------------------.| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |'------------------------------^-------^------------------^--------------------'
PATCH 1/3 package/nodejs: Add version 5.2.0
Martin, All,
On 2015-12-17 17:29 +0000, Martin Bark spake thusly:
Quoted 40 lines · Yann E. MORIN
Quoted 39 lines
Thomas, All,
On 2015-12-16 14:41 +0100, Thomas Petazzoni spake thusly:
Quoted 35 lines · Vicente Olivert Riera
Quoted 23 lines
Quoted 23 lines
Quoted 7 lines
So, I think we have a few options here:
1) keep all the three existing versions, add 5.2
2) keep 0.10 and 0.12, replace 4.2 with 5.2
3) keep 0.10, ditch 0.12, replace 4.2 with 5.2
4) dith 0.10 and 0.12, replace 4.2 with 5.2Quoted 7 lines
I would lean toward either 2 or 3.
3 is IMHO the best solution: 5.2 is the best choice when all the conditions are met; 0.10 is the fallback, maybe not the optimum in case 0.12 would have fit, but since that's a fallback I don't think it matters much...
As 4.x is a LTS release I would not drop it for the 5.x release.
I would keep all the three version we have - they are all still maintained and v0.12 and v4 are both even LTS releases.
New versions are often not compatible with older versions of Node.js - it's similiar to Lua.
Quoted 6 lines
Quoted 1 line
So I would lean toward 1.
I agree with you. Dropping a LTS version doesn't look good to me. We could do it when it's not maintained anymore. Right now I vote for keeping the three versions we already have plus adding the 5.2.0 because is the new stable: option 1.
I am personally not very happy with option (1). Keeping gazillions of versions means that we have potentially to test all those options. And the random testing done by the autobuilders does not work to randomize "choice" options, i.e we will never test the non-default versions.
Quoted 6 lines
Quoted 3 lines
Not completey true, since the higher versions ahve dependencies not always fulfilled (armv6+, gcc >= 4.8...) so, as we do randomize the CPU from time to time, we would eventually have all versions being built.
One point to note, 5.x also adds the requirement for wchar too which 4.x did not need.
Well, is that really an issue? I would be quite a bit surprised if people would really need to run nodejs on a system without wchar; basically, only uClibc can lack wchar, glibc and musl always have it, and I would contend that using nodejs on a uClibc system without wchar is just not supported.
After all, if one disables wchar in a uClibc toolchain means that one is vey tight on space on the target, and I doubt nodejs would even fit in sch a target.
So I'd say we don't care, and we'd still have 0.10.x as a fallback for that case.
Quoted 28 lines
Quoted 21 lines
But I do agree that this is not the best situation. I would prefer if we could find a solution that does not imply having so many versions. I deeply believe that we should limit ourselves to just having 0.10.x and 5.2.x .
Quoted 9 lines
What is the motivation for keeping all those versions around? While I can understand that keeping 0.10.x around to have a fallback solution for ARMv5 platform is desired, I don't understand why we would keep 0.12.x and 4.2.x.
The fact that 0.12.x and 4.2.x are still maintained upstream as LTS versions is completely irrelevant. There are other projects that may maintain older branches as LTS, and still we don't support all the possible maintained versions.
Totally agreed. LTS status of uostream versions does not mean we should have all of them.
Quoted 2 lines
Are there incompatibilities between 0.12.x, 4.2.x and 5.2.x that prevent a user from easily upgrading?
Quoted 6 lines
Are all those versions API/ABI/whatevrer incompatible with each others? Or is it possible to narrow down the set of versions?
I.e. if 4.2.x and 5.2.x are compatible, there is no reason to keep 4.2.x, since 5.2.x is enough and does not have requirements more stringents than 4.2.x. And so on...
Quoted 6 lines
There are api changes between the main versions. See
https://github.com/nodejs/node/wiki/API-changes-between-v0.10-and-v0.12,
https://github.com/nodejs/node/wiki/API-changes-between-v0.10-and-v4,
https://nodejs.org/en/blog/release/v5.0.0/ for example. Although these versions have some api changes you really need to keep up to date and are encouraged to upgrade.
So we should take thoe encouragements, and just upgrade. ;-)
Quoted 1 line
Note, 5.3.0 was just released hence this patch set is already outdated.
See, that's the issue. If we were to add all major and LTS nodejs versions, we'd now get 5 versions: 0.10.x, 0.12.x, 4.2.x, 5.2.x and now 5.3.x . This is definitely not viable in the long run.
So, my position, and I guess Thomas will agree: please respin this patch byt replacing 4.2 with 5.2, and a follow-up patch to get rid of 0.12.x. In the meantime, I'll mark this one as "Changes Requested" in our Patchwork.
Thanks! ;-)
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/3 package/nodejs: Add version 5.2.0
Yann, All,
Quoted 106 lines · Yann E. MORIN
Martin, All,
On 2015-12-17 17:29 +0000, Martin Bark spake thusly:
Quoted 40 lines · Yann E. MORIN
Quoted 39 lines
Thomas, All,
On 2015-12-16 14:41 +0100, Thomas Petazzoni spake thusly:
Quoted 35 lines · Vicente Olivert Riera
Quoted 23 lines
Quoted 23 lines
Quoted 7 lines
So, I think we have a few options here:
1) keep all the three existing versions, add 5.2
2) keep 0.10 and 0.12, replace 4.2 with 5.2
3) keep 0.10, ditch 0.12, replace 4.2 with 5.2
4) dith 0.10 and 0.12, replace 4.2 with 5.2Quoted 7 lines
I would lean toward either 2 or 3.
3 is IMHO the best solution: 5.2 is the best choice when all the conditions are met; 0.10 is the fallback, maybe not the optimum in case 0.12 would have fit, but since that's a fallback I don't think it matters much...
As 4.x is a LTS release I would not drop it for the 5.x release.
I would keep all the three version we have - they are all still maintained and v0.12 and v4 are both even LTS releases.
New versions are often not compatible with older versions of Node.js - it's similiar to Lua.
Quoted 6 lines
Quoted 1 line
So I would lean toward 1.
I agree with you. Dropping a LTS version doesn't look good to me. We could do it when it's not maintained anymore. Right now I vote for keeping the three versions we already have plus adding the 5.2.0 because is the new stable: option 1.
I am personally not very happy with option (1). Keeping gazillions of versions means that we have potentially to test all those options. And the random testing done by the autobuilders does not work to randomize "choice" options, i.e we will never test the non-default versions.
Quoted 6 lines
Quoted 3 lines
Not completey true, since the higher versions ahve dependencies not always fulfilled (armv6+, gcc >= 4.8...) so, as we do randomize the CPU from time to time, we would eventually have all versions being built.
One point to note, 5.x also adds the requirement for wchar too which 4.x did not need.
Well, is that really an issue? I would be quite a bit surprised if people would really need to run nodejs on a system without wchar; basically, only uClibc can lack wchar, glibc and musl always have it, and I would contend that using nodejs on a uClibc system without wchar is just not supported.
After all, if one disables wchar in a uClibc toolchain means that one is vey tight on space on the target, and I doubt nodejs would even fit in sch a target.
So I'd say we don't care, and we'd still have 0.10.x as a fallback for that case.
Quoted 28 lines
Quoted 21 lines
But I do agree that this is not the best situation. I would prefer if we could find a solution that does not imply having so many versions. I deeply believe that we should limit ourselves to just having 0.10.x and 5.2.x .
Quoted 9 lines
What is the motivation for keeping all those versions around? While I can understand that keeping 0.10.x around to have a fallback solution for ARMv5 platform is desired, I don't understand why we would keep 0.12.x and 4.2.x.
The fact that 0.12.x and 4.2.x are still maintained upstream as LTS versions is completely irrelevant. There are other projects that may maintain older branches as LTS, and still we don't support all the possible maintained versions.
Totally agreed. LTS status of uostream versions does not mean we should have all of them.
Quoted 2 lines
Are there incompatibilities between 0.12.x, 4.2.x and 5.2.x that prevent a user from easily upgrading?
Quoted 6 lines
Are all those versions API/ABI/whatevrer incompatible with each others? Or is it possible to narrow down the set of versions?
I.e. if 4.2.x and 5.2.x are compatible, there is no reason to keep 4.2.x, since 5.2.x is enough and does not have requirements more stringents than 4.2.x. And so on...
Quoted 6 lines
There are api changes between the main versions. See
https://github.com/nodejs/node/wiki/API-changes-between-v0.10-and-v0.12,
https://github.com/nodejs/node/wiki/API-changes-between-v0.10-and-v4,
https://nodejs.org/en/blog/release/v5.0.0/ for example. Although these versions have some api changes you really need to keep up to date and are encouraged to upgrade.So we should take thoe encouragements, and just upgrade. ;-)
Quoted 1 line
Note, 5.3.0 was just released hence this patch set is already outdated.
See, that's the issue. If we were to add all major and LTS nodejs versions, we'd now get 5 versions: 0.10.x, 0.12.x, 4.2.x, 5.2.x and now 5.3.x . This is definitely not viable in the long run.
Quoted 6 lines
So, my position, and I guess Thomas will agree: please respin this patch byt replacing 4.2 with 5.2, and a follow-up patch to get rid of 0.12.x. In the meantime, I'll mark this one as "Changes Requested" in our Patchwork.
Thanks! ;-)
Will do. I have an updated patch set ready, just need to do more testing.
Thanks
Martin
Quoted 11 lines
Regards,
Yann E. MORIN.--
.-----------------.--------------------.------------------.--------------------.| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |'------------------------------^-------^------------------^--------------------'
PATCH 1/3 package/nodejs: Add version 5.2.0
Martin, All,
On 2015-12-17 19:55 +0000, Martin Bark spake thusly:
Quoted 1 line · Yann E. MORIN
[--SNIP--]
Quoted 5 lines
Quoted 4 lines
So, my position, and I guess Thomas will agree: please respin this patch byt replacing 4.2 with 5.2, and a follow-up patch to get rid of 0.12.x. In the meantime, I'll mark this one as "Changes Requested" in our Patchwork.
Will do. I have an updated patch set ready, just need to do more testing.
Great! Thanks! :-)
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'