libgdiplus: new package
PATCH v3 1/1 libgdiplus: new package
Libgdiplus is an open source implementation of the GDI+ API.
---
Changes v2 -> v3:
- removing md5 hash
- adding a comment explaining the source code license
Changes v1 -> v2:
- because of libglib2, package depends on BR2_USE_WCHAR, BR2_TOOLCHAIN_HAS_THREADS and BR2_USE_MMU
- because of cairo, package depends on BR2_PACKAGE_CAIRO
- adding hashes
- fixing license to MIT
- adding a comment explaining why we need to enable autoreconf
- adding a dependency on package host-pkgconf
- adding a comment explaining why we cannot use --without-pango
--- package/Config.in | 1 + package/libgdiplus/Config.in | 21 ++++++++++++++ package/libgdiplus/libgdiplus.hash | 2 ++ package/libgdiplus/libgdiplus.mk | 56 ++++++++++++++++++++++++++++++++++++++ 4 files changed, 80 insertions(+) create mode 100644 package/libgdiplus/Config.in create mode 100644 package/libgdiplus/libgdiplus.hash create mode 100644 package/libgdiplus/libgdiplus.mk
package/Config.in +1 -0
@@ -824,6 +824,7 @@ menu "Graphics" source "package/libfm-extra/Config.in" source "package/libfreeimage/Config.in" source "package/libgail/Config.in" + source "package/libgdiplus/Config.in" source "package/libgeotiff/Config.in" source "package/libglade/Config.in" source "package/libglew/Config.in"
package/libgdiplus/Config.in new file +21 -0
@@ -0,0 +1,21 @@ +config BR2_PACKAGE_LIBGDIPLUS + bool "libgdiplus" + select BR2_PACKAGE_XLIB_LIBXFT + select BR2_PACKAGE_LIBGLIB2 + select BR2_PACKAGE_CAIRO + select BR2_PACKAGE_LIBPNG + depends on BR2_PACKAGE_XORG7 + depends on BR2_USE_WCHAR # libglib2 -> gettext + depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2 + depends on BR2_USE_MMU # libglib2 + depends on BR2_ARCH_HAS_ATOMICS # cairo + help + An Open Source implementation of the GDI+ API. + + https://github.com/mono/libgdiplus + +comment "libgdiplus needs a toolchain w/ wchar, threads" + depends on BR2_USE_MMU + depends on BR2_ARCH_HAS_ATOMICS + depends on BR2_PACKAGE_XORG7 + depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
package/libgdiplus/libgdiplus.hash new file +2 -0
@@ -0,0 +1,2 @@ +# Locally computed: +sha256 7eadc5105c6352d456c5f8699dc89260bf402e82ce6668e7e0c625519f9e5b44 libgdiplus-3.12.tar.gz
package/libgdiplus/libgdiplus.mk new file +56 -0
56 lines not on this page · raw message
Signature · 1 line
1.9.1
PATCH v3 1/1 libgdiplus: new package
Dear Sergio Prado,
Quoted 7 lines · Sergio Prado
Libgdiplus is an open source implementation of the GDI+ API.
Signed-off-by Sergio Prado <[email protected]>---
Changes v2 -> v3:
- removing md5 hash
- adding a comment explaining the source code license
There were a few remaining trailing whitespaces. It would be good if you could tune your text editor configuration so that you can clearly see the trailing whitespaces.
Other than that, I couldn't spot any issue, so I applied. Don't hesitate to monitor http://autobuild.buildroot.org and/or the daily autobuild report e-mails to see if there are any libgdiplus related failures.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH v3 1/1 libgdiplus: new package
Hi Thomas,
2015-12-17 19:29 GMT-02:00 Thomas Petazzoni <
[email protected]>:
Quoted 11 lines
Dear Sergio Prado,
Quoted 7 lines · Sergio Prado
Libgdiplus is an open source implementation of the GDI+ API.
Signed-off-by Sergio Prado <[email protected]>---
Changes v2 -> v3:
- removing md5 hash
- adding a comment explaining the source code license
Quoted 4 lines
There were a few remaining trailing whitespaces. It would be good if you could tune your text editor configuration so that you can clearly see the trailing whitespaces.
OK, I did not notice that. I'll tune my text editor.
Quoted 6 lines
Other than that, I couldn't spot any issue, so I applied. Don't hesitate to monitor http://autobuild.buildroot.org and/or the daily autobuild report e-mails to see if there are any libgdiplus related failures.
OK. I'll do that.
Quoted 3 lines
Thanks!
Thanks!
Quoted 7 lines
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20151217/9978902d/attachment.html>
PATCH v3 1/1 libgdiplus: new package
In reply to Thomas PetazzoniHello,
Quoted 4 lines · Thomas Petazzoni
Other than that, I couldn't spot any issue, so I applied. Don't hesitate to monitor http://autobuild.buildroot.org and/or the daily autobuild report e-mails to see if there are any libgdiplus related failures.
There are some build issues:
http://autobuild.buildroot.org/?reason=libgdiplus-3.12
There is a -L/lib somewhere which is wrong. Could you have a look?
Thanks a lot!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH v3 1/1 libgdiplus: new package
Hi Thomas,
2015-12-18 8:41 GMT-02:00 Thomas Petazzoni <
[email protected]>:
Quoted 9 lines
Hello,
Quoted 4 lines · Thomas Petazzoni
Other than that, I couldn't spot any issue, so I applied. Don't hesitate to monitor http://autobuild.buildroot.org and/or the daily autobuild report e-mails to see if there are any libgdiplus related failures.
Quoted 6 lines
There are some build issues:
http://autobuild.buildroot.org/?reason=libgdiplus-3.12
There is a -L/lib somewhere which is wrong. Could you have a look?
Sure, I'll take a look.
Quoted 9 lines
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20151218/538d764f/attachment.html>
PATCH v3 1/1 libgdiplus: new package
Hello Thomas,
There was an error in the configure script that was not generating ldflags correctly, and the generated Makefile was trying to link with -L/lib. I have sent a patch to fix it, and there is already a patch to fix it upstream.
The reason I did not catch this problem was because the toolchains I used to test generated a warning instead of an error:
Beaglebone with uclibc arm-buildroot-linux-uclibcgnueabihf-gcc: WARNING: unsafe header/library path used in cross-compilation: '/lib'
Qemu x86 with glibc
i686-buildroot-linux-gnu-gcc: WARNING: unsafe header/library path used in
cross-compilation: '/lib'
Why some toolchains generate an error and others a warning in this situation? Is there a configuration to enable this check when generating the toolchain?
Sergio Prado
Embedded Labworks
Office: +55 11 2628-3461
Mobile: +55 11 97123-3420
2015-12-18 8:56 GMT-02:00 Sergio Prado <[email protected]>:
Quoted 14 lines
Hi Thomas,
2015-12-18 8:41 GMT-02:00 Thomas Petazzoni <
thomas.petazzoni at free-electrons.com>:Quoted 9 lines
Hello,
Quoted 4 lines · Thomas Petazzoni
Other than that, I couldn't spot any issue, so I applied. Don't hesitate to monitor http://autobuild.buildroot.org and/or the daily autobuild report e-mails to see if there are any libgdiplus related failures.
Quoted 21 lines
Quoted 6 lines
There are some build issues:
http://autobuild.buildroot.org/?reason=libgdiplus-3.12
There is a -L/lib somewhere which is wrong. Could you have a look?
Sure, I'll take a look.
Quoted 9 lines
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20151218/9489ced7/attachment.html>
PATCH v3 1/1 libgdiplus: new package
Dear Sergio Prado,
Quoted 11 lines · Sergio Prado
Beaglebone with uclibc arm-buildroot-linux-uclibcgnueabihf-gcc: WARNING: unsafe header/library path used in cross-compilation: '/lib'
Qemu x86 with glibc
i686-buildroot-linux-gnu-gcc: WARNING: unsafe header/library path used in
cross-compilation: '/lib'Why some toolchains generate an error and others a warning in this situation? Is there a configuration to enable this check when generating the toolchain?
It is not a matter of toolchain, it is a matter of whether you set the option BR2_COMPILER_PARANOID_UNSAFE_PATH=y or not. By default it's disabled, so those unsafe path messages are just warnings. In the autobuilders, we turn this option on by default, so that just unsafe path messages are treated as errors and abort the build.
This option simply sets an environment variable that makes the toolchain wrapper error out when such unsafe paths are detected.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH v3 1/1 libgdiplus: new package
2015-12-18 17:04 GMT-02:00 Thomas Petazzoni <
[email protected]>:
Quoted 16 lines
Dear Sergio Prado,
Quoted 11 lines · Sergio Prado
Beaglebone with uclibc arm-buildroot-linux-uclibcgnueabihf-gcc: WARNING: unsafe header/library path used in cross-compilation: '/lib'
Qemu x86 with glibc
i686-buildroot-linux-gnu-gcc: WARNING: unsafe header/library path used in
cross-compilation: '/lib'Why some toolchains generate an error and others a warning in this situation? Is there a configuration to enable this check when generating the toolchain?
Quoted 9 lines
It is not a matter of toolchain, it is a matter of whether you set the option BR2_COMPILER_PARANOID_UNSAFE_PATH=y or not. By default it's disabled, so those unsafe path messages are just warnings. In the autobuilders, we turn this option on by default, so that just unsafe path messages are treated as errors and abort the build.
This option simply sets an environment variable that makes the toolchain wrapper error out when such unsafe paths are detected.
Did not know about this option. I will start testing new packages with this option enabled.
Quoted 2 lines
Best regards,
Thanks!
Quoted 7 lines
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20151218/c18d8d08/attachment.html>