assimp: new package

PATCH New Peter Seiderer 2 participants 10 messages Dec 17, 2015 – Jan 11, 2016

lore

Share & tools

lore

Peter Seiderer

author

2015-12-17 22:18 UTC #0 lore raw

PATCH v3 1/2 assimp: new package

Signed-off-by Peter Seiderer <[email protected]>

----
Changes v1 -> v2:
- use github helper (thanks to J?rg Krause)

Changes v2 -> v3:
- add c++ dependency (suggested by Thomas Petazzoni)
- fix linking problem with builtin zlib (linking code with/without '-fpic' compiled, see e.g. [2]), workaround by selecting buildroot zlib package (failure detected by Thomas Petazzoni [2])

[1] https://cmake.org/pipermail/cmake/2006-March/008482.html
[2] http://lists.busybox.net/pipermail/buildroot/2015-December/146859.html

---
 package/Config.in        |  1 +
 package/assimp/Config.in | 14 ++++++++++++++
 package/assimp/assimp.mk | 16 ++++++++++++++++
 3 files changed, 31 insertions(+)
 create mode 100644 package/assimp/Config.in
 create mode 100644 package/assimp/assimp.mk

package/Config.in +1 -0

index bdc3063..b8e13e0 100644
@@ -796,6 +796,7 @@ menu "Filesystem"
 endmenu
 
 menu "Graphics"
+	source "package/assimp/Config.in"
 	source "package/atk/Config.in"
 	source "package/bullet/Config.in"
 	source "package/cairo/Config.in"

package/assimp/Config.in new file +14 -0

new file mode 100644
index 0000000..35e2f23
@@ -0,0 +1,14 @@
+config BR2_PACKAGE_ASSIMP
+	bool "assimp"
+	depends on BR2_INSTALL_LIBSTDCPP
+	select BR2_PACKAGE_ZLIB
+	help
+	  Open Asset Import Library (assimp) is a portable Open Source
+	  library to import various well-known 3D model formats in a uniform
+	  manner. The most recent version also knows how to export 3d files
+	  and is therefore suitable as a general-purpose 3D model converter.
+
+	  http://www.assimp.org
+
+comment "assimp needs a toolchain w/ C++"
+	depends on !BR2_INSTALL_LIBSTDCPP

package/assimp/assimp.mk new file +16 -0

new file mode 100644
index 0000000..fd556e5
@@ -0,0 +1,16 @@
+################################################################################
+#
+# assimp
+#
+################################################################################
+
+ASSIMP_VERSION = v3.2
+ASSIMP_SITE = $(call github,assimp,assimp,$(ASSIMP_VERSION))
+ASSIMP_LICENSE = BSD-3c
+ASSIMP_LICENSE_FILES = LICENSE
+ASSIMP_DEPENDENCIES = zlib
+ASSIMP_INSTALL_STAGING = YES
+
+ASSIMP_CONF_OPTS += -DASSIMP_BUILD_TESTS=OFF
+
+$(eval $(cmake-package))

Signature · 1 line

2.1.4

Peter Seiderer

author

2015-12-17 22:18 UTC #1 lore raw

PATCH v3 2/2 qt53d: enabled assimpsceneparser plugin

- select assimp package
- copy enabled assimpsceneparser plugin

Signed-off-by Peter Seiderer <[email protected]>

---
Depends on '[PATCH v2] qt5/qt53d: new package' (see [1]).

[1] https://patchwork.ozlabs.org/patch/552897

Changes v1 -> v2:
- no changes

Changes v2 -> v3:
- no changes

---
 package/qt5/qt53d/Config.in | 1 +
 package/qt5/qt53d/qt53d.mk  | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

package/qt5/qt53d/Config.in +1 -0

index d350922..6c09358 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_QT53D
 	bool "qt53d"
+	select BR2_PACKAGE_ASSIMP
 	select BR2_PACKAGE_QT5BASE
 	select BR2_PACKAGE_QT5BASE_GUI
 	select BR2_PACKAGE_QT5DECLARATIVE

package/qt5/qt53d/qt53d.mk +2 -1

index 810242b..15d8999 100644
@@ -7,7 +7,7 @@
 QT53D_VERSION = $(QT5_VERSION)
 QT53D_SITE = $(QT5_SITE)
 QT53D_SOURCE = qt3d-opensource-src-$(QT5SVG_VERSION).tar.xz
-QT53D_DEPENDENCIES = qt5base qt5declarative
+QT53D_DEPENDENCIES = assimp qt5base qt5declarative
 QT53D_INSTALL_STAGING = YES
 
 ifeq ($(BR2_PACKAGE_QT5BASE_LICENSE_APPROVED),y)

@@ -34,6 +34,7 @@ endef
 ifeq ($(BR2_STATIC_LIBS),)
 define QT53D_INSTALL_TARGET_CMDS
 	cp -dpf $(STAGING_DIR)/usr/lib/libQt53D*.so.* $(TARGET_DIR)/usr/lib
+	cp -dpfr $(STAGING_DIR)/usr/lib/qt/plugins/sceneparsers $(TARGET_DIR)/usr/lib/qt/plugins
 	cp -dpfr $(STAGING_DIR)/usr/qml/Qt3D $(TARGET_DIR)/usr/qml
 endef
 endif

Signature · 1 line

2.1.4

Thomas Petazzoni

2015-12-17 22:20 UTC #2 lore raw

PATCH v3 2/2 qt53d: enabled assimpsceneparser plugin

Dear Peter Seiderer,

package/qt5/qt53d/Config.in line 3

Quoted 8 lines · Peter Seiderer

package/qt5/qt53d/Config.in +1 -0

index d350922..6c09358 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_QT53D
 	bool "qt53d"
+	select BR2_PACKAGE_ASSIMP

Is it really a mandatory dependency? If so, how could the original qt53d package have been submitted without it?

Thanks,

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Peter Seiderer

author

2015-12-17 22:26 UTC #3 lore raw

PATCH v3 2/2 qt53d: enabled assimpsceneparser plugin

Hello Thomas,

Quoted 4 lines · Thomas Petazzoni

Dear Peter Seiderer,
On Thu, 17 Dec 2015 23:18:19 +0100, Peter Seiderer wrote:

Quoted 11 lines

package/qt5/qt53d/Config.in line 3
Quoted 8 lines
package/qt5/qt53d/Config.in +1 -0
index d350922..6c09358 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_QT53D
 	bool "qt53d"
+	select BR2_PACKAGE_ASSIMP
Is it really a mandatory dependency? If so, how could the original qt53d package have been submitted without it?

O.k, you are right, will send an updated patch...

Quoted 4 lines

Thanks,
Thomas

Thomas Petazzoni

2015-12-28 22:01 UTC #4 lore raw

PATCH v3 2/2 qt53d: enabled assimpsceneparser plugin

Peter,

Quoted 6 lines · Peter Seiderer

Quoted 4 lines
package/qt5/qt53d/Config.in line 3
Quoted 1 line
package/qt5/qt53d/Config.in +1 -0
+	select BR2_PACKAGE_ASSIMP
Is it really a mandatory dependency? If so, how could the original qt53d package have been submitted without it?
O.k, you are right, will send an updated patch...

Unless I missed it, you did not send an updated patch?

Thanks!

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Peter Seiderer

author

2016-01-11 21:55 UTC #5 lore raw

PATCH v3 2/2 qt53d: enabled assimpsceneparser plugin

Hello Thomas,

Quoted 4 lines · Thomas Petazzoni

Peter,
On Thu, 17 Dec 2015 23:26:49 +0100, Peter Seiderer wrote:

Quoted 8 lines

Quoted 6 lines
Quoted 4 lines
package/qt5/qt53d/Config.in line 3
Quoted 1 line
package/qt5/qt53d/Config.in +1 -0
+	select BR2_PACKAGE_ASSIMP
Is it really a mandatory dependency? If so, how could the original qt53d package have been submitted without it?
O.k, you are right, will send an updated patch...
Unless I missed it, you did not send an updated patch?

Did not have much time for buildroot stuff the last couple of weeks..., so no updated patch yet..., but I hope I find some more time in a week or two...

Regards,
Peter

Quoted 4 lines

Thanks!
Thomas

Thomas Petazzoni

2015-12-28 22:00 UTC #6 lore raw

PATCH v3 1/2 assimp: new package

In reply to Peter Seiderer

Peter,

Quoted 5 lines · Peter Seiderer

Signed-off-by Peter Seiderer <[email protected]>
----
Changes v1 -> v2:
- use github helper (thanks to J?rg Krause)

Quoted 8 lines

Changes v2 -> v3:
- add c++ dependency (suggested by Thomas Petazzoni)
- fix linking problem with builtin zlib (linking code with/without '-fpic' compiled, see e.g. [2]), workaround by selecting buildroot zlib package (failure detected by Thomas Petazzoni [2])
[1] https://cmake.org/pipermail/cmake/2006-March/008482.html
[2] http://lists.busybox.net/pipermail/buildroot/2015-December/146859.html

Thanks, I've applied. This time, I didn't do another test build, so I'm leaving it to the autobuilders to test your package. Please monitor autobuild.buildroot.org for any failure related to your package in the coming hours/days.

Thanks!

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Thomas Petazzoni

2015-12-30 16:05 UTC #7 lore raw

PATCH v3 1/2 assimp: new package

In reply to Peter Seiderer

Dear Peter Seiderer,

Quoted 4 lines · Peter Seiderer

Signed-off-by Peter Seiderer <[email protected]>
----
Changes v1 -> v2:
- use github helper (thanks to J?rg Krause)

This package is causing some build failures:

http://autobuild.buildroot.org/?reason=assimp-v3.2

They all look similar. I guess it's because assimp needs C++11 support. Can you have a look ?

Thanks,

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Thomas Petazzoni

2015-12-30 22:02 UTC #8 lore raw

PATCH v3 1/2 assimp: new package

Hello,

Quoted 6 lines · Thomas Petazzoni

This package is causing some build failures:
http://autobuild.buildroot.org/?reason=assimp-v3.2
They all look similar. I guess it's because assimp needs C++11 support. Can you have a look ?

One of the issue is different though:

http://autobuild.buildroot.org/results/79e/79edc3a8c7bcc5a7ffb433bf1ecb645050e2f044/build-end.log

Thanks for your feedback,

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Peter Seiderer

author

2016-01-11 21:56 UTC #9 lore raw

PATCH v3 1/2 assimp: new package

In reply to Thomas Petazzoni

Hello Thomas,

Quoted 8 lines · Thomas Petazzoni

Dear Peter Seiderer,
Quoted 4 lines · Peter Seiderer
Signed-off-by Peter Seiderer <[email protected]>
----
Changes v1 -> v2:
- use github helper (thanks to J?rg Krause)

Quoted 6 lines

This package is causing some build failures:
http://autobuild.buildroot.org/?reason=assimp-v3.2
They all look similar. I guess it's because assimp needs C++11 support. Can you have a look ?

O.k, will have a look at it...

Regards,
Peter

Quoted 4 lines

Thanks,
Thomas