Skip to contentSkip to conversation

arm: socfpga: Fix emac1 doesn't work on socdk board

PATCH New 圣江 吴 3 participants 3 messages Dec 18, 2015

lore
Share & tools
lore

圣江 吴

author
#0 lore raw

PATCH v2 1/1 arm: socfpga: Fix emac1 doesn't work on socdk board

On Dec 18, 2015, at 12:46 AM, Chin Liang See <[email protected]> wrote:

Hi Shengjiang,

On Fri, 2015-12-18 at 16:43 +0800, shengjiangwu wrote:
Updated pinmux group MIXED1IO[0-13] for RGMII1. Updated EMAC1 clock.

Signed-off-by shengjiangwu <[email protected]>
Cc Chin Liang See <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Pavel Machek <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Stefan Roese <[email protected]>

---
Changes for v2:
- fixed wrong perpll for emac1
---
board/altera/cyclone5-socdk/qts/pll_config.h | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/board/altera/cyclone5-socdk/qts/pll_config.h
index eccc705..5b754ac 100644

board/altera/cyclone5-socdk/qts/pll_config.h +0 -0
@@ -65,7 +65,7 @@

#define CONFIG_HPS_CLK_PERVCO_HZ 1000000000
#define CONFIG_HPS_CLK_SDRVCO_HZ 666666666
#define CONFIG_HPS_CLK_EMAC0_HZ 250000000
-#define CONFIG_HPS_CLK_EMAC1_HZ 50000000
+#define CONFIG_HPS_CLK_EMAC1_HZ 250000000

This is good. But I believe you miss the pinmux change here. You just need to take the previous patch and made the change.

Thanks
Chin Liang

Sorry for not?familiar?with re-patch?process.?
Best Regards
Shengjiangwu

#define CONFIG_HPS_CLK_USBCLK_HZ 200000000
#define CONFIG_HPS_CLK_NAND_HZ 50000000
#define CONFIG_HPS_CLK_SDMMC_HZ 200000000

#1 lore raw

PATCH v2 1/1 arm: socfpga: Fix emac1 doesn't work on socdk board

Quoted 39 lines · ?? ?
Quoted 34 lines · Chin Liang See

Hi Shengjiang,

Quoted 21 lines · shengjiangwu

Updated pinmux group MIXED1IO[0-13] for RGMII1.
Updated EMAC1 clock.

Signed-off-by shengjiangwu <[email protected]>
Cc Chin Liang See <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Pavel Machek <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Stefan Roese <[email protected]>

---
Changes for v2:
- fixed wrong perpll for emac1
---
board/altera/cyclone5-socdk/qts/pll_config.h | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
board/altera/cyclone5-socdk/qts/pll_config.h +0 -0
index eccc705..5b754ac 100644

board/altera/cyclone5-socdk/qts/pll_config.h line 68

Quoted 5 lines
board/altera/cyclone5-socdk/qts/pll_config.h +1 -1
@@ -65,7 +65,7 @@
 #define CONFIG_HPS_CLK_PERVCO_HZ 1000000000
 #define CONFIG_HPS_CLK_SDRVCO_HZ 666666666
 #define CONFIG_HPS_CLK_EMAC0_HZ 250000000
-#define CONFIG_HPS_CLK_EMAC1_HZ 50000000
+#define CONFIG_HPS_CLK_EMAC1_HZ 250000000

This is good. But I believe you miss the pinmux change here. You just
need to take the previous patch and made the change.

Quoted 3 lines
Quoted 2 lines

Thanks
Chin Liang

Sorry for not familiar with re-patch process.

No worries as you are almost there.

Thanks
Chin Liang

Quoted 7 lines

Best Regards
Shengjiangwu

Quoted 5 lines
Quoted 5 lines
board/altera/cyclone5-socdk/qts/pll_config.h +0 -0
 #define CONFIG_HPS_CLK_USBCLK_HZ 200000000
 #define CONFIG_HPS_CLK_NAND_HZ 50000000
 #define CONFIG_HPS_CLK_SDMMC_HZ 200000000
#2 lore raw

PATCH v2 1/1 arm: socfpga: Fix emac1 doesn't work on socdk board

In reply to 圣江 吴
Quoted 38 lines · ?? ?

On Dec 18, 2015, at 12:46 AM, Chin Liang See <[email protected]> wrote:

Hi Shengjiang,

On Fri, 2015-12-18 at 16:43 +0800, shengjiangwu wrote:
Updated pinmux group MIXED1IO[0-13] for RGMII1. Updated EMAC1 clock.

Signed-off-by shengjiangwu <[email protected]>
Cc Chin Liang See <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Pavel Machek <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Stefan Roese <[email protected]>

---
Changes for v2:
- fixed wrong perpll for emac1
---
board/altera/cyclone5-socdk/qts/pll_config.h | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
board/altera/cyclone5-socdk/qts/pll_config.h +1 -1
index eccc705..5b754ac 100644
@@ -65,7 +65,7 @@
 #define CONFIG_HPS_CLK_PERVCO_HZ 1000000000
 #define CONFIG_HPS_CLK_SDRVCO_HZ 666666666
 #define CONFIG_HPS_CLK_EMAC0_HZ 250000000
-#define CONFIG_HPS_CLK_EMAC1_HZ 50000000
+#define CONFIG_HPS_CLK_EMAC1_HZ 250000000

This is good. But I believe you miss the pinmux change here. You just need to take the previous patch and made the change.

Quoted 4 lines

Thanks
Chin Liang

Sorry for not familiar with re-patch process.

Take a look at 'git rebase -i' and 'git commit --amend' and at the 'tig' command and then probably 'patchman' in the U-Boot source tree. These might be helpful.

Best regards,
Marek Vasut