emlog: new package
PATCH 1/1 emlog: new package
Signed-off-by Joris Lijssens <[email protected]>
--- package/Config.in | 1 + package/emlog/Config.in | 12 ++++++++++++ package/emlog/emlog.hash | 2 ++ package/emlog/emlog.mk | 21 +++++++++++++++++++++ 4 files changed, 36 insertions(+) create mode 100644 package/emlog/Config.in create mode 100644 package/emlog/emlog.hash create mode 100644 package/emlog/emlog.mk
package/Config.in +1 -0
@@ -1515,6 +1515,7 @@ if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS source "package/debianutils/Config.in" endif source "package/dsp-tools/Config.in" + source "package/emlog/Config.in" source "package/ftop/Config.in" source "package/getent/Config.in" source "package/htop/Config.in"
package/emlog/Config.in new file +12 -0
@@ -0,0 +1,12 @@ +config BR2_PACKAGE_EMLOG + bool "emlog" + help + emlog is a Linux kernel module that makes it easy to access the most + recent (and only the most recent) output from a process. It works + just like "tail -f" on a log file, except that the storage required + never grows. This can be useful in embedded systems where there isn't + enough memory or disk space for keeping complete log files, but the + most recent debugging messages are sometimes needed (e.g., after an + error is observed). + + https://github.com/nicupavel/emlog
package/emlog/emlog.hash new file +2 -0
@@ -0,0 +1,2 @@ +# Locally calculated +sha256 37b03b79684245ddcb33cfff388a7f2d74f465f2e1fce4f661b81726f5ccd595 emlog-0.52.tar.gz
package/emlog/emlog.mk new file +21 -0
@@ -0,0 +1,21 @@ +################################################################################ +# +# emlog +# +################################################################################ + +EMLOG_VERSION = 0.52 +EMLOG_SITE = $(call github,nicupavel,emlog,emlog-$(EMLOG_VERSION)) +EMLOG_LICENSE = GPLv2 +EMLOG_LICENSE_FILES = COPYING + +define EMLOG_BUILD_CMDS + $(MAKE) CC="$(TARGET_CC)" CFLAGS="$(TARGET_CFLAGS)" -C $(@D) nbcat +endef + +define EMLOG_INSTALL_TARGET_CMDS + $(INSTALL) -m 0755 $(@D)/nbcat $(TARGET_DIR)/usr/bin +endef + +$(eval $(kernel-module)) +$(eval $(generic-package))
Signature · 1 line
1.8.3.1
PATCH 1/1 emlog: new package
Joris,
Quoted 10 lines · Joris Lijssens
Signed-off-by Joris Lijssens <[email protected]>--- package/Config.in | 1 + package/emlog/Config.in | 12 ++++++++++++ package/emlog/emlog.hash | 2 ++ package/emlog/emlog.mk | 21 +++++++++++++++++++++ 4 files changed, 36 insertions(+) create mode 100644 package/emlog/Config.in create mode 100644 package/emlog/emlog.hash create mode 100644 package/emlog/emlog.mk
I guess this is a new version of the emlog patch, right?
If so, a new iteration should be labeled as "PATCH v2" and should carry a changelog. See
https://buildroot.org/downloads/manual/manual.html#submitting-patches.
This helps us a lot to understand what has changed between the different iterations of a patch.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/1 emlog: new package
In reply to Joris LijssensQuoted 58 lines · Joris Lijssens
Signed-off-by Joris Lijssens <[email protected]>--- package/Config.in | 1 + package/emlog/Config.in | 12 ++++++++++++ package/emlog/emlog.hash | 2 ++ package/emlog/emlog.mk | 21 +++++++++++++++++++++ 4 files changed, 36 insertions(+) create mode 100644 package/emlog/Config.in create mode 100644 package/emlog/emlog.hash create mode 100644 package/emlog/emlog.mkpackage/Config.in +1
-0@@ -1515,6 +1515,7 @@ if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS source "package/debianutils/Config.in" endif source "package/dsp-tools/Config.in" + source "package/emlog/Config.in" source "package/ftop/Config.in" source "package/getent/Config.in" source "package/htop/Config.in"package/emlog/Config.in new file +12
-0@@ -0,0 +1,12 @@ +config BR2_PACKAGE_EMLOG + bool "emlog" + help + emlog is a Linux kernel module that makes it easy to access the most + recent (and only the most recent) output from a process. It works + just like "tail -f" on a log file, except that the storage required + never grows. This can be useful in embedded systems where there isn't + enough memory or disk space for keeping complete log files, but the + most recent debugging messages are sometimes needed (e.g., after an + error is observed). + + https://github.com/nicupavel/emlogpackage/emlog/emlog.hash new file +2
-0@@ -0,0 +1,2 @@ +# Locally calculated +sha256 37b03b79684245ddcb33cfff388a7f2d74f465f2e1fce4f661b81726f5ccd595 emlog-0.52.tar.gzpackage/emlog/emlog.mk new file +3
-0@@ -0,0 +1,21 @@ +################################################################################ +# +# emlog
package/emlog/emlog.mk line 13
Quoted 10 lines
package/emlog/emlog.mk new file +10
-0+# +################################################################################ + +EMLOG_VERSION = 0.52 +EMLOG_SITE = $(call github,nicupavel,emlog,emlog-$(EMLOG_VERSION)) +EMLOG_LICENSE = GPLv2 +EMLOG_LICENSE_FILES = COPYING + +define EMLOG_BUILD_CMDS + $(MAKE) CC="$(TARGET_CC)" CFLAGS="$(TARGET_CFLAGS)" -C $(@D) nbcat
Doesn't $(TARGET_CONFIGURE_OPTS) work here? If not, it's better to explain that
in the commit message.
package/emlog/emlog.mk line 17
Quoted 4 lines
package/emlog/emlog.mk new file +4
-0+endef + +define EMLOG_INSTALL_TARGET_CMDS + $(INSTALL) -m 0755 $(@D)/nbcat $(TARGET_DIR)/usr/bin
Also here a comment would be good:
# make install tries to strip, so install manually.
Otherwise, looks good to me, so you can add my
Regards,
Arnout
Quoted 5 lines
package/emlog/emlog.mk new file +4
-0+endef + +$(eval $(kernel-module)) +$(eval $(generic-package))
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
PATCH 1/1 emlog: new package
In reply to Joris LijssensJoris,
Quoted 8 lines · Joris Lijssens
package/emlog/Config.in new file +2
-0@@ -0,0 +1,12 @@ +config BR2_PACKAGE_EMLOG + bool "emlog"
package/emlog/Config.in line 12
Quoted 10 lines
package/emlog/Config.in new file +10
-0+ help + emlog is a Linux kernel module that makes it easy to access the most + recent (and only the most recent) output from a process. It works + just like "tail -f" on a log file, except that the storage required + never grows. This can be useful in embedded systems where there isn't + enough memory or disk space for keeping complete log files, but the + most recent debugging messages are sometimes needed (e.g., after an + error is observed). + + https://github.com/nicupavel/emlog
I did not spot this during the previous review, and Arnout also didn't spot it apparently, so maybe I'm missing something.
emlog is a kernel module, so surely it needs the Linux kernel to be built beforehand. So your package should "depends on BR2_LINUX_KERNEL" and have "linux" in EMLOG_DEPENDENCIES. Otherwise, I don't see how it can even build.
Could you look into this, as well as the comments from Arnout, and resend an updated version of your patch?
Thanks a lot!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com