python-pyxml: remove obsolete package

PATCH New yegorslists at googlemail.com 3 participants 6 messages Dec 16, 2015 – Dec 18, 2015

lore

Share & tools

lore

yegorslists at googlemail.com

author

2015-12-16 07:44 UTC #0 lore raw

PATCH 1/1 python-pyxml: remove obsolete package

From: Yegor Yefremov <[email protected]>

PyXML is bitrotten and obsolete. You'll find the functionality it previously provided is now included in the Python standard library.

So no need to keep this package in Buildroot anymore.

Signed-off-by Yegor Yefremov <[email protected]>

---
 package/Config.in                      |  1 -
 package/python-pyxml/Config.in         | 12 ------------
 package/python-pyxml/python-pyxml.hash |  2 --
 package/python-pyxml/python-pyxml.mk   | 17 -----------------
 4 files changed, 32 deletions(-)
 delete mode 100644 package/python-pyxml/Config.in
 delete mode 100644 package/python-pyxml/python-pyxml.hash
 delete mode 100644 package/python-pyxml/python-pyxml.mk

package/Config.in +0 -1

index d31b503..d2476f7 100644
@@ -666,7 +666,6 @@ menu "External python modules"
 	source "package/python-pyudev/Config.in"
 	source "package/python-pyusb/Config.in"
 	source "package/python-pyxb/Config.in"
-	source "package/python-pyxml/Config.in"
 	source "package/python-pyyaml/Config.in"
 	source "package/python-pyzmq/Config.in"
 	source "package/python-requests/Config.in"

package/python-pyxml/Config.in deleted +0 ~~-12~~

deleted file mode 100644
index 82316ba..0000000
@@ -1,12 +0,0 @@
-config BR2_PACKAGE_PYTHON_PYXML
-	bool "python-pyxml"
-	depends on BR2_PACKAGE_PYTHON
-	select BR2_PACKAGE_EXPAT
-	help
-	  This is the Python XML package. The distribution contains a
-	  validating XML parser, an implementation of the SAX and DOM
-	  programming interfaces, an interface to the Expat parser (and the
-	  Expat parser itself), and a C helper module that can speed up
-	  xmllib.py by a factor of 5. There's even documentation!
-
-	  http://pyxml.sourceforge.net/topics/index.html

package/python-pyxml/python-pyxml.hash deleted +0 -2

deleted file mode 100644
index df98c46..0000000
@@ -1,2 +0,0 @@
-# Locally computed
-sha256 9fab66f9584fb8e67aebd8745a5c97bf1c5a2e2e461adf68862bcec64e448c13  PyXML-0.8.4.tar.gz

package/python-pyxml/python-pyxml.mk deleted +0 ~~-17~~

deleted file mode 100644
index 7ccce8e..0000000
@@ -1,17 +0,0 @@
-################################################################################
-#
-# python-pyxml
-#
-################################################################################
-
-PYTHON_PYXML_VERSION = 0.8.4
-PYTHON_PYXML_SOURCE = PyXML-$(PYTHON_PYXML_VERSION).tar.gz
-PYTHON_PYXML_SITE = http://downloads.sourceforge.net/project/pyxml/pyxml/$(PYTHON_PYXML_VERSION)
-PYTHON_PYXML_LICENSE = BSD-3c
-PYTHON_PYXML_LICENSE_FILES = LICENCE
-PYTHON_PYXML_SETUP_TYPE = distutils
-PYTHON_PYXML_DEPENDENCIES = expat
-PYTHON_PYXML_BUILD_OPTS = --with-libexpat=$(STAGING_DIR)/usr
-PYTHON_PYXML_INSTALL_TARGET_OPTS = --with-libexpat=$(STAGING_DIR)/usr
-
-$(eval $(python-package))

Signature · 1 line

2.1.4

Yann E. MORIN

2015-12-16 08:32 UTC #1 lore raw

PATCH 1/1 python-pyxml: remove obsolete package

Yegor, All,

On 2015-12-16 08:44 +0100, yegorslists at googlemail.com spake thusly:

Quoted 6 lines

From: Yegor Yefremov <[email protected]>
PyXML is bitrotten and obsolete. You'll find the functionality it previously provided is now included in the Python standard library.
So no need to keep this package in Buildroot anymore.

You forgot to add it to Config.in.legacy .

Otherwise OK for me.

Regards,
Yann E. MORIN.

Quoted 75 lines

Signed-off-by Yegor Yefremov <[email protected]>

---
 package/Config.in                      |  1 -
 package/python-pyxml/Config.in         | 12 ------------
 package/python-pyxml/python-pyxml.hash |  2 --
 package/python-pyxml/python-pyxml.mk   | 17 -----------------
 4 files changed, 32 deletions(-)
 delete mode 100644 package/python-pyxml/Config.in
 delete mode 100644 package/python-pyxml/python-pyxml.hash
 delete mode 100644 package/python-pyxml/python-pyxml.mk

package/Config.in +0 -1

index d31b503..d2476f7 100644
@@ -666,7 +666,6 @@ menu "External python modules"
 	source "package/python-pyudev/Config.in"
 	source "package/python-pyusb/Config.in"
 	source "package/python-pyxb/Config.in"
-	source "package/python-pyxml/Config.in"
 	source "package/python-pyyaml/Config.in"
 	source "package/python-pyzmq/Config.in"
 	source "package/python-requests/Config.in"

package/python-pyxml/Config.in deleted +0 ~~-12~~

deleted file mode 100644
index 82316ba..0000000
@@ -1,12 +0,0 @@
-config BR2_PACKAGE_PYTHON_PYXML
-	bool "python-pyxml"
-	depends on BR2_PACKAGE_PYTHON
-	select BR2_PACKAGE_EXPAT
-	help
-	  This is the Python XML package. The distribution contains a
-	  validating XML parser, an implementation of the SAX and DOM
-	  programming interfaces, an interface to the Expat parser (and the
-	  Expat parser itself), and a C helper module that can speed up
-	  xmllib.py by a factor of 5. There's even documentation!
-
-	  http://pyxml.sourceforge.net/topics/index.html

package/python-pyxml/python-pyxml.hash deleted +0 -2

deleted file mode 100644
index df98c46..0000000
@@ -1,2 +0,0 @@
-# Locally computed
-sha256 9fab66f9584fb8e67aebd8745a5c97bf1c5a2e2e461adf68862bcec64e448c13  PyXML-0.8.4.tar.gz

package/python-pyxml/python-pyxml.mk deleted +0 ~~-17~~

deleted file mode 100644
index 7ccce8e..0000000
@@ -1,17 +0,0 @@
-################################################################################
-#
-# python-pyxml
-#
-################################################################################
-
-PYTHON_PYXML_VERSION = 0.8.4
-PYTHON_PYXML_SOURCE = PyXML-$(PYTHON_PYXML_VERSION).tar.gz
-PYTHON_PYXML_SITE = http://downloads.sourceforge.net/project/pyxml/pyxml/$(PYTHON_PYXML_VERSION)
-PYTHON_PYXML_LICENSE = BSD-3c
-PYTHON_PYXML_LICENSE_FILES = LICENCE
-PYTHON_PYXML_SETUP_TYPE = distutils
-PYTHON_PYXML_DEPENDENCIES = expat
-PYTHON_PYXML_BUILD_OPTS = --with-libexpat=$(STAGING_DIR)/usr
-PYTHON_PYXML_INSTALL_TARGET_OPTS = --with-libexpat=$(STAGING_DIR)/usr
-
-$(eval $(python-package))

Signature · 1 line

2.1.4

Signature · 6 lines

.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

Thomas Petazzoni

2015-12-18 21:28 UTC #2 lore raw

PATCH 1/1 python-pyxml: remove obsolete package

In reply to yegorslists at googlemail.com

Hello,

Quoted 8 lines · yegorslists at googlemail.com

From: Yegor Yefremov <[email protected]>
PyXML is bitrotten and obsolete. You'll find the functionality it previously provided is now included in the Python standard library.
So no need to keep this package in Buildroot anymore.
Signed-off-by Yegor Yefremov <[email protected]>

Quoted 9 lines

---
 package/Config.in                      |  1 -
 package/python-pyxml/Config.in         | 12 ------------
 package/python-pyxml/python-pyxml.hash |  2 --
 package/python-pyxml/python-pyxml.mk   | 17 -----------------
 4 files changed, 32 deletions(-)
 delete mode 100644 package/python-pyxml/Config.in
 delete mode 100644 package/python-pyxml/python-pyxml.hash
 delete mode 100644 package/python-pyxml/python-pyxml.mk

As Yann said, can you respin this patch after taking care of Config.in.legacy handling ?

Or maybe instead of removing the package we should mark it as deprecated ?

Thanks,

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Yann E. MORIN

2015-12-18 21:40 UTC #3 lore raw

PATCH 1/1 python-pyxml: remove obsolete package

Thomas, All,

On 2015-12-18 22:28 +0100, Thomas Petazzoni spake thusly:

Quoted 19 lines · yegorslists at googlemail.com

Quoted 8 lines
From: Yegor Yefremov <[email protected]>
PyXML is bitrotten and obsolete. You'll find the functionality it previously provided is now included in the Python standard library.
So no need to keep this package in Buildroot anymore.
Signed-off-by Yegor Yefremov <[email protected]>
Quoted 9 lines
---
 package/Config.in                      |  1 -
 package/python-pyxml/Config.in         | 12 ------------
 package/python-pyxml/python-pyxml.hash |  2 --
 package/python-pyxml/python-pyxml.mk   | 17 -----------------
 4 files changed, 32 deletions(-)
 delete mode 100644 package/python-pyxml/Config.in
 delete mode 100644 package/python-pyxml/python-pyxml.hash
 delete mode 100644 package/python-pyxml/python-pyxml.mk

Quoted 5 lines

As Yann said, can you respin this patch after taking care of Config.in.legacy handling ?
Or maybe instead of removing the package we should mark it as deprecated ?

I usually agree that we first mark package as being deprecated before we get rid of them.

However, python-pyxml is so old, its features have long been incoporated into python stdlib. Probably not many people are using it, if any at all.

So, I'd vote in favour of just removing it altogether right now.

Regards,
Yann E. MORIN.

Signature · 6 lines

.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

Thomas Petazzoni

2015-12-18 21:45 UTC #4 lore raw

PATCH 1/1 python-pyxml: remove obsolete package

Hello,

Quoted 8 lines · Yann E. MORIN

I usually agree that we first mark package as being deprecated before we get rid of them.
However, python-pyxml is so old, its features have long been incoporated into python stdlib. Probably not many people are using it, if any at all.
So, I'd vote in favour of just removing it altogether right now.

Fine with me. Yegor, can you respin your patch then with Config.in.legacy handling?

It would have been good to hear from Clayton to know why he added this package in May 2015. I think it might have been at some point a dependency of some SELinux stuff, but even the pending SELinux patches don't make any reference to it. The only reference I could find was in the changelog of one of the patches, which says:

"""
- Remove dependancy on host-python-pyxml (Ryan B.)
"""

But the current python-pyxml package only implements the target variant. So, /me confused.

Clayton, Ryan?

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Yegor Yefremov

author

2015-12-18 22:31 UTC #5 lore raw

PATCH 1/1 python-pyxml: remove obsolete package

Quoted 7 lines · Thomas Petazzoni

Hello,
Quoted 3 lines · Yann E. MORIN
I usually agree that we first mark package as being deprecated before we get rid of them.

Quoted 8 lines

Quoted 5 lines
However, python-pyxml is so old, its features have long been incoporated into python stdlib. Probably not many people are using it, if any at all.
So, I'd vote in favour of just removing it altogether right now.
Fine with me. Yegor, can you respin your patch then with Config.in.legacy handling?

I'll respin the patch.

Quoted 21 lines

It would have been good to hear from Clayton to know why he added this package in May 2015. I think it might have been at some point a dependency of some SELinux stuff, but even the pending SELinux patches don't make any reference to it. The only reference I could find was in the changelog of one of the patches, which says:
"""
- Remove dependancy on host-python-pyxml (Ryan B.)
"""
But the current python-pyxml package only implements the target variant. So, /me confused.
Clayton, Ryan?
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com