Skip to contentSkip to conversation

serial: atmel: remove module device table

PATCH In review Arnd Bergmann 2 participants 2 messages Dec 18, 2015 – Dec 20, 2015

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 serial: atmel: remove module device table

A recent patch removed most of the module-specific code from the atmel serial driver, but left the MODULE_DEVICE_TABLE in place, so we can't build it any more:

drivers/tty/serial/atmel_serial.c:192:1: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Werror=implicit-int] drivers/tty/serial/atmel_serial.c:192:1: warning: parameter names (without types) in function declaration

This removes the table as well to avoid the error.

Fixes c39dfebc7798 ("drivers/tty/serial: make serial/atmel_serial.c explicitly non-modular")
drivers/tty/serial/atmel_serial.c +0 -2
index 50e785a0ea73..1c0884d8ef32 100644
@@ -188,8 +188,6 @@ static const struct of_device_id atmel_serial_dt_ids[] = {
 	{ .compatible = "atmel,at91sam9260-usart" },
 	{ /* sentinel */ }
 };
-
-MODULE_DEVICE_TABLE(of, atmel_serial_dt_ids);
 #endif
 
 static inline struct atmel_uart_port *
#1 lore raw
Quoted 8 lines · [[PATCH] serial: atmel: remove module device table] On 18/12/2015 (Fri 15:49)…

A recent patch removed most of the module-specific code from the atmel serial driver, but left the MODULE_DEVICE_TABLE in place, so we can't build it any more:

drivers/tty/serial/atmel_serial.c:192:1: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Werror=implicit-int] drivers/tty/serial/atmel_serial.c:192:1: warning: parameter names (without types) in function declaration

This removes the table as well to avoid the error.

I sent the same fix on Thursday. Again, sorry that my testing did not uncover this earlier. I was build testing for ARM on almost a daily basis but not so regularly for MIPS.

http://lkml.kernel.org/r/1450364746-815-1-git-send-email-paul.gortmaker at windriver.com

Paul.
--

Quoted 18 lines
Fixes c39dfebc7798 ("drivers/tty/serial: make serial/atmel_serial.c explicitly non-modular")
drivers/tty/serial/atmel_serial.c +0 -2
index 50e785a0ea73..1c0884d8ef32 100644
@@ -188,8 +188,6 @@ static const struct of_device_id atmel_serial_dt_ids[] = {
 	{ .compatible = "atmel,at91sam9260-usart" },
 	{ /* sentinel */ }
 };
-
-MODULE_DEVICE_TABLE(of, atmel_serial_dt_ids);
 #endif
 
 static inline struct atmel_uart_port *