Skip to contentSkip to conversation

package/nut: disable libltdl (and nut-scanner) for static-only

PATCH New Yann E. MORIN 2 participants 2 messages Dec 19, 2015 – Dec 20, 2015

lore
Share & tools
lore

Yann E. MORIN

author
#0 lore raw

PATCH 1/1 package/nut: disable libltdl (and nut-scanner) for static-only

nut-scanner needs libltdl, a wrapper around dlopen/dlsym. This does not really make sense on a static-only build.

Disable use of libltdl in static-only builds; this disble nut-scanner.

Fixes:

    http://autobuild.buildroot.org/results/d8e/d8e769709681b1965f36eb5c27f71f3a1f5adcf1/
    http://autobuild.buildroot.org/results/6e4/6e403642069093389acbeeccd7030b76d4ab68be/
    http://autobuild.buildroot.org/results/fa4/fa4c647ce58b91b863d8de5bf9d44b2060a1cf1c/
    and so many others...
Signed-off-by "Yann E. MORIN" <[email protected]>
---
 package/nut/nut.mk | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
package/nut/nut.mk +5 -2
index d5babee..b0a92ca 100644
@@ -50,8 +50,11 @@ else
 NUT_CONF_OPTS += --without-cgi
 endif
 
-# libltdl (libtool) is needed for nut-scanner
-ifeq ($(BR2_PACKAGE_LIBTOOL),y)
+# nut-scanner needs libltdl, which is a wrapper arounf dlopen/dlsym,
+# so is not available for static-only builds.
+# There is no flag to directly enable/disable nut-scanner, it's done
+# via the --enable/disable-libltdl flag.
+ifeq ($(BR2_STATIC_LIBS):$(BR2_PACKAGE_LIBTOOL),:y)
 NUT_DEPENDENCIES += libtool
 NUT_CONF_OPTS += --with-libltdl
 else
Signature · 1 line
1.9.1
Applied
#1 lore raw

PATCH 1/1 package/nut: disable libltdl (and nut-scanner) for static-only

Dear Yann E. MORIN,

Quoted 11 lines · Yann E. MORIN

nut-scanner needs libltdl, a wrapper around dlopen/dlsym. This does not really make sense on a static-only build.

Disable use of libltdl in static-only builds; this disble nut-scanner.

Fixes:

    http://autobuild.buildroot.org/results/d8e/d8e769709681b1965f36eb5c27f71f3a1f5adcf1/
    http://autobuild.buildroot.org/results/6e4/6e403642069093389acbeeccd7030b76d4ab68be/
    http://autobuild.buildroot.org/results/fa4/fa4c647ce58b91b863d8de5bf9d44b2060a1cf1c/
    and so many others...
Quoted 4 lines
Signed-off-by "Yann E. MORIN" <[email protected]>
---
 package/nut/nut.mk | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com