Skip to contentSkip to conversation

ARM: dts: imx7d: add arch timer

PATCH New Frank.Li at freescale.com 4 participants 7 messages Dec 10, 2015 – Dec 21, 2015

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/3 ARM: dts: imx7d: add arch timer

From: Frank Li <[email protected]>

add cortex a7 arch timer.
uboot v2016.01-rc2 supported psci basic support.
smp can be supported by psci

---
 arch/arm/boot/dts/imx7d.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)
arch/arm/boot/dts/imx7d.dtsi +9 -0
index 489604a..a621af6 100644
@@ -119,6 +119,15 @@
 		clock-output-names = "osc";
 	};
 
+	timer {
+		compatible = "arm,armv7-timer";
+		interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
+			     <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
+			     <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
+			     <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>;
+		interrupt-parent = <&intc>;
+	};
+
 	etr at 30086000 {
 		compatible = "arm,coresight-tmc", "arm,primecell";
 		reg = <0x30086000 0x1000>;
Signature · 1 line
2.5.2
#1 lore raw

PATCH 2/3 ARM: imx: select HAVE_ARM_ARCH_TIMER if selected i.MX7D

From: Frank Li <[email protected]>

i.MX7D Supported ARCH Timer.

---
 arch/arm/mach-imx/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-imx/Kconfig +1 -0
index 0ac180f..061dea4 100644
@@ -563,6 +563,7 @@ config SOC_IMX7D
 	select ARM_GIC
 	select HAVE_IMX_ANATOP
 	select HAVE_IMX_MMDC
+	select HAVE_ARM_ARCH_TIMER
 	help
 		This enables support for Freescale i.MX7 Dual processor.
 
Signature · 1 line
2.5.2
#2 lore raw

PATCH 2/3 ARM: imx: select HAVE_ARM_ARCH_TIMER if selected i.MX7D

Quoted 14 lines · Frank.Li at freescale.com

From: Frank Li <[email protected]>

i.MX7D Supported ARCH Timer.

---
 arch/arm/mach-imx/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-imx/Kconfig +0 -0
index 0ac180f..061dea4 100644

arch/arm/mach-imx/Kconfig config SOC_IMX7D · line 566

Quoted 4 lines
arch/arm/mach-imx/Kconfig +1 -0
@@ -563,6 +563,7 @@ config SOC_IMX7D
 	select ARM_GIC
 	select HAVE_IMX_ANATOP
 	select HAVE_IMX_MMDC
+	select HAVE_ARM_ARCH_TIMER

Please sort these selections alphabetically.

Shawn

Quoted 12 lines
arch/arm/mach-imx/Kconfig +0 -0
 	help
 		This enables support for Freescale i.MX7 Dual processor.
 
Signature · 7 lines
2.5.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#3 lore raw

PATCH 3/3 arm: imx: config: enable psci default

In reply to Frank.Li at freescale.com

From: Frank Li <[email protected]>

i.MX7D uboot support psci firmware.
Enabled psci default.

---
 arch/arm/configs/imx_v6_v7_defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/configs/imx_v6_v7_defconfig +1 -0
index 2d5253d..1e792ef 100644
@@ -47,6 +47,7 @@ CONFIG_PCI=y
 CONFIG_PCI_MSI=y
 CONFIG_PCI_IMX6=y
 CONFIG_SMP=y
+CONFIG_ARM_PSCI=y
 CONFIG_PREEMPT_VOLUNTARY=y
 CONFIG_AEABI=y
 CONFIG_HIGHMEM=y
Signature · 1 line
2.5.2
#4 lore raw

PATCH 1/3 ARM: dts: imx7d: add arch timer

In reply to Frank.Li at freescale.com
Quoted 5 lines · Frank.Li at freescale.com

From: Frank Li <[email protected]>

add cortex a7 arch timer.
uboot v2016.01-rc2 supported psci basic support.
smp can be supported by psci

This sounds a bit overly simplified log message. I am not very into this PSCI topic, is this a prerequisit for the ARM arch timers? Maybe you could elaborate that a bit more.

Also, I would prefer full sentences and commonly used spellings such as Cortex-A7, U-Boot etc...

--
Stefan

Quoted 26 lines
---
 arch/arm/boot/dts/imx7d.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)
arch/arm/boot/dts/imx7d.dtsi +9 -0
index 489604a..a621af6 100644
@@ -119,6 +119,15 @@
 		clock-output-names = "osc";
 	};
 
+	timer {
+		compatible = "arm,armv7-timer";
+		interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
+			     <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
+			     <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
+			     <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>;
+		interrupt-parent = <&intc>;
+	};
+
 	etr at 30086000 {
 		compatible = "arm,coresight-tmc", "arm,primecell";
 		reg = <0x30086000 0x1000>;
#5 lore raw

PATCH 1/3 ARM: dts: imx7d: add arch timer

Quoted 10 lines · Stefan Agner
Quoted 5 lines · Frank.Li at freescale.com

From: Frank Li <[email protected]>

add cortex a7 arch timer.
uboot v2016.01-rc2 supported psci basic support.
smp can be supported by psci

This sounds a bit overly simplified log message. I am not very into this PSCI topic, is this a prerequisit for the ARM arch timers? Maybe you could elaborate that a bit more.

No.
But according to previous discussion. Shawn want us to use psci to enable second core. We need enable arch timer if second core enabled.

Quoted 33 lines

Also, I would prefer full sentences and commonly used spellings such as Cortex-A7, U-Boot etc...

--
Stefan

Quoted 26 lines
---
 arch/arm/boot/dts/imx7d.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)
arch/arm/boot/dts/imx7d.dtsi +9 -0
index 489604a..a621af6 100644
@@ -119,6 +119,15 @@
              clock-output-names = "osc";
      };
 
+     timer {
+             compatible = "arm,armv7-timer";
+             interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
+                          <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
+                          <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
+                          <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>;
+             interrupt-parent = <&intc>;
+     };
+
      etr at 30086000 {
              compatible = "arm,coresight-tmc", "arm,primecell";
              reg = <0x30086000 0x1000>;
#6 lore raw

PATCH 1/3 ARM: dts: imx7d: add arch timer

Quoted 8 lines · Zhi Li
Quoted 7 lines · Stefan Agner
Quoted 5 lines · Frank.Li at freescale.com

From: Frank Li <[email protected]>

add cortex a7 arch timer.
uboot v2016.01-rc2 supported psci basic support.
smp can be supported by psci

Quoted 7 lines
Quoted 3 lines

This sounds a bit overly simplified log message. I am not very into this PSCI topic, is this a prerequisit for the ARM arch timers? Maybe you could elaborate that a bit more.

No.
But according to previous discussion. Shawn want us to use psci to enable second core. We need enable arch timer if second core enabled.

I guess you can make the commit log a bit better by commenting the relationship between the arch timer and secondary core.

Shawn