arm: socfpga: Fix QSPI doesn't work on socdk board
PATCH 1/1 arm: socfpga: Fix QSPI doesn't work on socdk board
Hi Marek Vasut,
On Dec 18, 2015, at 04:50 AM, Marek Vasut <[email protected]> wrote:
On Friday, December 18, 2015 at 08:57:22 AM, ?? ? wrote:
Hi Chin,
The PLL settings are copied from previous version
http://git.rocketboards.org/u-boot-socfpga.git,
This stuff should be generated by quartus, so why are you copying it from some random version of u-boot somewhere ?
Thank you for your comment, if this configuration is?automatically?generated by Quartus without manually modification, then I would like to withdraw this patch.
Best Regards,
Shengjiang Wu
?
Best regards,
Marek Vasut
PATCH 1/1 arm: socfpga: Fix QSPI doesn't work on socdk board
Quoted 8 lines · ?? ?
Hi Marek Vasut,
On Dec 18, 2015, at 04:50 AM, Marek Vasut <[email protected]> wrote:
On Friday, December 18, 2015 at 08:57:22 AM, ?? ? wrote:
Hi Chin,
Quoted 8 lines
The PLL settings are copied from previous version
http://git.rocketboards.org/u-boot-socfpga.git,This stuff should be generated by quartus, so why are you copying it from some random version of u-boot somewhere ?
Thank you for your comment, if this configuration is?automatically?generated by Quartus without manually modification, then I would like to withdraw this patch.
No, please don't. socdk should work out of the box. I should not need quartus to build a working u-boot spl for the board.
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
PATCH 1/1 arm: socfpga: Fix QSPI doesn't work on socdk board
Quoted 16 lines · Pavel Machek
Quoted 14 lines · ?? ?
Hi Marek Vasut,
On Dec 18, 2015, at 04:50 AM, Marek Vasut <[email protected]> wrote:
On Friday, December 18, 2015 at 08:57:22 AM, ?? ? wrote:
Hi Chin,The PLL settings are copied from previous version
http://git.rocketboards.org/u-boot-socfpga.git,This stuff should be generated by quartus, so why are you copying it from
some random version of u-boot somewhere ?
Quoted 8 lines
Quoted 4 lines
Thank you for your comment, if this configuration is automatically
generated by Quartus without manually modification, then I would
like to withdraw this patch.No, please don't. socdk should work out of the box. I should not need quartus to build a working u-boot spl for the board.
Yah, let's upstream this. I believe the advise here is that we use the handoff file from quartus as a golden reference.
Thanks
Chin Liang
Quoted 2 lines
Pavel
PATCH 1/1 arm: socfpga: Fix QSPI doesn't work on socdk board
Quoted 21 lines · Chin Liang See
Quoted 20 lines · Pavel Machek
Quoted 19 lines · ?? ?
Hi Marek Vasut,
On Dec 18, 2015, at 04:50 AM, Marek Vasut <[email protected]> wrote:
On Friday, December 18, 2015 at 08:57:22 AM, ?? ? wrote:
Hi Chin,The PLL settings are copied from previous version
http://git.rocketboards.org/u-boot-socfpga.git,This stuff should be generated by quartus, so why are you copying it from
some random version of u-boot somewhere ?Thank you for your comment, if this configuration is automatically
generated by Quartus without manually modification, then I would
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
like to withdraw this patch.
No, please don't. socdk should work out of the box. I should not need quartus to build a working u-boot spl for the board.
Yah, let's upstream this. I believe the advise here is that we use the handoff file from quartus as a golden reference.
The ones in mainline are from GHRD I believe.
Best regards,
Marek Vasut
PATCH 1/1 arm: socfpga: Fix QSPI doesn't work on socdk board
In reply to Pavel MachekQuoted 12 lines · Pavel Machek
Quoted 11 lines · ?? ?
Hi Marek Vasut,
On Dec 18, 2015, at 04:50 AM, Marek Vasut <[email protected]> wrote:
On Friday, December 18, 2015 at 08:57:22 AM, ?? ? wrote:
Hi Chin,The PLL settings are copied from previous version
http://git.rocketboards.org/u-boot-socfpga.git,
Quoted 8 lines
Quoted 6 lines
This stuff should be generated by quartus, so why are you copying it from some random version of u-boot somewhere ?
Thank you for your comment, if this configuration
is automatically generated by Quartus without manually modification, then I would like to withdraw this patch.No, please don't. socdk should work out of the box.
SoCDK works out of the box last time I checked (2016.01rc1), did you test it recently and do you observe problems ?
Quoted 2 lines
I should not need
quartus to build a working u-boot spl for the board.
You DO need quartus to generate the header files (that go into board/nnn/qts) to build working U-Boot SPL for any board. I fail to understand your comment, sorry.
Best regards,
Marek Vasut
PATCH 1/1 arm: socfpga: Fix QSPI doesn't work on socdk board
Quoted 16 lines · Marek Vasut
Quoted 15 lines · Pavel Machek
Quoted 14 lines · ?? ?
Hi Marek Vasut,
On Dec 18, 2015, at 04:50 AM, Marek Vasut <[email protected]> wrote:
On Friday, December 18, 2015 at 08:57:22 AM, ?? ? wrote:
Hi Chin,The PLL settings are copied from previous version
http://git.rocketboards.org/u-boot-socfpga.git,This stuff should be generated by quartus, so why are you copying it from some random version of u-boot somewhere ?
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
Thank you for your comment, if this configuration
is automatically generated by Quartus without manually modification, then I would like to withdraw this patch.No, please don't. socdk should work out of the box.
SoCDK works out of the box last time I checked (2016.01rc1), did you test it recently and do you observe problems ?
Did you test QSPI? Because that is what subject claims does not work.
Quoted 6 lines
Quoted 2 lines
I should not need
quartus to build a working u-boot spl for the board.You DO need quartus to generate the header files (that go into board/nnn/qts) to build working U-Boot SPL for any board. I fail to understand your comment, sorry.
Ok, lets talk about this personally or over phone.
Best regards,
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
PATCH 1/1 arm: socfpga: Fix QSPI doesn't work on socdk board
Quoted 21 lines · Pavel Machek
Quoted 20 lines · Marek Vasut
Quoted 19 lines · Pavel Machek
Quoted 17 lines · ?? ?
Hi Marek Vasut,
On Dec 18, 2015, at 04:50 AM, Marek Vasut <[email protected]> wrote:
On Friday, December 18, 2015 at 08:57:22 AM, ?? ? wrote:
Hi Chin,The PLL settings are copied from previous version
http://git.rocketboards.org/u-boot-socfpga.git,This stuff should be generated by quartus, so why are you copying it from some random version of u-boot somewhere ?
Thank you for your comment, if this configuration
is automatically generated by Quartus without manually modification, then I would like to withdraw this patch.
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
No, please don't. socdk should work out of the box.
SoCDK works out of the box last time I checked (2016.01rc1), did you test it recently and do you observe problems ?
Did you test QSPI? Because that is what subject claims does not work.
I'd have to retest that one, I only recall it booted and the basic functionality was OK. Feel free to test QSPI again, that'd be actually helpful.
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
I should not need
quartus to build a working u-boot spl for the board.You DO need quartus to generate the header files (that go into board/nnn/qts) to build working U-Boot SPL for any board. I fail to understand your comment, sorry.
Ok, lets talk about this personally or over phone.
Please stick to the ML.
Best regards,
Marek Vasut