Skip to contentSkip to conversation

arm: imx7d: correct chip version information

PATCH New Frank Li 2 participants 2 messages Dec 14, 2015 – Dec 21, 2015

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm i.MX and Layerscape
lore
Share & tools
lore

Frank Li

author
#0 lore raw

PATCH 1/1 arm: imx7d: correct chip version information

show correct soc version infomation.

Signed-off-by Frank Li <[email protected]>
---
 arch/arm/mach-imx/anatop.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
arch/arm/mach-imx/anatop.c +8 -1
index 231bb25..23a4fc1 100644
@@ -151,7 +151,14 @@ void __init imx_init_revision_from_anatop(void)
 		revision = IMX_CHIP_REVISION_1_5;
 		break;
 	default:
-		revision = IMX_CHIP_REVISION_UNKNOWN;
+		/*
+		 * Fail back to return raw register value instead of 0xff.
+		 * It will be easy know version information in SOC if it
+		 * can't recongized by known version. And some chip like
+		 * i.MX7D soc digprog value match linux version format,
+		 * needn't map again and direct use register value.
+		 */
+		revision = digprog & 0xff;
 	}
 
 	mxc_set_cpu_type(digprog >> 16 & 0xff);
Signature · 1 line
2.5.2
#1 lore raw

PATCH 1/1 arm: imx7d: correct chip version information

Quoted 1 line · Frank Li

show correct soc version infomation.

s/infomation/information

I feel you should write your commit log and comments a bit more seriously. The commit log above is not even a sentence.

For arch/arm/ patches sent to me, please use "ARM" rather than "arm" as subject prefix.

Quoted 12 lines
Signed-off-by Frank Li <[email protected]>
---
 arch/arm/mach-imx/anatop.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
arch/arm/mach-imx/anatop.c +0 -0
index 231bb25..23a4fc1 100644
@@ -151,7 +151,14 @@ void __init imx_init_revision_from_anatop(void)
 		revision = IMX_CHIP_REVISION_1_5;

arch/arm/mach-imx/anatop.c void __init imx_init_revision_from_anatop(void) · line 160

Quoted 10 lines
arch/arm/mach-imx/anatop.c +7 -1
 		break;
 	default:
-		revision = IMX_CHIP_REVISION_UNKNOWN;
+		/*
+		 * Fail back to return raw register value instead of 0xff.
+		 * It will be easy know version information in SOC if it
+		 * can't recongized by known version. And some chip like
+		 * i.MX7D soc digprog value match linux version format,
+		 * needn't map again and direct use register value.
+		 */

There are quite a few grammar issues in this piece of comment. Please fix them.

arch/arm/mach-imx/anatop.c void __init imx_init_revision_from_anatop(void) · line 161

Quoted 1 line
arch/arm/mach-imx/anatop.c +1 -0
+		revision = digprog & 0xff;

I'm fine with it. But we should be clear about that with this change, the "unknown revision" message in imx_print_silicon_rev() will never work then for digprog.

Shawn

Quoted 7 lines
arch/arm/mach-imx/anatop.c +0 -0
 	}
 
 	mxc_set_cpu_type(digprog >> 16 & 0xff);
Signature · 1 line
2.5.2