Skip to contentSkip to conversation

ARM: dts: sun4i: Add touchscreen node to inet9f-rev03 tablet dts file

PATCH Superseded Hans de Goede 3 participants 19 messages Dec 20, 2015 – Jan 4, 2016

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/5 ARM: dts: sun4i: Add touchscreen node to inet9f-rev03 tablet dts file

Add a node describing the focaltech ft5406ee8 touchscreen found on inet-9f-rev03 / qware qw tb-g100 tablets.

---
 arch/arm/boot/dts/sun4i-a10-inet9f-rev03.dts | 10 ++++++++++
 1 file changed, 10 insertions(+)
arch/arm/boot/dts/sun4i-a10-inet9f-rev03.dts +10 -0
index ca49b0d..d39067e 100644
@@ -253,6 +253,16 @@
 	pinctrl-names = "default";
 	pinctrl-0 = <&i2c2_pins_a>;
 	status = "okay";
+
+	ft5406ee8: touchscreen at 38 {
+		compatible = "edt,edt-ft5406";
+		reg = <0x38>;
+		interrupt-parent = <&pio>;
+		interrupts = <7 21 IRQ_TYPE_EDGE_FALLING>;
+		pinctrl-names = "default";
+		touchscreen-size-x = <800>;
+		touchscreen-size-y = <480>;
+	};
 };
 
 &lradc {
Signature · 1 line
2.5.0
#1 lore raw

PATCH 2/5 ARM: dts: sun4i: Add touchscreen node to chuwi-v7 dts file

Add a node describing the focaltech ft5306de4 touchscreen found on chuwi-v7-cw0825 tablets.

---
 arch/arm/boot/dts/sun4i-a10-chuwi-v7-cw0825.dts | 11 +++++++++++
 1 file changed, 11 insertions(+)
arch/arm/boot/dts/sun4i-a10-chuwi-v7-cw0825.dts +11 -0
index 5366089..c71b654 100644
@@ -45,6 +45,7 @@
 #include "sunxi-common-regulators.dtsi"
 #include <dt-bindings/gpio/gpio.h>
 #include <dt-bindings/input/input.h>
+#include <dt-bindings/interrupt-controller/irq.h>
 
 / {
 	model = "Chuwi V7 CW0825";
@@ -88,6 +89,16 @@
 	pinctrl-names = "default";
 	pinctrl-0 = <&i2c2_pins_a>;
 	status = "okay";
+
+	ft5306de4: touchscreen at 38 {
+		compatible = "edt,edt-ft5406";
+		reg = <0x38>;
+		interrupt-parent = <&pio>;
+		interrupts = <7 21 IRQ_TYPE_EDGE_FALLING>;
+		pinctrl-names = "default";
+		touchscreen-size-x = <1024>;
+		touchscreen-size-y = <768>;
+	};
 };
 
 &lradc {
Signature · 1 line
2.5.0
#2 lore raw

PATCH 2/5 ARM: dts: sun4i: Add touchscreen node to chuwi-v7 dts file

Quoted 21 lines · Hans de Goede

Add a node describing the focaltech ft5306de4 touchscreen found on chuwi-v7-cw0825 tablets.

---
 arch/arm/boot/dts/sun4i-a10-chuwi-v7-cw0825.dts | 11 +++++++++++
 1 file changed, 11 insertions(+)
arch/arm/boot/dts/sun4i-a10-chuwi-v7-cw0825.dts +1 -0
index 5366089..c71b654 100644
@@ -45,6 +45,7 @@
 #include "sunxi-common-regulators.dtsi"
 #include <dt-bindings/gpio/gpio.h>
 #include <dt-bindings/input/input.h>
+#include <dt-bindings/interrupt-controller/irq.h>
 
 / {
        model = "Chuwi V7 CW0825";

arch/arm/boot/dts/sun4i-a10-chuwi-v7-cw0825.dts line 98

Quoted 10 lines
arch/arm/boot/dts/sun4i-a10-chuwi-v7-cw0825.dts +7 -0
@@ -88,6 +89,16 @@
        pinctrl-names = "default";
        pinctrl-0 = <&i2c2_pins_a>;
        status = "okay";
+
+       ft5306de4: touchscreen at 38 {
+               compatible = "edt,edt-ft5406";
+               reg = <0x38>;
+               interrupt-parent = <&pio>;
+               interrupts = <7 21 IRQ_TYPE_EDGE_FALLING>;
+               pinctrl-names = "default";

Only a name and no references?

ChenYu

Quoted 9 lines
arch/arm/boot/dts/sun4i-a10-chuwi-v7-cw0825.dts +3 -1
+               touchscreen-size-x = <1024>;
+               touchscreen-size-y = <768>;
+       };
 };
 
 &lradc {
--

2.5.0

#3 lore raw

PATCH 3/5 ARM: dts: sun4i: Add touchscreen node to inet97fv2 dts file

In reply to Hans de Goede

Add a node describing the focaltech ft5306de4 touchscreen found on inet97fv2 tablets.

---
 arch/arm/boot/dts/sun4i-a10-inet97fv2.dts | 11 +++++++++++
 1 file changed, 11 insertions(+)
arch/arm/boot/dts/sun4i-a10-inet97fv2.dts +11 -0
index 77c31da..74dd458 100644
@@ -48,6 +48,7 @@
 
 #include <dt-bindings/gpio/gpio.h>
 #include <dt-bindings/input/input.h>
+#include <dt-bindings/interrupt-controller/irq.h>
 
 / {
 	model = "INet-97F Rev 02";
@@ -93,6 +94,16 @@
 	pinctrl-names = "default";
 	pinctrl-0 = <&i2c2_pins_a>;
 	status = "okay";
+
+	ft5406ee8: touchscreen at 38 {
+		compatible = "edt,edt-ft5406";
+		reg = <0x38>;
+		interrupt-parent = <&pio>;
+		interrupts = <7 21 IRQ_TYPE_EDGE_FALLING>;
+		pinctrl-names = "default";
+		touchscreen-size-x = <800>;
+		touchscreen-size-y = <480>;
+	};
 };
 
 &lradc {
Signature · 1 line
2.5.0
#4 lore raw

PATCH 3/5 ARM: dts: sun4i: Add touchscreen node to inet97fv2 dts file

Quoted 21 lines · Hans de Goede

Add a node describing the focaltech ft5306de4 touchscreen found on inet97fv2 tablets.

---
 arch/arm/boot/dts/sun4i-a10-inet97fv2.dts | 11 +++++++++++
 1 file changed, 11 insertions(+)
arch/arm/boot/dts/sun4i-a10-inet97fv2.dts +1 -0
index 77c31da..74dd458 100644
@@ -48,6 +48,7 @@
 
 #include <dt-bindings/gpio/gpio.h>
 #include <dt-bindings/input/input.h>
+#include <dt-bindings/interrupt-controller/irq.h>
 
 / {
        model = "INet-97F Rev 02";

arch/arm/boot/dts/sun4i-a10-inet97fv2.dts line 103

Quoted 10 lines
arch/arm/boot/dts/sun4i-a10-inet97fv2.dts +7 -0
@@ -93,6 +94,16 @@
        pinctrl-names = "default";
        pinctrl-0 = <&i2c2_pins_a>;
        status = "okay";
+
+       ft5406ee8: touchscreen at 38 {
+               compatible = "edt,edt-ft5406";
+               reg = <0x38>;
+               interrupt-parent = <&pio>;
+               interrupts = <7 21 IRQ_TYPE_EDGE_FALLING>;
+               pinctrl-names = "default";

Name only and no references?

ChenYu

Quoted 9 lines
arch/arm/boot/dts/sun4i-a10-inet97fv2.dts +3 -1
+               touchscreen-size-x = <800>;
+               touchscreen-size-y = <480>;
+       };
 };
 
 &lradc {
--

2.5.0

#5 lore raw

PATCH 4/5 ARM: dts: sun5i: Add dts file for the Empire Electronix D709 tablet

In reply to Hans de Goede

The Empire Electronix D709 tablet is a fairly standard 7" A13 tablet, featuring usb-wifi, a micro-sd slot, micro-usb otg and headphone jack.

Empire Electronix is written on the back of the tablet, the D709 model info can be found in the about tablet menu in android.

The PCB has no markings to speak of.

This dts file does not add support for the ft5x touchscreen found at i2c bus 1, addr 0x38, irq PG11, because it does not work out of the box. It seems it has been flashed with the wrong firmware and needs to have alternative firmware uploaded at boot to make the touchscreen work properly, when hot-booting from android into an upstream kernel the touchscreen does work.

The Memsic MXC622X accelerometer at i2c bus 1, addr 0x15 also is not enabled as there is no driver for it.

---
 arch/arm/boot/dts/Makefile                         |   1 +
 .../boot/dts/sun5i-a13-empire-electronix-d709.dts  | 241 +++++++++++++++++++++
 2 files changed, 242 insertions(+)
 create mode 100644 arch/arm/boot/dts/sun5i-a13-empire-electronix-d709.dts
arch/arm/boot/dts/Makefile +1 -0
index cdffcef..78882ae 100644
@@ -612,6 +612,7 @@ dtb-$(CONFIG_MACH_SUN5I) += \
 	sun5i-a10s-olinuxino-micro.dtb \
 	sun5i-a10s-r7-tv-dongle.dtb \
 	sun5i-a10s-wobo-i5.dtb \
+	sun5i-a13-empire-electronix-d709.dtb \
 	sun5i-a13-hsg-h702.dtb \
 	sun5i-a13-inet-98v-rev2.dtb \
 	sun5i-a13-olinuxino.dtb \
arch/arm/boot/dts/sun5i-a13-empire-electronix-d709.dts new file +241 -0

241 lines not on this page · raw message

Signature · 1 line
2.5.0
#6 lore raw

PATCH 4/5 ARM: dts: sun5i: Add dts file for the Empire Electronix D709 tablet

Hi,

Quoted 15 lines · Hans de Goede

The Empire Electronix D709 tablet is a fairly standard 7" A13 tablet, featuring usb-wifi, a micro-sd slot, micro-usb otg and headphone jack.

Empire Electronix is written on the back of the tablet, the D709 model info can be found in the about tablet menu in android.

The PCB has no markings to speak of.

This dts file does not add support for the ft5x touchscreen found at i2c bus 1, addr 0x38, irq PG11, because it does not work out of the box. It seems it has been flashed with the wrong firmware and needs to have alternative firmware uploaded at boot to make the touchscreen work properly, when hot-booting from android into an upstream kernel the touchscreen does work.

Quoted 7 lines

The Memsic MXC622X accelerometer at i2c bus 1, addr 0x15 also is not enabled as there is no driver for it.

---
 arch/arm/boot/dts/Makefile                         |   1 +
 .../boot/dts/sun5i-a13-empire-electronix-d709.dts  | 241 +++++++++++++++++++++

The contents seem the same as sun5i-q8-common.dtsi and sun5i-a13-q8-tablet.dts. Any chance you could use those instead?

On the side, any thoughts on how to handle the differences between various "Q8" tablets, like different I2C-based sensors and WiFi chips?

I'm asking because with Maxime's couple-regulator we should be able to get the RTL8723BS on the Q8 A23/33 v1.5 working.

Regards
ChenYu

Quoted 2 lines
 2 files changed, 242 insertions(+)
 create mode 100644 arch/arm/boot/dts/sun5i-a13-empire-electronix-d709.dts
#7 lore raw

[linux-sunxi] Re: [PATCH 4/5] ARM: dts: sun5i: Add dts file for the Empire Electronix D709 tablet

Hi,

Quoted 21 lines · Chen-Yu Tsai

Hi,

Quoted 18 lines · Hans de Goede

The Empire Electronix D709 tablet is a fairly standard 7" A13 tablet, featuring usb-wifi, a micro-sd slot, micro-usb otg and headphone jack.

Empire Electronix is written on the back of the tablet, the D709 model info can be found in the about tablet menu in android.

The PCB has no markings to speak of.

This dts file does not add support for the ft5x touchscreen found at i2c bus 1, addr 0x38, irq PG11, because it does not work out of the box. It seems it has been flashed with the wrong firmware and needs to have alternative firmware uploaded at boot to make the touchscreen work properly, when hot-booting from android into an upstream kernel the touchscreen does work.

The Memsic MXC622X accelerometer at i2c bus 1, addr 0x15 also is not enabled as there is no driver for it.

Quoted 7 lines
Quoted 4 lines
---
  arch/arm/boot/dts/Makefile                         |   1 +
  .../boot/dts/sun5i-a13-empire-electronix-d709.dts  | 241 +++++++++++++++++++++

The contents seem the same as sun5i-q8-common.dtsi and sun5i-a13-q8-tablet.dts. Any chance you could use those instead?

Given the special needs of the touchscreen I do not think that that is a good idea.

Quoted 2 lines

On the side, any thoughts on how to handle the differences between various "Q8" tablets, like different I2C-based sensors and WiFi chips?

For i2c based sensors the plan is to use devicetree overlays + an in kernel overlay manager which probes the i2c bus (checking known touchscreen / accelerometer addresses) and then picks the right touchscreen + accelerometer overlays.

Wifi is somewhat more tricky I must admit, esp. since there seem to be q8 a23 based tablet variants with usb wifi and others with sdio wifi. Since both busses are discoverable I'm tempted to just enable both in devicetree, and let the kernel probe and see what is actually there. This assume that the way the wifichip is powered is the same on all boards, or at least that it is safe to enable the necessary regulators on all boards ...

Quoted 2 lines

I'm asking because with Maxime's couple-regulator we should be able to get the RTL8723BS on the Q8 A23/33 v1.5 working.

So this means enabled the sdio controller (should be safe on all boards?) and enabling 2 regulators to power the wifi-chip. I think it will be safe to do this even on boards where those regulators are not used, what do you think ?

Regards,

Hans

#8 lore raw

[linux-sunxi] Re: [PATCH 4/5] ARM: dts: sun5i: Add dts file for the Empire Electronix D709 tablet

Hi,x

Quoted 14 lines · Hans de Goede
Quoted 2 lines

On the side, any thoughts on how to handle the differences between various "Q8" tablets, like different I2C-based sensors and WiFi chips?

For i2c based sensors the plan is to use devicetree overlays + an in kernel overlay manager which probes the i2c bus (checking known touchscreen / accelerometer addresses) and then picks the right touchscreen + accelerometer overlays.

Wifi is somewhat more tricky I must admit, esp. since there seem to be q8 a23 based tablet variants with usb wifi and others with sdio wifi. Since both busses are discoverable I'm tempted to just enable both in devicetree, and let the kernel probe and see what is actually there. This assume that the way the wifichip is powered is the same on all boards, or at least that it is safe to enable the necessary regulators on all boards ...

Quoted 6 lines
Quoted 2 lines

I'm asking because with Maxime's couple-regulator we should be able to get the RTL8723BS on the Q8 A23/33 v1.5 working.

So this means enabled the sdio controller (should be safe on all boards?) and enabling 2 regulators to power the wifi-chip. I think it will be safe to do this even on boards where those regulators are not used, what do you think ?

Wouldn't that introduce some useless power drain on those boards?

Thanks!
Maxime

Signature · 10 lines
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20151221/2ca1c560/attachment.sig>
#9 lore raw

[linux-sunxi] Re: [PATCH 4/5] ARM: dts: sun5i: Add dts file for the Empire Electronix D709 tablet

Hi,

Quoted 17 lines · Maxime Ripard

Hi,x

Quoted 14 lines · Hans de Goede
Quoted 2 lines

On the side, any thoughts on how to handle the differences between various "Q8" tablets, like different I2C-based sensors and WiFi chips?

For i2c based sensors the plan is to use devicetree overlays + an in kernel overlay manager which probes the i2c bus (checking known touchscreen / accelerometer addresses) and then picks the right touchscreen + accelerometer overlays.

Wifi is somewhat more tricky I must admit, esp. since there seem to be q8 a23 based tablet variants with usb wifi and others with sdio wifi. Since both busses are discoverable I'm tempted to just enable both in devicetree, and let the kernel probe and see what is actually there. This assume that the way the wifichip is powered is the same on all boards, or at least that it is safe to enable the necessary regulators on all boards ...

Quoted 8 lines
Quoted 6 lines
Quoted 2 lines

I'm asking because with Maxime's couple-regulator we should be able to get the RTL8723BS on the Q8 A23/33 v1.5 working.

So this means enabled the sdio controller (should be safe on all boards?) and enabling 2 regulators to power the wifi-chip. I think it will be safe to do this even on boards where those regulators are not used, what do you think ?

Wouldn't that introduce some useless power drain on those boards?

If nothing is attached to those regulators (which I expect to be the case when they are not used to power wifi) then I would expect the drain to be minimal, my biggest worry is some board having tied these to ground, but I don't think that is very likely.

Regards,

Hans

#10 lore raw

[linux-sunxi] Re: [PATCH 4/5] ARM: dts: sun5i: Add dts file for the Empire Electronix D709 tablet

Quoted 46 lines · Hans de Goede

Hi,

Quoted 33 lines · Maxime Ripard

Hi,x

Quoted 29 lines · Hans de Goede
Quoted 4 lines

On the side, any thoughts on how to handle the differences between various "Q8"
tablets, like different I2C-based sensors and WiFi chips?

For i2c based sensors the plan is to use devicetree overlays + an in kernel
overlay manager which probes the i2c bus (checking known touchscreen / accelerometer
addresses) and then picks the right touchscreen + accelerometer overlays.

Wifi is somewhat more tricky I must admit, esp. since there seem to be q8 a23 based
tablet variants with usb wifi and others with sdio wifi. Since both busses are
discoverable I'm tempted to just enable both in devicetree, and let the kernel probe
and see what is actually there. This assume that the way the wifichip is powered
is the same on all boards, or at least that it is safe to enable the necessary
regulators on all boards ...

Quoted 3 lines

I'm asking because with Maxime's couple-regulator we should be able to get the
RTL8723BS on the Q8 A23/33 v1.5 working.

Quoted 8 lines
Quoted 5 lines

So this means enabled the sdio controller (should be safe on all boards?) and
enabling 2 regulators to power the wifi-chip. I think it will be safe to do this
even on boards where those regulators are not used, what do you think ?

Wouldn't that introduce some useless power drain on those boards?

Quoted 7 lines

If nothing is attached to those regulators (which I expect to be the case when
they are not used to power wifi) then I would expect the drain to be minimal,
my biggest worry is some board having tied these to ground, but I don't think
that is very likely.

AFAIK the AXP datasheets mention that unused DCDC outputs should be left floating. Not sure if this applies to LDO outputs as well. But any used outputs would have a bypass capacitor.

Quoted 1 line

From the board designs I've seen, this seems to be the common case.

I'm not an electrical engineer, but I think we're covered here.

Another thing we need to deal with is the different power sequencing requirements for the different SDIO chips.

Regards
ChenYu

#11 lore raw

[linux-sunxi] Re: [PATCH 4/5] ARM: dts: sun5i: Add dts file for the Empire Electronix D709 tablet

Hi,

Quoted 59 lines · Chen-Yu Tsai
Quoted 46 lines · Hans de Goede

Hi,

Quoted 33 lines · Maxime Ripard

Hi,x

Quoted 29 lines · Hans de Goede
Quoted 4 lines

On the side, any thoughts on how to handle the differences between various "Q8"
tablets, like different I2C-based sensors and WiFi chips?

For i2c based sensors the plan is to use devicetree overlays + an in kernel
overlay manager which probes the i2c bus (checking known touchscreen / accelerometer
addresses) and then picks the right touchscreen + accelerometer overlays.

Wifi is somewhat more tricky I must admit, esp. since there seem to be q8 a23 based
tablet variants with usb wifi and others with sdio wifi. Since both busses are
discoverable I'm tempted to just enable both in devicetree, and let the kernel probe
and see what is actually there. This assume that the way the wifichip is powered
is the same on all boards, or at least that it is safe to enable the necessary
regulators on all boards ...

Quoted 3 lines

I'm asking because with Maxime's couple-regulator we should be able to get the
RTL8723BS on the Q8 A23/33 v1.5 working.

Quoted 8 lines
Quoted 5 lines

So this means enabled the sdio controller (should be safe on all boards?) and
enabling 2 regulators to power the wifi-chip. I think it will be safe to do this
even on boards where those regulators are not used, what do you think ?

Wouldn't that introduce some useless power drain on those boards?

Quoted 7 lines

If nothing is attached to those regulators (which I expect to be the case when
they are not used to power wifi) then I would expect the drain to be minimal,
my biggest worry is some board having tied these to ground, but I don't think
that is very likely.

AFAIK the AXP datasheets mention that unused DCDC outputs should be left floating. Not sure if this applies to LDO outputs as well. But any used outputs would have a bypass capacitor.

Quoted 5 lines

From the board designs I've seen, this seems to be the common case.
I'm not an electrical engineer, but I think we're covered here.

Another thing we need to deal with is the different power sequencing requirements for the different SDIO chips.

In my experience there are not that much sequences, as simply making sure all necessary resources are one before probing the sdio bus, I have yet to see a case where the order in which the resources are enabled matters.

Regards,

Hans

#12 lore raw

[linux-sunxi] Re: [PATCH 4/5] ARM: dts: sun5i: Add dts file for the Empire Electronix D709 tablet

In reply to Chen-Yu Tsai

Hi,

Quoted 13 lines · Chen-Yu Tsai
Quoted 5 lines
Quoted 5 lines
Quoted 4 lines

So this means enabled the sdio controller (should be safe on all boards?) and enabling 2 regulators to power the wifi-chip. I think it will be safe to do this even on boards where those regulators are not used, what do you think ?

Quoted 7 lines
Quoted 1 line

Wouldn't that introduce some useless power drain on those boards?

If nothing is attached to those regulators (which I expect to be the case when they are not used to power wifi) then I would expect the drain to be minimal, my biggest worry is some board having tied these to ground, but I don't think that is very likely.

Quoted 6 lines

AFAIK the AXP datasheets mention that unused DCDC outputs should be left floating. Not sure if this applies to LDO outputs as well. But any used outputs would have a bypass capacitor.

From the board designs I've seen, this seems to be the common case. I'm not an electrical engineer, but I think we're covered here.

Ok, I guess we're good then.

Thanks!
Maxime

Signature · 10 lines
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160104/222f1583/attachment-0001.sig>
#13 lore raw

PATCH 4/5 ARM: dts: sun5i: Add dts file for the Empire Electronix D709 tablet

In reply to Hans de Goede
Quoted 15 lines · Hans de Goede

The Empire Electronix D709 tablet is a fairly standard 7" A13 tablet, featuring usb-wifi, a micro-sd slot, micro-usb otg and headphone jack.

Empire Electronix is written on the back of the tablet, the D709 model info can be found in the about tablet menu in android.

The PCB has no markings to speak of.

This dts file does not add support for the ft5x touchscreen found at i2c bus 1, addr 0x38, irq PG11, because it does not work out of the box. It seems it has been flashed with the wrong firmware and needs to have alternative firmware uploaded at boot to make the touchscreen work properly, when hot-booting from android into an upstream kernel the touchscreen does work.

Quoted 4 lines

The Memsic MXC622X accelerometer at i2c bus 1, addr 0x15 also is not enabled as there is no driver for it.

Applied, thanks!
Maxime

Signature · 10 lines
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20151221/6f91f318/attachment.sig>
#14 lore raw

PATCH 5/5 ARM: dts: sun7i: Enable gmac on Wits Pro A20 DKT

In reply to Hans de Goede

The Wits Pro A20 DKT has a gbit ethernet port, enable it.

---
 arch/arm/boot/dts/sun7i-a20-wits-pro-a20-dkt.dts | 12 ++++++++++++
 1 file changed, 12 insertions(+)
arch/arm/boot/dts/sun7i-a20-wits-pro-a20-dkt.dts +12 -0
index 85b500d..dc31d47 100644
@@ -80,6 +80,18 @@
 	status = "okay";
 };
 
+&gmac {
+	pinctrl-names = "default";
+	pinctrl-0 = <&gmac_pins_rgmii_a>;
+	phy = <&phy1>;
+	phy-mode = "rgmii";
+	status = "okay";
+
+	phy1: ethernet-phy at 1 {
+		reg = <1>;
+	};
+};
+
 &i2c0 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&i2c0_pins_a>;
Signature · 1 line
2.5.0
#16 lore raw

PATCH 5/5 ARM: dts: sun7i: Enable gmac on Wits Pro A20 DKT

Quoted 6 lines · Chen-Yu Tsai
Quoted 3 lines · Hans de Goede

The Wits Pro A20 DKT has a gbit ethernet port, enable it.

Applied, thanks!
Maxime

Signature · 10 lines
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20151221/05548d80/attachment-0001.sig>
#17 lore raw

PATCH 1/5 ARM: dts: sun4i: Add touchscreen node to inet9f-rev03 tablet dts file

In reply to Hans de Goede
Quoted 13 lines · Hans de Goede

Add a node describing the focaltech ft5406ee8 touchscreen found on inet-9f-rev03 / qware qw tb-g100 tablets.

---
 arch/arm/boot/dts/sun4i-a10-inet9f-rev03.dts | 10 ++++++++++
 1 file changed, 10 insertions(+)
arch/arm/boot/dts/sun4i-a10-inet9f-rev03.dts +0 -0
index ca49b0d..d39067e 100644

arch/arm/boot/dts/sun4i-a10-inet9f-rev03.dts line 262

Quoted 10 lines
arch/arm/boot/dts/sun4i-a10-inet9f-rev03.dts +7 -0
@@ -253,6 +253,16 @@
        pinctrl-names = "default";
        pinctrl-0 = <&i2c2_pins_a>;
        status = "okay";
+
+       ft5406ee8: touchscreen at 38 {
+               compatible = "edt,edt-ft5406";
+               reg = <0x38>;
+               interrupt-parent = <&pio>;
+               interrupts = <7 21 IRQ_TYPE_EDGE_FALLING>;
+               pinctrl-names = "default";

Name only and no references?

ChenYu

Quoted 9 lines
arch/arm/boot/dts/sun4i-a10-inet9f-rev03.dts +3 -1
+               touchscreen-size-x = <800>;
+               touchscreen-size-y = <480>;
+       };
 };
 
 &lradc {
--

2.5.0

#18 lore raw

Hi,

Quoted 18 lines · Chen-Yu Tsai
Quoted 17 lines · Hans de Goede

Add a node describing the focaltech ft5406ee8 touchscreen found on inet-9f-rev03 / qware qw tb-g100 tablets.

---
  arch/arm/boot/dts/sun4i-a10-inet9f-rev03.dts | 10 ++++++++++
  1 file changed, 10 insertions(+)
arch/arm/boot/dts/sun4i-a10-inet9f-rev03.dts +1 -0
index ca49b0d..d39067e 100644
@@ -253,6 +253,16 @@
         pinctrl-names = "default";
         pinctrl-0 = <&i2c2_pins_a>;
         status = "okay";
+
Quoted 8 lines

arch/arm/boot/dts/sun4i-a10-inet9f-rev03.dts line 262

Quoted 6 lines
arch/arm/boot/dts/sun4i-a10-inet9f-rev03.dts +6 -0
+       ft5406ee8: touchscreen at 38 {
+               compatible = "edt,edt-ft5406";
+               reg = <0x38>;
+               interrupt-parent = <&pio>;
+               interrupts = <7 21 IRQ_TYPE_EDGE_FALLING>;
+               pinctrl-names = "default";

Name only and no references?

My bad (and even copy and pasted it to the 2 others), this line needs to be dropped. I'll send a v2.

Regards,

Hans