usb: Move determination of TT hub address/port into separate function

The ifdef'ed Linux kernel code uses the 1 based port number, whereas U-Boot puts a 0 based port number into the register. The reason the 0 based port number apparently works can probably be taken from the USB 2.0 spec:

8.4.2.2 Start-Split Transaction Token
... The host must correctly set the port field for single and multiple TT hub implementations. A single TT hub implementation *may ignore* the port field.

Actually, as far as I understand, a multi TT hub defaults to single TT (bAlternateSetting: 0) until switched via SetInterface, so even "port 42" would work.

The change was verified by hardcoding the port number to a wrong value, SPLIT transactions kept working (although using a DWC2 instead of MUSB). Tested hubs are the RPi onboard SMC9514 and an external "05e3:0608 Genesys Logic, Inc. USB-2.0 4-Port HUB". The former is a multi TT hub, the latter single TT only.

Addendum: Tested on sunxi/MUSB by Hans de Goede

Signed-off-by Stefan Br?ns <[email protected]>

Reviewed-by Hans de Goede <[email protected]>

Tested-by Hans de Goede <[email protected]>

Start split and complete split tokens need the hub address and the downstream port of the first HS hub (device view).

The core of the function was duplicated in both host/ehci_hcd and musb-new/usb-compat.h.

Signed-off-by Stefan Br?ns <[email protected]>

Reviewed-by Marek Vasut <[email protected]>

Reviewed-by Hans de Goede <[email protected]>

Tested-by Hans de Goede <[email protected]>

---
v2: - renamed function to usb_find_usb2_hub_address_port()
- put musb port numbering change into separate patch
v3: - do one assignment per line
v4: - fix error in musb code (udev => urb->dev)
- added Reviewed-by: et al

 common/usb.c                      | 56
+++++++++++++++++++++++++++++++++++++++ drivers/usb/host/ehci-hcd.c      
| 50 ++++------------------------------ drivers/usb/musb-new/musb_host.c 
| 10 ++++---
 drivers/usb/musb-new/usb-compat.h | 53
------------------------------------ include/usb.h                     |
12 +++++++++
 5 files changed, 80 insertions(+), 101 deletions(-)

common/usb.c +13 -0

index b177391..9f67cc1 100644
@@ -1214,4 +1214,60 @@ bool usb_device_has_child_on_port(struct usb_device
 *parent, int port) #endif
 }
 
+#ifdef CONFIG_DM_USB
+void usb_find_usb2_hub_address_port(struct usb_device *udev,
+			       uint8_t *hub_address, uint8_t *hub_port)
+{
+	struct udevice *parent;
+	struct usb_device *uparent, *ttdev;
+
+	/*
+	 * When called from usb-uclass.c: usb_scan_device() udev->dev points
+	 * to the parent udevice, not the actual udevice belonging to the
+	 * udev as the device is not instantiated yet. So when searching
+	 * for the first usb-2 parent start with udev->dev not
+	 * udev->dev->parent .

common/usb.c +33 -0

+			*hub_address = 0;
+			*hub_port = 0;
+			return;
+		}
+
+		ttdev = dev_get_parent_priv(dev);
+		parent = dev->parent;
+		uparent = dev_get_parent_priv(parent);
+	}
+	*hub_address = uparent->devnum;
+	*hub_port = ttdev->portnr;
+}
+#else
+void usb_find_usb2_hub_address_port(struct usb_device *udev,
+			       uint8_t *hub_address, uint8_t *hub_port)
+{
+	/* Find out the nearest parent which is high speed */
+	while (udev->parent->parent != NULL)
+		if (udev->parent->speed != USB_SPEED_HIGH) {
+			udev = udev->parent;
+		} else {
+			*hub_address = udev->parent->devnum;
+			*hub_port = udev->portnr;
+			return;
+		}
+
+	printf("Error: Cannot find high speed parent of usb-1 device\n");
+	*hub_address = 0;
+	*hub_port = 0;
+}
+#endif
+
+
 /* EOF */

drivers/usb/host/ehci-hcd.c +0 -0

index c85dbce..af025de 100644
@@ -279,56 +279,16 @@ static inline u8 ehci_encode_speed(enum

usb_device_speed speed) static void ehci_update_endpt2_dev_n_port(struct usb_device *udev, struct QH *qh)
{

drivers/usb/host/ehci-hcd.c +2 -17

-	struct usb_device *ttdev;
-	int parent_devnum;
+	uint8_t portnr = 0;
+	uint8_t hubaddr = 0;
 
 	if (udev->speed != USB_SPEED_LOW && udev->speed != USB_SPEED_FULL)
 		return;
 
-	/*
-	 * For full / low speed devices we need to get the devnum and portnr of
-	 * the tt, so of the first upstream usb-2 hub, there may be usb-1 hubs
-	 * in the tree before that one!
-	 */
-#ifdef CONFIG_DM_USB
-	/*
-	 * When called from usb-uclass.c: usb_scan_device() udev->dev points
-	 * to the parent udevice, not the actual udevice belonging to the
-	 * udev as the device is not instantiated yet. So when searching
-	 * for the first usb-2 parent start with udev->dev not
-	 * udev->dev->parent .
-	 */
-	struct udevice *parent;
-	struct usb_device *uparent;

drivers/usb/host/ehci-hcd.c +0 -7

-			return;
-		}
-
-		ttdev = dev_get_parent_priv(dev);
-		parent = dev->parent;
-		uparent = dev_get_parent_priv(parent);
-	}