Skip to contentSkip to conversation

Fixing xdriver_xf86-video-ati building

PATCH Superseded Lada Trimasova 3 participants 7 messages Dec 22, 2015 – Dec 23, 2015

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

cover Fixing xdriver_xf86-video-ati building

xdriver_xf86-video-ati depends on the radeon driver from libdrm and DRI support in xserver_xorg-server, to achieve this we select the Radeon mesa3d DRI driver which needs to be enabled for all architectures.

Fixes:
http://autobuild.buildroot.net/results/9da/9da4ffdf1c4ec78ae37322e253cb769340116035

Lada Trimasova (2):
Enabling mesa3d radeon driver for all architectures Fixing xdriver_xf86-video-ati dependencies

 package/mesa3d/Config.in                       | 1 -
 package/x11r7/xdriver_xf86-video-ati/Config.in | 4 ++--
 2 files changed, 2 insertions(+), 3 deletions(-)
Signature · 1 line
2.5.0
#1 lore raw

PATCH 1/2 Enabling mesa3d radeon driver for all architectures

Mesa32 radeon driver doesn't depend on x86 and can be build for all architectures.

Cc Alexey Brodkin <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Cc Peter Korsgaard <[email protected]>
---
 package/mesa3d/Config.in | 1 -
 1 file changed, 1 deletion(-)
package/mesa3d/Config.in +0 -1
index fdeb599..c2c4bf3 100644
@@ -109,7 +109,6 @@ config BR2_PACKAGE_MESA3D_DRI_DRIVER_I965
 
 config BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON
 	bool "DRI radeon driver"
-	depends on BR2_i386 || BR2_x86_64
 	select BR2_PACKAGE_MESA3D_DRI_DRIVER
 	select BR2_PACKAGE_LIBDRM_RADEON
 	help
Signature · 1 line
2.5.0
#2 lore raw

PATCH 2/2 Fixing xdriver_xf86-video-ati dependencies

In reply to Lada Trimasova

This package depends on the radeon driver from libdrm and depends on DRI support in xserver_xorg-server, to achieve this we select the Radeon mesa3d DRI driver.

Fixes:
http://autobuild.buildroot.net/results/9da/9da4ffdf1c4ec78ae37322e253cb769340116035

Cc Alexey Brodkin <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Cc Peter Korsgaard <[email protected]>
---
 package/x11r7/xdriver_xf86-video-ati/Config.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/x11r7/xdriver_xf86-video-ati/Config.in +2 -2
index 191c20f..ef96366 100644
@@ -1,8 +1,8 @@
 config BR2_PACKAGE_XDRIVER_XF86_VIDEO_ATI
 	bool "xf86-video-ati"
 	depends on BR2_PACKAGE_MESA3D
-	select BR2_PACKAGE_LIBDRM        if BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON
-	select BR2_PACKAGE_LIBDRM_RADEON if BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON
+	select BR2_PACKAGE_LIBDRM
+	select BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON        
 	select BR2_PACKAGE_XLIB_LIBXCOMPOSITE
 	select BR2_PACKAGE_XPROTO_FONTSPROTO
 	select BR2_PACKAGE_XPROTO_GLPROTO
Signature · 1 line
2.5.0
#3 lore raw

PATCH 2/2 Fixing xdriver_xf86-video-ati dependencies

Lada, All,

On 2015-12-22 16:29 +0300, Lada Trimasova spake thusly:

Quoted 20 lines

This package depends on the radeon driver from libdrm and depends on DRI support in xserver_xorg-server, to achieve this we select the Radeon mesa3d DRI driver.

Fixes:
http://autobuild.buildroot.net/results/9da/9da4ffdf1c4ec78ae37322e253cb769340116035

Cc Alexey Brodkin <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Cc Peter Korsgaard <[email protected]>
---
 package/x11r7/xdriver_xf86-video-ati/Config.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/x11r7/xdriver_xf86-video-ati/Config.in +0 -0
index 191c20f..ef96366 100644

package/x11r7/xdriver_xf86-video-ati/Config.in line 5

Quoted 7 lines
package/x11r7/xdriver_xf86-video-ati/Config.in +2 -2
@@ -1,8 +1,8 @@
 config BR2_PACKAGE_XDRIVER_XF86_VIDEO_ATI
 	bool "xf86-video-ati"
 	depends on BR2_PACKAGE_MESA3D
-	select BR2_PACKAGE_LIBDRM        if BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON
-	select BR2_PACKAGE_LIBDRM_RADEON if BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON
+	select BR2_PACKAGE_LIBDRM
+	select BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON        

You ar eremoving the 'select' on BR2_PACKAGE_LIBDRM_RADEON. This is OK with the current code, because BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON does the 'select' too.

However, does xdriver_xf86-video-ati link with libdrm_radeon directly? If so, and the build failure you linked to above seems to imply it does, then you should keep the 'select' here, because it is a direct dependency.

Otherwise, I'm Ok with the change.

Regards,
Yann E. MORIN.

Quoted 10 lines
package/x11r7/xdriver_xf86-video-ati/Config.in +0 -0
 	select BR2_PACKAGE_XLIB_LIBXCOMPOSITE
 	select BR2_PACKAGE_XPROTO_FONTSPROTO
 	select BR2_PACKAGE_XPROTO_GLPROTO
Signature · 6 lines
2.5.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#4 lore raw

PATCH 2/2 Fixing xdriver_xf86-video-ati dependencies

Right, xdriver_xf86-video-ati links with libdrm_radeon directly. I'll fix that and send an update.

Regards,

Lada Trimasova.

On Tue, 2015-12-22 at 17:45 +0100, Yann E. MORIN wrote:

Lada, All,

On 2015-12-22 16:29 +0300, Lada Trimasova spake thusly:

This package depends on the radeon driver from libdrm and depends on DRI support in xserver_xorg-server, to achieve this we select the Radeon mesa3d DRI driver.

Fixes:
http://autobuild.buildroot.net/results/9da/9da4ffdf1c4ec78ae37322e253cb769340116035

Signed-off-by Lada Trimasova <ltrimas at synopsys.com<mailto:[email protected]>>
Cc Alexey Brodkin <abrodkin at synopsys.com<mailto:[email protected]>>
Cc Thomas Petazzoni <thomas.petazzoni at free-electrons.com<mailto:[email protected]>>
Cc Peter Korsgaard <peter at korsgaard.com<mailto:[email protected]>>
---
 package/x11r7/xdriver_xf86-video-ati/Config.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/x11r7/xdriver_xf86-video-ati/Config.in +2 -2
index 191c20f..ef96366 100644
@@ -1,8 +1,8 @@
 config BR2_PACKAGE_XDRIVER_XF86_VIDEO_ATI
        bool "xf86-video-ati"
        depends on BR2_PACKAGE_MESA3D
-       select BR2_PACKAGE_LIBDRM        if BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON
-       select BR2_PACKAGE_LIBDRM_RADEON if BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON
+       select BR2_PACKAGE_LIBDRM
+       select BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON
 
 
 

You ar eremoving the 'select' on BR2_PACKAGE_LIBDRM_RADEON. This is OK with the current code, because BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON does the 'select' too.

However, does xdriver_xf86-video-ati link with libdrm_radeon directly? If so, and the build failure you linked to above seems to imply it does, then you should keep the 'select' here, because it is a direct dependency.

Otherwise, I'm Ok with the change.

Regards,
Yann E. MORIN.

select BR2_PACKAGE_XLIB_LIBXCOMPOSITE
select BR2_PACKAGE_XPROTO_FONTSPROTO
select BR2_PACKAGE_XPROTO_GLPROTO
--
2.5.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net<mailto:[email protected]>
http://lists.busybox.net/mailman/listinfo/buildroot

#5 lore raw

cover Fixing xdriver_xf86-video-ati building

In reply to Lada Trimasova

Am Tue, 22 Dec 2015 16:29:48 +0300 schrieb Lada Trimasova:

Quoted 3 lines

xdriver_xf86-video-ati depends on the radeon driver from libdrm and DRI support in xserver_xorg-server, to achieve this we select the Radeon mesa3d DRI driver which needs to be enabled for all architectures.

Hi,

please have a look at my patch and join the discussion about whether this driver can be used outside the Intel world or not ;)

http://patchwork.ozlabs.org/patch/523146/

Regards, Bernd

#6 lore raw

cover Fixing xdriver_xf86-video-ati building

Bernd, All,

On 2015-12-22 16:06 +0100, Bernd Kuhls spake thusly:

Quoted 8 lines

Am Tue, 22 Dec 2015 16:29:48 +0300 schrieb Lada Trimasova:

Quoted 3 lines

xdriver_xf86-video-ati depends on the radeon driver from libdrm and DRI support in xserver_xorg-server, to achieve this we select the Radeon mesa3d DRI driver which needs to be enabled for all architectures.

please have a look at my patch and join the discussion about whether this driver can be used outside the Intel world or not ;)

http://patchwork.ozlabs.org/patch/523146/

Well, IIUC, Radeon is the chip in AMD's portfolio, right?

So, you culd get that board:

    http://softiron.co.uk/

and plugin any PCI-E garphic card to get an Radeon GPU on AArch64.

So, no Radeon is not restricted to x86.

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'