Skip to contentSkip to conversation

nwipe: new package

PATCH New Yann E. MORIN 2 participants 2 messages Dec 22, 2015 – Dec 23, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nwipe: new package

From: Charles Duffy <[email protected]>

[yann.morin.1998 at free.fr: add missing dependencies]
Cc Ryan Barnett <[email protected]>

---
Changes v4 -> v5:
- add missing dependency to threads (Ryan)
- add missing dependency to wchar because of parted

---
 package/Config.in                                  |   1 +
 ...off_t-to-off64_t-for-musl-libc-support-11.patch | 169 +++++++++++++++++++++
 ...-libuuid-dependencies-to-allow-parted-sta.patch |  45 ++++++
 package/nwipe/Config.in                            |  14 ++
 package/nwipe/nwipe.hash                           |   1 +
 package/nwipe/nwipe.mk                             |  16 ++
 6 files changed, 246 insertions(+)
 create mode 100644 package/nwipe/0001-Move-from-loff_t-to-off64_t-for-musl-libc-support-11.patch
 create mode 100644 package/nwipe/0002-Add-libintl-libuuid-dependencies-to-allow-parted-sta.patch
 create mode 100644 package/nwipe/Config.in
 create mode 100644 package/nwipe/nwipe.hash
 create mode 100644 package/nwipe/nwipe.mk
package/Config.in +1 -0
index 4292188..9738da3 100644
@@ -1557,6 +1557,7 @@ endif
 	source "package/ncdu/Config.in"
 	source "package/numactl/Config.in"
 	source "package/nut/Config.in"
+	source "package/nwipe/Config.in"
 	source "package/openvmtools/Config.in"
 	source "package/polkit/Config.in"
 	source "package/powerpc-utils/Config.in"
package/nwipe/0001-Move-from-loff_t-to-off64_t-for-musl-libc-support-11.patch new file +169 -0

169 lines not on this page · raw message

package/nwipe/0002-Add-libintl-libuuid-dependencies-to-allow-parted-sta.patch new file +45 -0

45 lines not on this page · raw message

package/nwipe/Config.in new file +14 -0
new file mode 100644
index 0000000..a4b8f4a
@@ -0,0 +1,14 @@
+config BR2_PACKAGE_NWIPE
+	bool "nwipe"
+	depends on BR2_USE_WCHAR # parted
+	depends on BR2_TOOLCHAIN_HAS_THREADS
+	select BR2_PACKAGE_NCURSES
+	select BR2_PACKAGE_PARTED
+	help
+	  nwipe thoroughly overwrites block devices, forked from a component at
+	  the core of the venerable DBAN.
+	
+	  https://github.com/martijnvanbrummelen/nwipe
+
+comment "nwipe needs a toolchain w/ wchar"
+	depends on !BR2_USE_WCHAR
package/nwipe/nwipe.hash new file +1 -0
new file mode 100644
index 0000000..f66b5c3
@@ -0,0 +1 @@
+sha256	63a3f5fbcaf0c013790345ece2cf04c3d85a15c4505b9d92dc779465aafbd52f  nwipe-8a9a71822148cb9c82d971030dafd8d374fd1f48.tar.gz
package/nwipe/nwipe.mk new file +16 -0
new file mode 100644
index 0000000..6a26d9c
@@ -0,0 +1,16 @@
+################################################################################
+#
+# nwipe
+#
+################################################################################
+
+NWIPE_VERSION = 8a9a71822148cb9c82d971030dafd8d374fd1f48
+NWIPE_SITE = $(call github,martijnvanbrummelen,nwipe,$(NWIPE_VERSION))
+NWIPE_DEPENDENCIES = ncurses parted host-pkgconf
+NWIPE_LICENSE = GPLv2
+NWIPE_LICENSE_FILES = COPYING
+
+# no ./configure in source repository
+NWIPE_AUTORECONF = YES
+
+$(eval $(autotools-package))
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 nwipe: new package

Yann,

Thanks for respining this patch. See below for some comments.

Quoted 24 lines · Yann E. MORIN
package/nwipe/0002-Add-libintl-libuuid-dependencies-to-allow-parted-sta.patch new file +18 -0
new file mode 100644
index 0000000..1d04084
@@ -0,0 +1,45 @@
+From 7e0773c4738362f030f431a35b4e13cc2b4f36be Mon Sep 17 00:00:00 2001
+From: Charles Duffy <[email protected]>
+Date: Wed, 14 Oct 2015 16:24:01 -0500
+Subject: [PATCH 2/2] Add libintl, libuuid dependencies to allow parted static
+ link (#12)
+
+libparted requires libuuid; both require libintl. Static builds currently fail
+with link errors due to these missing dependencies.
+
+https://github.com/martijnvanbrummelen/nwipe/pull/13
+
+Signed-off-by: Charles Duffy <[email protected]>
+---
+ configure.ac    | 4 +++-
+ src/Makefile.am | 2 ++
+ 2 files changed, 5 insertions(+), 1 deletion(-)
+
+diff --git a/configure.ac b/configure.ac

package/nwipe/0002-Add-libintl-libuuid-dependencies-to-allow-parted-sta.patch line 28

Quoted 10 lines
package/nwipe/0002-Add-libintl-libuuid-dependencies-to-allow-parted-sta.patch new file +10 -0
+index 375c775..78f6624 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -42,7 +42,9 @@ PKG_CHECK_MODULES(
+ 	)]
+ )
+ 
+-AC_CHECK_LIB([parted], [ped_device_probe_all], ,[AC_MSG_ERROR([parted development library not found])])
++AC_CHECK_LIB([intl], [libintl_dgettext]) # needed to statically link libparted, but not given in its pkgconfig file
++AC_CHECK_LIB([uuid], [uuid_generate])    # needed to statically link libparted, but not given in its pkgconfig file

This really seems like a workaround for something that should instead be fixed in the parted .pc file, no? If this .pc file lacks a reference to libintl and libuuid, then parted .pc file should be fixed.

Quoted 10 lines
package/nwipe/Config.in new file +4 -0
new file mode 100644
index 0000000..a4b8f4a
@@ -0,0 +1,14 @@
+config BR2_PACKAGE_NWIPE
+	bool "nwipe"
+	depends on BR2_USE_WCHAR # parted
+	depends on BR2_TOOLCHAIN_HAS_THREADS

package/nwipe/Config.in line 14

Quoted 10 lines
package/nwipe/Config.in new file +10 -0
+	select BR2_PACKAGE_NCURSES
+	select BR2_PACKAGE_PARTED
+	help
+	  nwipe thoroughly overwrites block devices, forked from a component at
+	  the core of the venerable DBAN.
+	
+	  https://github.com/martijnvanbrummelen/nwipe
+
+comment "nwipe needs a toolchain w/ wchar"
+	depends on !BR2_USE_WCHAR

Missing comment on threads.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com