Skip to contentSkip to conversation

jQuery: introduce external plugin menu

PATCH New yegorslists at googlemail.com 3 participants 3 messages Aug 7, 2015 – Dec 23, 2015

lore
Share & tools
lore

yegorslists at googlemail.com

author
#0 lore raw

PATCH v2 1/1 jQuery: introduce external plugin menu

From: Yegor Yefremov <[email protected]>

List all jQuery plugins in a dedicated menu and remove uneeded jQuery selection.

Signed-off-by Yegor Yefremov <[email protected]>

---
Changes:
v2: make packages prompt lowercase and hyphenated

 package/Config.in                       | 4 ++++
 package/jquery-datetimepicker/Config.in | 1 -
 package/jquery-keyboard/Config.in       | 3 +--
 package/jquery-sparkline/Config.in      | 3 +--
 package/jquery-ui-themes/Config.in      | 2 +-
 package/jquery-ui/Config.in             | 3 +--
 package/jquery-validation/Config.in     | 3 +--
 7 files changed, 9 insertions(+), 10 deletions(-)
package/Config.in +4 -0
index 47d14d7..55a4576 100644
@@ -888,6 +888,8 @@ menu "Javascript"
 	source "package/explorercanvas/Config.in"
 	source "package/flot/Config.in"
 	source "package/jquery/Config.in"
+if BR2_PACKAGE_JQUERY
+menu "external jQuery plugins"
 	source "package/jquery-datetimepicker/Config.in"
 	source "package/jquery-keyboard/Config.in"
 	source "package/jquery-mobile/Config.in"

@@ -895,6 +897,8 @@ menu "Javascript"
 	source "package/jquery-ui/Config.in"
 	source "package/jquery-ui-themes/Config.in"
 	source "package/jquery-validation/Config.in"
+endmenu
+endif
 	source "package/jsmin/Config.in"
 	source "package/json-javascript/Config.in"
 endmenu
package/jquery-datetimepicker/Config.in +0 -1
index 6a07ec3..9da3718 100644
@@ -1,6 +1,5 @@
 config BR2_PACKAGE_JQUERY_DATETIMEPICKER
 	bool "jquery-datetimepicker"
-	select BR2_PACKAGE_JQUERY
 	help
 	  Use this plugin to unobtrusively add a datetimepicker,
 	  datepicker or timepicker dropdown to your forms.
package/jquery-keyboard/Config.in +1 -2
index e44193e..117c4a5 100644
@@ -1,6 +1,5 @@
 config BR2_PACKAGE_JQUERY_KEYBOARD
-	bool "jQuery keyboard"
-	select BR2_PACKAGE_JQUERY
+	bool "jquery-keyboard"
 	select BR2_PACKAGE_JQUERY_UI
 	help
 	  Virtual Keyboard using jQuery UI
package/jquery-sparkline/Config.in +1 -2
index ae66364..1741a29 100644
@@ -1,6 +1,5 @@
 config BR2_PACKAGE_JQUERY_SPARKLINE
-	bool "jQuery-Sparkline"
-	select BR2_PACKAGE_JQUERY
+	bool "jquery-sparkline"
 	help
 	  This jQuery plugin generates sparklines (small inline
 	  charts) directly in the browser using data supplied either
package/jquery-ui-themes/Config.in +1 -1
index bea1a43..a7ae11e 100644
@@ -1,5 +1,5 @@
 config BR2_PACKAGE_JQUERY_UI_THEMES
-	bool "jQuery UI themes"
+	bool "jquery-ui-themes"
 	depends on BR2_PACKAGE_JQUERY_UI
 	help
 	  Themes for jQuery UI.
package/jquery-ui/Config.in +1 -2
index f1653d5..a7c0a6d 100644
@@ -1,6 +1,5 @@
 config BR2_PACKAGE_JQUERY_UI
-	bool "jQuery UI"
-	select BR2_PACKAGE_JQUERY
+	bool "jquery-ui"
 	help
 	  jQuery UI provides abstractions for low-level interaction and
 	  animation, advanced effects and high-level, themeable widgets,
package/jquery-validation/Config.in +1 -2
index ab2ee26..39e898e 100644
@@ -1,6 +1,5 @@
 config BR2_PACKAGE_JQUERY_VALIDATION
-	bool "jQuery-Validation"
-	select BR2_PACKAGE_JQUERY
+	bool "jquery-validation"
 	help
 	  The jQuery Validation Plugin provides drop-in validation for
 	  your existing forms, while making all kinds of
Signature · 1 line
1.9.1
Applied
#1 lore raw

PATCH v2 1/1 jQuery: introduce external plugin menu

Dear yegorslists at googlemail.com,

Quoted 9 lines · yegorslists at googlemail.com

From: Yegor Yefremov <[email protected]>

List all jQuery plugins in a dedicated menu and remove uneeded jQuery selection.

Signed-off-by Yegor Yefremov <[email protected]>

---
Changes:
v2: make packages prompt lowercase and hyphenated

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH v2 1/1 jQuery: introduce external plugin menu

Yegor, Thomas, All,

On 2015-12-22 22:54 +0100, Thomas Petazzoni spake thusly:

Quoted 7 lines

Dear yegorslists at googlemail.com,

Quoted 4 lines · yegorslists at googlemail.com

From: Yegor Yefremov <[email protected]>

List all jQuery plugins in a dedicated menu and remove uneeded jQuery selection.

Hmm... A bit lte to reply, I know, but I tend to prefer we use a 'menuconfig' in that case, like we do for gstreamer, ffmpeg, Kodi, mpd, Freescale i.MX libraries...

Of course, this means the Kconfig 'source' statement must move to the jquery's Config.in and the make 'include' statements to jquery.mk.

Right, w ehave many other locations where we still do a simple 'menu' below a simple 'config', yet there's no reason to keep it that way.

I'll see if I can do something about it. ;-)

Regards,
Yann E. MORIN.

Quoted 16 lines
Quoted 4 lines
Signed-off-by Yegor Yefremov <[email protected]>

---
Changes:
v2: make packages prompt lowercase and hyphenated

Applied, thanks.

Thomas

Signature · 7 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'